Skip to content

Commit e8819e2

Browse files
committed
Don't check for existence prematurely
Of course downloaded files don't exist when the targets file containing downloadDLLs is loaded.
1 parent c88c98a commit e8819e2

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

Build/PackageRestore.targets

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -317,10 +317,7 @@
317317
SIL.Machine.Morphology.HermitCrab.dll are now provided by NuGet PackageReference. -->
318318
<ItemGroup>
319319
<!-- GeckofxHtmlToPdf dependency (shipped alongside FieldWorksPdfMaker.exe) -->
320-
<DownloadedFiles
321-
Include="$(DownloadsDir)/Args.dll"
322-
Condition="Exists('$(DownloadsDir)/Args.dll')"
323-
/>
320+
<DownloadedFiles Include="$(DownloadsDir)/Args.dll" />
324321
</ItemGroup>
325322

326323
<!-- ======================================================================================== -->
@@ -451,6 +448,7 @@
451448
/>
452449
<!-- Copy native/special-case artifacts that PackageReference doesn't handle automatically -->
453450
<ItemGroup>
451+
<!-- REVIEW (Hasso) 2026.03: when do we expect any of these files not to exist? If they don't, do we really want to continue building merrily? -->
454452
<ExistingPalasoFiles
455453
Include="@(PalasoFiles)"
456454
Condition="Exists('$(PalasoArtifactsDir)/%(Identity)')"
@@ -459,10 +457,6 @@
459457
Include="@(ChorusFiles)"
460458
Condition="Exists('$(ChorusArtifactsDir)/%(Identity)')"
461459
/>
462-
<ExistingDownloadedFiles
463-
Include="@(DownloadedFiles)"
464-
Condition="Exists('%(Identity)')"
465-
/>
466460
</ItemGroup>
467461
<!--
468462
Expected Warning: "Missing Palaso native files"
@@ -506,7 +500,7 @@
506500
/>
507501
<!-- Copy pre-populated binaries (Args.dll for GeckofxHtmlToPdf) -->
508502
<Copy
509-
SourceFiles="@(ExistingDownloadedFiles)"
503+
SourceFiles="@(DownloadedFiles)"
510504
DestinationFolder="$(dir-outputBase)"
511505
SkipUnchangedFiles="true"
512506
OverwriteReadOnlyFiles="true"

0 commit comments

Comments
 (0)