Optionally log file not found in HoneyComb

Author: FyreByrd

src/lib/server/aws/s3.ts

@@ -51,7 +51,11 @@ export class S3 {
    * @param string fileName Name of the file without path
    * @return string Contains the contents of the file
    */
-  public async readS3File(artifacts_provider: ProviderForPrefix, fileName: string) {
+  public async readS3File(
+    artifacts_provider: ProviderForPrefix,
+    fileName: string,
+    errorIfNotExists = true
+  ) {
     let fileContents = '';
     const bucket = AWSVars.artifacts();
     const filePath = getBasePrefixUrl(artifacts_provider, 'codebuild-output') + '/' + fileName;
@@ -69,10 +73,12 @@ export class S3 {
       // There is not a good way to check for file exists.  If file doesn't exist,
       // it will be caught here and an empty string returned.
       if (e instanceof NoSuchKey) {
-        span?.setStatus({
-          code: SpanStatusCode.ERROR,
-          message: `Error from S3 while getting object "${filePath}" from "${bucket}". No such key exists.`
-        });
+        if (errorIfNotExists) {
+          span?.setStatus({
+            code: SpanStatusCode.ERROR,
+            message: `Error from S3 while getting object "${filePath}" from "${bucket}". No such key exists.`
+          });
+        }
       } else if (e instanceof S3ServiceException) {
         span?.setStatus({
           code: SpanStatusCode.ERROR,

src/lib/server/job-executors/s3.ts

@@ -39,7 +39,7 @@ export async function save(job: Job<BullMQ.S3.CopyArtifacts>): Promise<unknown>
       await s3.copyS3Folder(build);
       let defaultLanguage = await s3.readS3File(build, 'play-listing/default-language.txt');
       job.log(`getExtraContent defaultLanguage: ${defaultLanguage}`);
-      const manifestFileContent = await s3.readS3File(build, 'manifest.txt');
+      const manifestFileContent = await s3.readS3File(build, 'manifest.txt', false);
       let manifest: Record<string, string | string[] | Record<string, string>> = {};
       if (manifestFileContent) {
         const manifestFiles = manifestFileContent.split('\n');
@@ -108,6 +108,8 @@ export async function save(job: Job<BullMQ.S3.CopyArtifacts>): Promise<unknown>
         const json = JSON.stringify(manifest);
         const jsonFileName = 'play-listing/manifest.json';
         await s3.writeFileToS3(json, jsonFileName, build);
+      } else {
+        job.log('No manifest found');
       }
       await prisma.build.update({
         where: { id },