Skip to content

Commit 65be685

Browse files
committed
Tidy up tests and test comments
1 parent e8987ff commit 65be685

3 files changed

Lines changed: 12 additions & 21 deletions

File tree

backend/FwLite/FwDataMiniLcmBridge.Tests/MiniLcmTests/SortingTests.cs

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,12 @@ protected override Task<IMiniLcmApi> NewApi()
1414
}
1515

1616
[Theory]
17-
[InlineData("aaaa", SortField.Headword)] // FTS rank
18-
[InlineData("a", SortField.Headword)] // non-FTS rank
19-
[InlineData("aaaa", SortField.SearchRelevance)] // FTS rank
20-
[InlineData("a", SortField.SearchRelevance)] // non-FTS rank
17+
[InlineData("aaaa", SortField.Headword)] // FTS
18+
[InlineData("a", SortField.Headword)] // non-FTS
19+
[InlineData("aaaa", SortField.SearchRelevance)] // FTS
20+
[InlineData("a", SortField.SearchRelevance)] // non-FTS
2121
public async Task SecondaryOrder_DefaultsToStem(string query, SortField sortField)
2222
{
23-
MorphType[] morphTypes = [
24-
new() { Id = Guid.NewGuid(), Kind = MorphTypeKind.Stem, Name = { ["en"] = "Stem" }, SecondaryOrder = 1 },
25-
new() { Id = Guid.NewGuid(), Kind = MorphTypeKind.BoundStem, Name = { ["en"] = "BoundStem" }, SecondaryOrder = 2 },
26-
new() { Id = Guid.NewGuid(), Kind = MorphTypeKind.Suffix, Name = { ["en"] = "Suffix" }, Postfix = "-", SecondaryOrder = 6 },
27-
];
28-
29-
foreach (var morphType in morphTypes)
30-
await Api.CreateMorphType(morphType);
31-
3223
var otherMorphTypeEntryId = Guid.NewGuid();
3324
Entry[] expected = [
3425
new() { Id = otherMorphTypeEntryId, LexemeForm = { ["en"] = "aaaa" }, MorphType = MorphTypeKind.Unknown }, // SecondaryOrder defaults to Stem = 1

backend/FwLite/LcmCrdt.Tests/MiniLcmTests/SortingTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ public override async Task DisposeAsync()
1818
}
1919

2020
[Theory]
21-
[InlineData("aaaa", SortField.Headword)] // FTS rank
22-
[InlineData("a", SortField.Headword)] // non-FTS rank
23-
[InlineData("aaaa", SortField.SearchRelevance)] // FTS rank
24-
[InlineData("a", SortField.SearchRelevance)] // non-FTS rank
21+
[InlineData("aaaa", SortField.Headword)] // FTS
22+
[InlineData("a", SortField.Headword)] // non-FTS
23+
[InlineData("aaaa", SortField.SearchRelevance)] // FTS
24+
[InlineData("a", SortField.SearchRelevance)] // non-FTS
2525
public async Task SecondaryOrder_DefaultsToStem(string query, SortField sortField)
2626
{
2727
MorphType[] morphTypes = [

backend/FwLite/MiniLcm.Tests/SortingTestsBase.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ await Api.GetEntries(new QueryOptions(new SortOptions(SortField.Headword, wsId))
5656
}
5757

5858
[Theory]
59-
[InlineData("aaaa", SortField.Headword)] // FTS rank
60-
[InlineData("a", SortField.Headword)] // non-FTS rank
61-
[InlineData("aaaa", SortField.SearchRelevance)] // FTS rank
62-
[InlineData("a", SortField.SearchRelevance)] // non-FTS rank
59+
[InlineData("aaaa", SortField.Headword)] // FTS
60+
[InlineData("a", SortField.Headword)] // non-FTS
61+
[InlineData("aaaa", SortField.SearchRelevance)] // FTS
62+
[InlineData("a", SortField.SearchRelevance)] // non-FTS
6363
public async Task MorphTokens_DoNotAffectSortOrder(string query, SortField sortField)
6464
{
6565
MorphType[] morphTypes = [

0 commit comments

Comments
 (0)