Move default value to translation result

Author: Enkidu93

machine/jobs/nmt_engine_build_job.py

@@ -115,7 +115,7 @@ def _batch_inference(
                     check_canceled()
                 for i, result in enumerate(engine.translate_batch(seg_batch)):
                     pretranslations[current_inference_step + i]["translation"] = result.translation
-                    pretranslations[current_inference_step + i]["sequenceConfidence"] = result.sequence_confidence or -1
+                    pretranslations[current_inference_step + i]["sequenceConfidence"] = result.sequence_confidence
                 current_inference_step += len(seg_batch)
                 phase_progress(ProgressStatus.from_step(current_inference_step, inference_step_count))
 

machine/translation/translation_result.py

@@ -1,4 +1,4 @@
-from typing import Iterable, Optional, Sequence
+from typing import Iterable, Sequence
 
 from .phrase import Phrase
 from .translation_sources import TranslationSources
@@ -12,7 +12,7 @@ def __init__(
         source_tokens: Iterable[str],
         target_tokens: Iterable[str],
         confidences: Iterable[float],
-        sequence_confidence: Optional[float],
+        sequence_confidence: float,
         sources: Iterable[TranslationSources],
         alignment: WordAlignmentMatrix,
         phrases: Iterable[Phrase],
@@ -52,7 +52,7 @@ def confidences(self) -> Sequence[float]:
         return self._confidences
 
     @property
-    def sequence_confidence(self) -> Optional[float]:
+    def sequence_confidence(self) -> float:
         return self._sequence_confidence
 
     @property

machine/translation/translation_result_builder.py

@@ -28,7 +28,7 @@ def __init__(
         self._confidences: List[float] = []
         self._sources: List[TranslationSources] = []
         self._phrases: List[PhraseInfo] = []
-        self._sequence_confidence: Optional[float] = None
+        self._sequence_confidence: float = -1.0
 
     @property
     def source_tokens(self) -> Sequence[str]:
@@ -51,7 +51,7 @@ def phrases(self) -> Sequence[PhraseInfo]:
         return self._phrases
 
     @property
-    def sequence_confidence(self) -> Optional[float]:
+    def sequence_confidence(self) -> float:
         return self.sequence_confidence
 
     def append_token(self, token: str, source: TranslationSources, confidence: float) -> None: