Report sync exceptions to bugsnag (#3789)

Author: pmachapman

src/SIL.XForge.Scripture/Services/ParatextSyncRunner.cs

@@ -79,6 +79,7 @@ public class ParatextSyncRunner : IParatextSyncRunner
     private readonly IDeltaUsxMapper _deltaUsxMapper;
     private readonly IParatextNotesMapper _notesMapper;
     private readonly ILogger<ParatextSyncRunner> _logger;
+    private readonly IExceptionHandler _exceptionHandler;
     private readonly IGuidService _guidService;
     private readonly IHubContext<NotificationHub, INotifier> _hubContext;
 
@@ -103,6 +104,7 @@ public ParatextSyncRunner(
         IParatextNotesMapper notesMapper,
         IHubContext<NotificationHub, INotifier> hubContext,
         ILogger<ParatextSyncRunner> logger,
+        IExceptionHandler exceptionHandler,
         IGuidService guidService
     )
     {
@@ -118,6 +120,7 @@ IGuidService guidService
         _notesMapper = notesMapper;
         _guidService = guidService;
         _hubContext = hubContext;
+        _exceptionHandler = exceptionHandler;
         _guidService = guidService;
     }
 
@@ -466,7 +469,8 @@ await UpdateBiblicalTermsAsync(
         }
         catch (Exception e)
         {
-            if (e is not TaskCanceledException)
+            // OperationCanceledException is thrown by the MongoDB Driver when a sync is canceled
+            if (e is not TaskCanceledException and not OperationCanceledException)
             {
                 StringBuilder additionalInformation = new StringBuilder();
                 foreach (var key in e.Data.Keys)
@@ -479,6 +483,7 @@ await UpdateBiblicalTermsAsync(
                 _syncMetrics.ErrorDetails = $"{e}{Environment.NewLine}{message}";
                 _logger.LogError(e, message);
                 LogMetric(message);
+                _exceptionHandler.ReportException(e);
             }
 
             await CompleteSync(false, canRollbackParatext, token);

test/SIL.XForge.Scripture.Tests/Services/ParatextSyncRunnerTests.cs

@@ -73,9 +73,10 @@ public async Task SyncAsync_Error()
         SFProject project = env.VerifyProjectSync(false);
         Assert.That(project.Sync.DataInSync, Is.False);
 
-        // Check that the failure was logged in the sync metrics
+        // Check that the failure was logged in the sync metrics and reported to bugsnag
         SyncMetrics syncMetrics = env.GetSyncMetrics("project01");
         Assert.That(syncMetrics.Status, Is.EqualTo(SyncStatus.Failed));
+        env.ExceptionHandler.Received().ReportException(Arg.Any<Exception>());
     }
 
     [Test]
@@ -3633,6 +3634,7 @@ public TestEnvironment(bool substituteRealtimeService = false, IDeltaUsxMapper d
             NotesMapper = Substitute.For<IParatextNotesMapper>();
             var hubContext = Substitute.For<IHubContext<NotificationHub, INotifier>>();
             MockLogger = new MockLogger<ParatextSyncRunner>();
+            ExceptionHandler = Substitute.For<IExceptionHandler>();
             GuidService = Substitute.For<IGuidService>();
             GuidService.NewObjectId().Returns($"syncuser0{_guidStartNum++}");
 
@@ -3648,6 +3650,7 @@ public TestEnvironment(bool substituteRealtimeService = false, IDeltaUsxMapper d
                 NotesMapper,
                 hubContext,
                 MockLogger,
+                ExceptionHandler,
                 GuidService
             );
         }
@@ -3661,6 +3664,7 @@ public TestEnvironment(bool substituteRealtimeService = false, IDeltaUsxMapper d
         public IRealtimeService SubstituteRealtimeService { get; }
         public IDeltaUsxMapper DeltaUsxMapper { get; }
         public MockLogger<ParatextSyncRunner> MockLogger { get; }
+        public IExceptionHandler ExceptionHandler { get; }
         public IGuidService GuidService { get; }
 
         /// <summary>