Upgrade test-framework with new phpcs-rules

Author: tvdijen

src/Algorithms/AlgorithmManagerDecorator.php

@@ -13,6 +13,7 @@ public function __construct(
     ) {
     }
 
+
     public function algorithmManager(): AlgorithmManager
     {
         return $this->algorithmManager;

src/Algorithms/SignatureAlgorithmBag.php

@@ -11,16 +11,19 @@ class SignatureAlgorithmBag
     /** @var \SimpleSAML\OpenID\Algorithms\SignatureAlgorithmEnum[]  */
     protected array $algorithms;
 
+
     public function __construct(SignatureAlgorithmEnum $algorithm, SignatureAlgorithmEnum ...$algorithms)
     {
         $this->algorithms = [$algorithm, ...$algorithms];
     }
 
+
     public function add(SignatureAlgorithmEnum $algorithm): void
     {
         $this->algorithms[] = $algorithm;
     }
 
+
     /**
      * @return \SimpleSAML\OpenID\Algorithms\SignatureAlgorithmEnum[]
      */
@@ -29,6 +32,7 @@ public function getAll(): array
         return $this->algorithms;
     }
 
+
     /**
      * @return \Jose\Component\Signature\Algorithm\SignatureAlgorithm[]
      */

src/Algorithms/SignatureAlgorithmEnum.php

@@ -31,6 +31,7 @@ enum SignatureAlgorithmEnum: string
     case RS384 = 'RS384';
     case RS512 = 'RS512';
 
+
     public function instance(): SignatureAlgorithm
     {
         return match ($this) {

src/Claims/ClaimInterface.php

@@ -8,5 +8,6 @@ interface ClaimInterface extends \JsonSerializable
 {
     public function getName(): string;
 
+
     public function getValue(): mixed;
 }

src/Claims/GenericClaim.php

@@ -15,16 +15,19 @@ public function __construct(
     ) {
     }
 
+
     public function getValue(): mixed
     {
         return $this->value;
     }
 
+
     public function getName(): string
     {
         return $this->name;
     }
 
+
     /**
      * @return array<non-empty-string,mixed>
      */

src/Claims/JwksClaim.php

@@ -18,6 +18,7 @@ public function __construct(
     ) {
     }
 
+
     /**
      * @return array{keys:non-empty-array<array<string,mixed>>}
      */
@@ -26,6 +27,7 @@ public function getValue(): array
         return $this->value;
     }
 
+
     /**
      * @return non-empty-string
      */
@@ -34,6 +36,7 @@ public function getName(): string
         return $this->name;
     }
 
+
     /**
      * @return array<non-empty-string,array{keys:non-empty-array<array<string,mixed>>}>
      */

src/Codebooks/MetadataPolicyOperatorsEnum.php

@@ -20,6 +20,7 @@ enum MetadataPolicyOperatorsEnum: string
     case SupersetOf = 'superset_of';
     case Essential = 'essential';
 
+
     /**
      * @return string[]
      */
@@ -28,6 +29,7 @@ public static function values(): array
         return array_column(self::cases(), 'value');
     }
 
+
     /**
      * @return string[]
      */
@@ -60,6 +62,7 @@ public function getSupportedOperatorValueTypes(): array
         };
     }
 
+
     /**
      * @return string[]
      */
@@ -87,6 +90,7 @@ public function getSupportedParameterValueTypes(): array
         };
     }
 
+
     /**
      * @return string[]
      * @throws \SimpleSAML\OpenID\Exceptions\MetadataPolicyException
@@ -105,6 +109,7 @@ public function getSupportedOperatorContainedValueTypes(): array
         };
     }
 
+
     /**
      * @return string[]
      * @throws \SimpleSAML\OpenID\Exceptions\MetadataPolicyException
@@ -124,6 +129,7 @@ public function getSupportedParameterContainedValueTypes(): array
         };
     }
 
+
     /**
      * @phpstan-ignore missingType.iterableValue (We can handle mixed type using array_diff)
      */
@@ -134,6 +140,7 @@ public function isValueSubsetOf(mixed $value, array $superset): bool
         return array_diff($value, $superset) === [];
     }
 
+
     /**
      * @phpstan-ignore missingType.iterableValue (We can handle mixed type using array_diff)
      */
@@ -145,6 +152,7 @@ public function isValueSupersetOf(mixed $value, array $subset): bool
         return array_diff($subset, $value) === [];
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\MetadataPolicyException
      */
@@ -169,6 +177,7 @@ public function isOperatorValueTypeSupported(mixed $operatorValue): bool
         return true;
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\MetadataPolicyException
      */
@@ -193,6 +202,7 @@ public function isParameterValueTypeSupported(mixed $parameterValue): bool
         return true;
     }
 
+
     /**
      * @return string[]
      */
@@ -255,6 +265,7 @@ public function getSupportedOperatorCombinations(): array
         ];
     }
 
+
     /**
      * @param string[] $operatorKeys
      */
@@ -263,6 +274,7 @@ public function isOperatorCombinationSupported(array $operatorKeys): bool
         return array_diff($operatorKeys, $this->getSupportedOperatorCombinations()) === [];
     }
 
+
     /**
      * Validate general parameter operation rules like operator combinations and operator value type.
      *
@@ -307,6 +319,7 @@ public static function validateGeneralParameterOperationRules(array $parameterOp
         }
     }
 
+
     /**
      * @param array<string,mixed> $parameterOperations
      * @throws \SimpleSAML\OpenID\Exceptions\MetadataPolicyException
@@ -505,6 +518,7 @@ public static function validateSpecificParameterOperationRules(array $parameterO
         }
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\MetadataPolicyException
      */

src/Codebooks/WellKnownEnum.php

@@ -9,6 +9,7 @@ enum WellKnownEnum: string
     case Prefix = '.well-known';
     case OpenIdFederation = 'openid-federation';
 
+
     public function path(): string
     {
         if ($this === WellKnownEnum::Prefix) {
@@ -18,6 +19,7 @@ public function path(): string
         return self::Prefix->value . '/' . $this->value;
     }
 
+
     public function uriFor(string $entityId): string
     {
         return rtrim($entityId, '/') . '/' . $this->path();

src/Core.php

@@ -52,6 +52,7 @@ class Core
 
     protected ?ClaimFactory $claimFactory = null;
 
+
     public function __construct(
         protected readonly SupportedAlgorithms $supportedAlgorithms = new SupportedAlgorithms(
             new SignatureAlgorithmBag(
@@ -67,6 +68,7 @@ public function __construct(
             ->build($timestampValidationLeeway);
     }
 
+
     public function requestObjectFactory(): RequestObjectFactory
     {
         return $this->requestObjectFactory ??= new RequestObjectFactory(
@@ -80,6 +82,7 @@ public function requestObjectFactory(): RequestObjectFactory
         );
     }
 
+
     public function clientAssertionFactory(): ClientAssertionFactory
     {
         return $this->clientAssertionFactory ??= new ClientAssertionFactory(
@@ -93,11 +96,13 @@ public function clientAssertionFactory(): ClientAssertionFactory
         );
     }
 
+
     public function helpers(): Helpers
     {
         return $this->helpers ??= new Helpers();
     }
 
+
     public function algorithmManagerDecoratorFactory(): AlgorithmManagerDecoratorFactory
     {
         if (is_null($this->algorithmManagerDecoratorFactory)) {
@@ -107,6 +112,7 @@ public function algorithmManagerDecoratorFactory(): AlgorithmManagerDecoratorFac
         return $this->algorithmManagerDecoratorFactory;
     }
 
+
     public function jwsSerializerManagerDecoratorFactory(): JwsSerializerManagerDecoratorFactory
     {
         if (is_null($this->jwsSerializerManagerDecoratorFactory)) {
@@ -116,6 +122,7 @@ public function jwsSerializerManagerDecoratorFactory(): JwsSerializerManagerDeco
         return $this->jwsSerializerManagerDecoratorFactory;
     }
 
+
     public function jwsParserFactory(): JwsParserFactory
     {
         if (is_null($this->jwsParserFactory)) {
@@ -125,6 +132,7 @@ public function jwsParserFactory(): JwsParserFactory
         return $this->jwsParserFactory;
     }
 
+
     public function jwsVerifierDecoratorFactory(): JwsVerifierDecoratorFactory
     {
         if (is_null($this->jwsVerifierDecoratorFactory)) {
@@ -134,11 +142,13 @@ public function jwsVerifierDecoratorFactory(): JwsVerifierDecoratorFactory
         return $this->jwsVerifierDecoratorFactory;
     }
 
+
     public function jwksFactory(): JwksFactory
     {
         return $this->jwksFactory ??= new JwksFactory();
     }
 
+
     public function dateIntervalDecoratorFactory(): DateIntervalDecoratorFactory
     {
         if (is_null($this->dateIntervalDecoratorFactory)) {
@@ -148,6 +158,7 @@ public function dateIntervalDecoratorFactory(): DateIntervalDecoratorFactory
         return $this->dateIntervalDecoratorFactory;
     }
 
+
     public function jwsSerializerManagerDecorator(): JwsSerializerManagerDecorator
     {
         if (is_null($this->jwsSerializerManagerDecorator)) {
@@ -158,6 +169,7 @@ public function jwsSerializerManagerDecorator(): JwsSerializerManagerDecorator
         return $this->jwsSerializerManagerDecorator;
     }
 
+
     public function jwsParser(): JwsParser
     {
         if (is_null($this->jwsParser)) {
@@ -167,6 +179,7 @@ public function jwsParser(): JwsParser
         return $this->jwsParser;
     }
 
+
     public function jwsVerifierDecorator(): JwsVerifierDecorator
     {
         if (is_null($this->jwsVerifierDecorator)) {
@@ -178,6 +191,7 @@ public function jwsVerifierDecorator(): JwsVerifierDecorator
         return $this->jwsVerifierDecorator;
     }
 
+
     public function claimFactory(): ClaimFactory
     {
         return $this->claimFactory ??= new ClaimFactory(

src/Core/ClientAssertion.php

@@ -26,6 +26,7 @@ protected function validate(): void
         );
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\JwsException
      * @throws \SimpleSAML\OpenID\Exceptions\ClientAssertionException
@@ -39,6 +40,7 @@ protected function validateIssuerAndSubject(): void
         }
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\JwsException
      * @throws \SimpleSAML\OpenID\Exceptions\ClientAssertionException
@@ -49,6 +51,7 @@ public function getIssuer(): string
         return parent::getIssuer() ?? throw new ClientAssertionException('No Issuer claim found.');
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\JwsException
      * @throws \SimpleSAML\OpenID\Exceptions\ClientAssertionException
@@ -59,6 +62,7 @@ public function getSubject(): string
         return parent::getSubject() ?? throw new ClientAssertionException('No Subject claim found.');
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\JwsException
      * @throws \SimpleSAML\OpenID\Exceptions\ClientAssertionException
@@ -69,6 +73,7 @@ public function getAudience(): array
         return parent::getAudience() ?? throw new ClientAssertionException('No Audience claim found.');
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\JwsException
      * @throws \SimpleSAML\OpenID\Exceptions\ClientAssertionException
@@ -78,6 +83,7 @@ public function getJwtId(): string
         return parent::getJwtId() ?? throw new ClientAssertionException('No JWT ID claim found.');
     }
 
+
     /**
      * @throws \SimpleSAML\OpenID\Exceptions\JwsException
      * @throws \SimpleSAML\OpenID\Exceptions\ClientAssertionException