Fix phpstan-issues

Author: tvdijen

phpstan-baseline.neon

@@ -0,0 +1,7 @@
+parameters:
+	ignoreErrors:
+		-
+			message: '#^Parameter \$assertions of class SimpleSAML\\SAML2\\XML\\samlp\\Response constructor expects array\<SimpleSAML\\SAML2\\XML\\saml\\Assertion\|SimpleSAML\\SAML2\\XML\\saml\\EncryptedAssertion\>, array\<int, SimpleSAML\\XMLSecurity\\XML\\SignableElementInterface\> given\.$#'
+			identifier: argument.type
+			count: 1
+			path: src/Controller/AttributeServer.php

phpstan.neon

@@ -2,3 +2,5 @@ parameters:
   level: 6
   paths:
     - src
+includes:
+  - phpstan-baseline.neon

src/Controller/AttributeServer.php

@@ -93,6 +93,7 @@ public function setMetadataStorageHandler(MetaDataStorageHandler $handler): void
      */
     public function main(/** @scrutinizer ignore-unused */ SOAP $soap, ServerRequest $request): RunnableResponse
     {
+        /** @var \SimpleSAML\SAML2\XML\samlp\AttributeQuery $message */
         $message = $soap->receive($request);
         Assert::isInstanceOf($message, AttributeQuery::class, InvalidDOMElementException::class);
 
@@ -103,9 +104,6 @@ public function main(/** @scrutinizer ignore-unused */ SOAP $soap, ServerRequest
             throw new Error\BadRequest('Missing <saml:Issuer> in <samlp:AttributeQuery>.');
         } else {
             $spEntityId = $issuer->getContent();
-            if ($spEntityId === null) {
-                throw new Error\BadRequest('Empty <saml:Issuer> in <samlp:AttributeQuery>.');
-            }
         }
 
         $idpMetadata = $this->metadataHandler->getMetaDataConfig($idpEntityId, 'saml20-idp-hosted');

tests/src/Controller/AttributeServerTest.php

@@ -85,12 +85,12 @@ public function testMain(): void
         $request = new ServerRequest('', '');
         $response = $c->main($soap, $request);
 
-        $this->assertInstanceOf(RunnableResponse::class, $response);
         $this->assertTrue($response->isSuccessful());
     }
 
 
     /**
+     * @param mixed $input
      * @return \SimpleSAML\SAML2\Binding\SOAP
      */
     private function getStubWithInput($input): SOAP