Fix lint issues (sorry)

Author: ghalse

src/Auth/Process/Fticks.php

@@ -17,7 +17,6 @@
 use function array_key_exists;
 use function array_keys;
 use function array_map;
-use function boolval;
 use function constant;
 use function defined;
 use function gethostbyname;
@@ -78,7 +77,7 @@ class Fticks extends Auth\ProcessingFilter
     /** @var array F-ticks attributes to exclude */
     private array $exclude = [];
 
-    /** @var bool Enable legacy handing of PN (for backwards compatibility) */
+    /** @var string Enable legacy handing of PN (for backwards compatibility) */
     private string $pnHashIsTargeted = 'none';
 
 

tests/src/Auth/Process/FticksTest.php

@@ -68,7 +68,6 @@ protected function setUp(): void
         Configuration::loadFromArray([
             'secretsalt' => 'secretsalt',
         ], '[ARRAY]', 'simplesaml');
-
     }
 
 
@@ -161,7 +160,12 @@ public function testSPwithUserIdDifferentProviders(): void
      */
     public function testSPwithUserIdLegacyBehaviour(): void
     {
-        $config = ['federation' => 'ACME', 'logdest' => 'stdout', 'identifyingAttribute' => 'eduPersonPrincipalName', 'pnHashIsTargeted' => 'both',];
+        $config = [
+            'federation' => 'ACME',
+            'logdest' => 'stdout',
+            'identifyingAttribute' => 'eduPersonPrincipalName',
+            'pnHashIsTargeted' => 'both',
+        ];
         $request = array_merge(self::$minRequest, self::$spRequest, [
             'Attributes' => [
                 'eduPersonPrincipalName' => [ 'user2@example.net' ],
@@ -186,7 +190,12 @@ public function testSPwithUserIdLegacyBehaviour(): void
      */
     public function testSPwithUserIdSourceTargeted(): void
     {
-        $config = ['federation' => 'ACME', 'logdest' => 'stdout', 'identifyingAttribute' => 'eduPersonPrincipalName', 'pnHashIsTargeted' => 'source',];
+        $config = [
+            'federation' => 'ACME',
+            'logdest' => 'stdout',
+            'identifyingAttribute' => 'eduPersonPrincipalName',
+            'pnHashIsTargeted' => 'source',
+        ];
         $request = array_merge(self::$minRequest, self::$spRequest, [
             'Attributes' => [
                 'eduPersonPrincipalName' => [ 'user2@example.net' ],
@@ -211,7 +220,12 @@ public function testSPwithUserIdSourceTargeted(): void
      */
     public function testSPwithUserIdSourceTargetedDifferentDest(): void
     {
-        $config = ['federation' => 'ACME', 'logdest' => 'stdout', 'identifyingAttribute' => 'eduPersonPrincipalName', 'pnHashIsTargeted' => 'source',];
+        $config = [
+            'federation' => 'ACME',
+            'logdest' => 'stdout',
+            'identifyingAttribute' => 'eduPersonPrincipalName',
+            'pnHashIsTargeted' => 'source',
+        ];
         $request = array_merge(self::$minRequest, self::$spRequest, [
             'Attributes' => [
                 'eduPersonPrincipalName' => [ 'user2@example.net' ],
@@ -237,7 +251,12 @@ public function testSPwithUserIdSourceTargetedDifferentDest(): void
      */
     public function testSPwithUserIdDestinationTargeted(): void
     {
-        $config = ['federation' => 'ACME', 'logdest' => 'stdout', 'identifyingAttribute' => 'eduPersonPrincipalName', 'pnHashIsTargeted' => 'destination',];
+        $config = [
+            'federation' => 'ACME',
+            'logdest' => 'stdout',
+            'identifyingAttribute' => 'eduPersonPrincipalName',
+            'pnHashIsTargeted' => 'destination',
+        ];
         $request = array_merge(self::$minRequest, self::$spRequest, [
             'Attributes' => [
                 'eduPersonPrincipalName' => [ 'user2@example.net' ],
@@ -263,7 +282,12 @@ public function testSPwithUserIdDestinationTargeted(): void
      */
     public function testSPwithUserIdDestinationTargetedDifferentSource(): void
     {
-        $config = ['federation' => 'ACME', 'logdest' => 'stdout', 'identifyingAttribute' => 'eduPersonPrincipalName', 'pnHashIsTargeted' => 'destination',];
+        $config = [
+            'federation' => 'ACME',
+            'logdest' => 'stdout',
+            'identifyingAttribute' => 'eduPersonPrincipalName',
+            'pnHashIsTargeted' => 'destination',
+        ];
         $request = array_merge(self::$minRequest, self::$spRequest, [
             'Attributes' => [
                 'eduPersonPrincipalName' => [ 'user2@example.net' ],