Cleanup phpdoc

Author: tvdijen

src/Auth/Process/OTP.php

@@ -23,15 +23,11 @@ class OTP extends Auth\ProcessingFilter
 {
     /**
      * The API client identifier.
-     *
-     * @var string
      */
     private string $apiClient;
 
     /**
      * The API key to use.
-     *
-     * @var string
      */
     private string $apiKey;
 
@@ -51,42 +47,32 @@ class OTP extends Auth\ProcessingFilter
 
     /**
      * Whether to abort authentication if no yubikey is known for the user or not.
-     *
-     * @var bool
      */
     private bool $abortIfMissing;
 
     /**
      * The name of the attribute containing the yubikey ID.
      *
      * Defaults to "yubikey".
-     *
-     * @var string
      */
     private string $keyIdAttr;
 
     /**
      * The name of the attribute that expresses successful authentication with the yubikey.
      *
      * Defaults to "eduPersonAssurance".
-     *
-     * @var string
      */
     private string $assuranceAttr;
 
     /**
      * The value of the "assurance" attribute that conveys successful authentication with a yubikey.
      *
      * Defaults to "OTP".
-     *
-     * @var string
      */
     private string $assuranceValue;
 
     /**
      * The auth source associated with this authproc.
-     *
-     * @var string
      */
     private string $authid;
 

src/Controller/Yubikey.php

@@ -24,14 +24,12 @@
 class Yubikey
 {
     /**
-     * @var \SimpleSAML\Auth\State|string
-     * @psalm-var \SimpleSAML\Auth\State|class-string
+     * @var \SimpleSAML\Auth\State|class-string
      */
     protected $authState = Auth\State::class;
 
     /**
-     * @var \SimpleSAML\Module\yubikey\Auth\Process\OTP|string
-     * @psalm-var \SimpleSAML\Module\yubikey\Auth\Process\OTP|class-string
+     * @var \SimpleSAML\Module\yubikey\Auth\Process\OTP|class-string
      */
     protected $otp = OTP::class;
 

tests/src/Controller/YubikeyTest.php

@@ -53,8 +53,6 @@ protected function setUp(): void
 
     /**
      * Test that accessing the otp-endpoint without state results in an error-response
-     *
-     * @return void
      */
     public function testOtpNoState(): void
     {
@@ -74,8 +72,6 @@ public function testOtpNoState(): void
 
     /**
      * Test that accessing the otp-endpoint without otp results in a Template
-     *
-     * @return void
      */
     public function testOtpNoOtp(): void
     {
@@ -101,8 +97,6 @@ public static function loadState(string $id, string $stage, bool $allowMissing =
 
     /**
      * Test that accessing the otp-endpoint with invalid otp returns Template
-     *
-     * @return void
      */
     public function testOtpFailed(): void
     {
@@ -134,8 +128,6 @@ public static function authenticate(array &$state, string $otp): bool
 
     /**
      * Test that accessing the otp-endpoint with valid otp returns RunnableResponse
-     *
-     * @return void
      */
     public function testOtpSucceeded(): void
     {
@@ -167,8 +159,6 @@ public static function authenticate(array &$state, string $otp): bool
 
     /**
      * Test that accessing the otp-endpoint when an unexpected exception occurs returns a Template
-     *
-     * @return void
      */
     public function testOtpUnexpectedException(): void
     {