Skip to content

Commit 16f77c4

Browse files
committed
Explicit nullable type
1 parent f1f8730 commit 16f77c4

15 files changed

Lines changed: 19 additions & 19 deletions

src/AbstractElement.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ abstract class AbstractElement implements SerializableElementInterface
3636
* @param \DOMElement|null $parent The element we should append to.
3737
* @return \DOMElement
3838
*/
39-
public function instantiateParentElement(DOMElement $parent = null): DOMElement
39+
public function instantiateParentElement(?DOMElement $parent = null): DOMElement
4040
{
4141
$qualifiedName = $this->getQualifiedName();
4242
$namespace = static::getNamespaceURI();

src/Base64ElementTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,5 +60,5 @@ abstract public static function getLocalName(): string;
6060
* @param \DOMElement|null $parent The element we should append to.
6161
* @return \DOMElement
6262
*/
63-
abstract public function instantiateParentElement(DOMElement $parent = null): DOMElement;
63+
abstract public function instantiateParentElement(?DOMElement $parent = null): DOMElement;
6464
}

src/BooleanElementTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public static function fromXML(DOMElement $xml): static
5858
* @param \DOMElement|null $parent
5959
* @return \DOMElement
6060
*/
61-
final public function toXML(DOMElement $parent = null): DOMElement
61+
final public function toXML(?DOMElement $parent = null): DOMElement
6262
{
6363
$e = $this->instantiateParentElement($parent);
6464
$e->textContent = $this->getContent();

src/Chunk.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public function getNamespaceURI(): ?string
9999
*
100100
* @param string|null $namespaceURI
101101
*/
102-
protected function setNamespaceURI(string $namespaceURI = null): void
102+
protected function setNamespaceURI(?string $namespaceURI = null): void
103103
{
104104
Assert::nullOrValidURI($namespaceURI, SchemaViolationException::class);
105105
$this->namespaceURI = $namespaceURI;
@@ -133,7 +133,7 @@ public function getPrefix(): string
133133
*
134134
* @param string|null $prefix
135135
*/
136-
protected function setPrefix(string $prefix = null): void
136+
protected function setPrefix(?string $prefix = null): void
137137
{
138138
$this->prefix = strval($prefix);
139139
}
@@ -304,7 +304,7 @@ public static function fromXML(DOMElement $xml): static
304304
* @param \DOMElement|null $parent The element we should append this element to.
305305
* @return \DOMElement The new element.
306306
*/
307-
public function toXML(DOMElement $parent = null): DOMElement
307+
public function toXML(?DOMElement $parent = null): DOMElement
308308
{
309309
if ($parent === null) {
310310
$doc = DOMDocumentFactory::create();

src/ExtendableAttributesTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public function getAttributesNS(): array
9393
*
9494
* @return array<int, \SimpleSAML\XML\Attribute> $attributes
9595
*/
96-
protected static function getAttributesNSFromXML(DOMElement $xml, NS|array $namespace = null): array
96+
protected static function getAttributesNSFromXML(DOMElement $xml, NS|array|null $namespace = null): array
9797
{
9898
$namespace = $namespace ?? self::XS_ANY_ATTR_NAMESPACE;
9999
$exclusionList = self::getAttributeExclusions();

src/ExtendableElementTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ trait ExtendableElementTrait
4242
*
4343
* @return list<\SimpleSAML\XML\SerializableElementInterface> $elements
4444
*/
45-
protected static function getChildElementsFromXML(DOMElement $xml, NS|array $namespace = null): array
45+
protected static function getChildElementsFromXML(DOMElement $xml, NS|array|null $namespace = null): array
4646
{
4747
$namespace = $namespace ?? self::XS_ANY_ELT_NAMESPACE;
4848
$exclusionList = self::getElementExclusions();

src/LocalizedStringElementTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public static function fromXML(DOMElement $xml): static
9090
* @param \DOMElement|null $parent
9191
* @return \DOMElement
9292
*/
93-
final public function toXML(DOMElement $parent = null): DOMElement
93+
final public function toXML(?DOMElement $parent = null): DOMElement
9494
{
9595
$e = $this->instantiateParentElement($parent);
9696
$e->setAttributeNS(C::NS_XML, 'xml:lang', $this->getLanguage());

src/QNameElementTrait.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public static function fromXML(DOMElement $xml): static
111111
* @param \DOMElement|null $parent The element we should append this element to.
112112
* @return \DOMElement
113113
*/
114-
public function toXML(DOMElement $parent = null): DOMElement
114+
public function toXML(?DOMElement $parent = null): DOMElement
115115
{
116116
$e = $this->instantiateParentElement($parent);
117117

@@ -140,5 +140,5 @@ abstract public static function getLocalName(): string;
140140
* @param \DOMElement|null $parent The element we should append to.
141141
* @return \DOMElement
142142
*/
143-
abstract public function instantiateParentElement(DOMElement $parent = null): DOMElement;
143+
abstract public function instantiateParentElement(?DOMElement $parent = null): DOMElement;
144144
}

src/SerializableElementInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,5 @@ public static function fromXML(DOMElement $xml): static;
4444
* @param \DOMElement|null $parent
4545
* @return \DOMElement
4646
*/
47-
public function toXML(DOMElement $parent = null): DOMElement;
47+
public function toXML(?DOMElement $parent = null): DOMElement;
4848
}

src/SerializableElementTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,5 +86,5 @@ public function __unserialize(array $serialized): void
8686
* @param \DOMElement|null $parent
8787
* @return \DOMElement
8888
*/
89-
abstract public function toXML(DOMElement $parent = null): DOMElement;
89+
abstract public function toXML(?DOMElement $parent = null): DOMElement;
9090
}

0 commit comments

Comments
 (0)