Remove problematic options

tvdijen · tvdijen · commit f6dfe8e0b6ee · 2024-11-19T10:25:04.000+01:00
diff --git a/src/DOMDocumentFactory.php b/src/DOMDocumentFactory.php
@@ -38,7 +38,8 @@ public static function fromString(string $xml): DOMDocument
         libxml_clear_errors();
 
         $domDocument = self::create();
-        $options = LIBXML_DTDLOAD | LIBXML_DTDATTR | LIBXML_NONET | LIBXML_PARSEHUGE | LIBXML_NSCLEAN;
+        /** @TODO: LIBXML_NO_XXE is available as of PHP 8.4 */
+        $options = LIBXML_NONET | LIBXML_PARSEHUGE /* | LIBXML_NO_XXE */;
         if (defined('LIBXML_COMPACT')) {
             $options |= LIBXML_COMPACT;
         }

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,8 @@ public static function fromString(string $xml): DOMDocument`
`38`	`38`	`libxml_clear_errors();`
`39`	`39`
`40`	`40`	`$domDocument = self::create();`
`41`		`- $options = LIBXML_DTDLOAD \| LIBXML_DTDATTR \| LIBXML_NONET \| LIBXML_PARSEHUGE \| LIBXML_NSCLEAN;`
	`41`	`+ /** @TODO: LIBXML_NO_XXE is available as of PHP 8.4 */`
	`42`	`+ $options = LIBXML_NONET \| LIBXML_PARSEHUGE /* \| LIBXML_NO_XXE */;`
`42`	`43`	`if (defined('LIBXML_COMPACT')) {`
`43`	`44`	`$options \|= LIBXML_COMPACT;`
`44`	`45`	`}`