fix(favicon): lighter pink/yellow hues, fix CI env-flags naming check

- dev favicon: orange -> light pink
- staging favicon: yellow -> lighter yellow
  (mark stays pixel-identical, background color only)
- env-flags.ts's CI check requires every exported const to be is-/get-
  prefixed; deploymentEnv was a plain const. Converted to
  getDeploymentEnv(), matching the file's existing convention for
  non-boolean values (getCostMultiplier(), getAllowedIntegrationsFromEnv()).

Author: waleedlatif1

apps/sim/ee/whitelabeling/metadata.ts

@@ -1,5 +1,5 @@
 import type { Metadata } from 'next'
-import { deploymentEnv } from '@/lib/core/config/env-flags'
+import { getDeploymentEnv } from '@/lib/core/config/env-flags'
 import { getBaseUrl, SITE_URL } from '@/lib/core/utils/urls'
 import { getBrandConfig } from '@/ee/whitelabeling/branding'
 
@@ -13,14 +13,14 @@ interface FaviconSet {
 }
 
 /**
- * Same "sim" wordmark per {@link deploymentEnv}, background color only —
+ * Same "sim" wordmark per {@link getDeploymentEnv}, background color only —
  * so a dev/staging tab is never mistaken for prod at a glance. Ignored
  * entirely when `brand.faviconUrl` is set (a whitelabeled deployment's own
  * favicon always wins, regardless of which tier it's running on). Kept in
  * sync with `FAVICON_ICO_DESTINATIONS` in `next.config.ts`, which handles
  * the legacy `/favicon.ico` path the same way.
  */
-const ICON_SETS: Record<typeof deploymentEnv, FaviconSet> = {
+const ICON_SETS: Record<ReturnType<typeof getDeploymentEnv>, FaviconSet> = {
   development: {
     svg: '/icon-dev.svg',
     favicon16: '/favicon-dev/favicon-16x16.png',
@@ -52,7 +52,7 @@ const ICON_SETS: Record<typeof deploymentEnv, FaviconSet> = {
  */
 export function generateBrandedMetadata(override: Partial<Metadata> = {}): Metadata {
   const brand = getBrandConfig()
-  const icons = ICON_SETS[deploymentEnv]
+  const icons = ICON_SETS[getDeploymentEnv()]
 
   const defaultTitle = brand.name
   const summaryFull = `Sim is the open-source AI workspace where teams build, deploy, and manage AI agents. Connect 1,000+ integrations and every major LLM to create agents that automate real work — visually, conversationally, or with code. Trusted by over 100,000 builders — from startups to Fortune 500 companies. SOC2 compliant.`

apps/sim/lib/core/config/env-flags.ts

@@ -30,28 +30,31 @@ export const isTest = env.NODE_ENV === 'test'
  * AWS Secrets Manager for dev/staging/production, so this reuses it rather
  * than inventing a second one.
  */
-const rawDeploymentEnv =
-  process.env.OTEL_DEPLOYMENT_ENVIRONMENT ||
-  process.env.DEPLOYMENT_ENVIRONMENT ||
-  (process.env.APPCONFIG_ENVIRONMENT === 'production'
-    ? 'prod'
-    : process.env.APPCONFIG_ENVIRONMENT) ||
-  env.NODE_ENV ||
-  'development'
+function resolveRawDeploymentEnv(): string {
+  return (
+    process.env.OTEL_DEPLOYMENT_ENVIRONMENT ||
+    process.env.DEPLOYMENT_ENVIRONMENT ||
+    (process.env.APPCONFIG_ENVIRONMENT === 'production'
+      ? 'prod'
+      : process.env.APPCONFIG_ENVIRONMENT) ||
+    env.NODE_ENV ||
+    'development'
+  )
+}
 
 /**
  * The deployment tier this build is running in, bucketed from
- * {@link rawDeploymentEnv} to a fixed three-way set for UI-facing branches —
- * currently just per-environment favicons, so it's obvious at a glance which
- * tab is prod vs. a staging/local build. See `ee/whitelabeling/metadata.ts`
- * and `next.config.ts`.
- */
-export const deploymentEnv: 'development' | 'staging' | 'production' =
-  rawDeploymentEnv === 'staging'
-    ? 'staging'
-    : rawDeploymentEnv === 'prod' || rawDeploymentEnv === 'production'
-      ? 'production'
-      : 'development'
+ * {@link resolveRawDeploymentEnv} to a fixed three-way set for UI-facing
+ * branches — currently just per-environment favicons, so it's obvious at a
+ * glance which tab is prod vs. a staging/local build. See
+ * `ee/whitelabeling/metadata.ts` and `next.config.ts`.
+ */
+export function getDeploymentEnv(): 'development' | 'staging' | 'production' {
+  const raw = resolveRawDeploymentEnv()
+  if (raw === 'staging') return 'staging'
+  if (raw === 'prod' || raw === 'production') return 'production'
+  return 'development'
+}
 
 /**
  * Is this the hosted version of the application.

apps/sim/next.config.ts

@@ -1,7 +1,7 @@
 import path from 'node:path'
 import type { NextConfig } from 'next'
 import { env, isTruthy } from './lib/core/config/env'
-import { deploymentEnv, isDev } from './lib/core/config/env-flags'
+import { getDeploymentEnv, isDev } from './lib/core/config/env-flags'
 import {
   getChatEmbedCSPPolicy,
   getMainCSPPolicy,
@@ -33,7 +33,7 @@ const minimalRegistryAlias: Record<string, string> = useMinimalRegistry
  * `<link rel="icon">` tags Next renders from `generateBrandedMetadata()`
  * (`ee/whitelabeling/metadata.ts`) use the same per-environment set.
  */
-const FAVICON_ICO_DESTINATIONS: Record<typeof deploymentEnv, string> = {
+const FAVICON_ICO_DESTINATIONS: Record<ReturnType<typeof getDeploymentEnv>, string> = {
   development: '/icon-dev.svg',
   staging: '/icon-staging.svg',
   production: '/icon.svg',
@@ -451,7 +451,7 @@ const nextConfig: NextConfig = {
     return [
       {
         source: '/favicon.ico',
-        destination: FAVICON_ICO_DESTINATIONS[deploymentEnv],
+        destination: FAVICON_ICO_DESTINATIONS[getDeploymentEnv()],
       },
       {
         source: '/r/:shortCode',