Skip to content

Commit 48cf200

Browse files
authored
fix(helm): allow host[:port][/path] form in global.imageRegistry schema (#4686)
The values.schema.json constrained global.imageRegistry to JSON Schema hostname format (RFC 1123), which forbids '/'. That rejected the host+path form required by Artifactory virtual repos, Harbor projects, GCR (gcr.io/project-id), and ECR-with-namespace — all of which the chart's image-rendering helper already supports (it prints '%s/%s:%s'). Drop the format constraint and document the supported shapes. Matches the bitnami common-chart convention of validating image registry as a plain string and deferring to Docker for the actual reference parse.
1 parent 4445e31 commit 48cf200

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

helm/sim/values.schema.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
"properties": {
99
"imageRegistry": {
1010
"type": "string",
11-
"format": "hostname",
12-
"description": "Global Docker image registry"
11+
"description": "Global Docker image registry (host[:port][/path]). Supports plain hosts (registry.example.com), host:port (registry.example.com:5000), and host+path forms used by Artifactory virtual repos, Harbor projects, GCR (gcr.io/project-id), and ECR-with-namespace."
1312
},
1413
"useRegistryForAllImages": {
1514
"type": "boolean",

0 commit comments

Comments
 (0)