fix(knowledge): keep import records through account deletion, and recheck uploads on re-dispatch

- knowledge_base_import.user_id is attribution only, so the janitor's cleanup record outlives its importer's account
- re-dispatching an unclaimed import repeats the knowledge.upload assertion

Author: waleedlatif1

apps/sim/lib/knowledge/application/imports.ts

@@ -277,6 +277,8 @@ async function redispatchUnclaimedImport(
   record: KnowledgeImportRecord
 ): Promise<void> {
   if (record.status !== 'running' || record.startedAt) return
+  // A group that withdrew uploads since the record was written stops it here too.
+  await assertImportedDocumentsAllowed(principal, context.workspaceId)
   try {
     await startKnowledgeImport(await importPayload(principal, context))
   } catch (error) {

packages/db/migrations/0436_knowledge_base_import.sql

@@ -19,7 +19,6 @@ CREATE TABLE "knowledge_base_import" (
 );
 --> statement-breakpoint
 ALTER TABLE "knowledge_base_import" ADD CONSTRAINT "knowledge_base_import_workspace_id_workspace_id_fk" FOREIGN KEY ("workspace_id") REFERENCES "public"."workspace"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
-ALTER TABLE "knowledge_base_import" ADD CONSTRAINT "knowledge_base_import_user_id_user_id_fk" FOREIGN KEY ("user_id") REFERENCES "public"."user"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint
 ALTER TABLE "knowledge_base_import" ADD CONSTRAINT "knowledge_base_import_knowledge_base_id_knowledge_base_id_fk" FOREIGN KEY ("knowledge_base_id") REFERENCES "public"."knowledge_base"("id") ON DELETE set null ON UPDATE no action;--> statement-breakpoint
 CREATE INDEX "knowledge_base_import_watchdog_idx" ON "knowledge_base_import" USING btree ("status","updated_at");--> statement-breakpoint
 CREATE INDEX "knowledge_base_import_knowledge_base_id_idx" ON "knowledge_base_import" USING btree ("knowledge_base_id");

packages/db/migrations/meta/0436_snapshot.json

@@ -1,5 +1,5 @@
 {
-  "id": "a7a19a4e-8207-4fbf-918c-f5ae171bd9cc",
+  "id": "0ac8e6c1-9440-4310-9af4-7ab28dc2de42",
   "prevId": "2a4095de-e341-4264-becd-1714d26404f5",
   "version": "7",
   "dialect": "postgresql",
@@ -10223,15 +10223,6 @@
           "onDelete": "cascade",
           "onUpdate": "no action"
         },
-        "knowledge_base_import_user_id_user_id_fk": {
-          "name": "knowledge_base_import_user_id_user_id_fk",
-          "tableFrom": "knowledge_base_import",
-          "tableTo": "user",
-          "columnsFrom": ["user_id"],
-          "columnsTo": ["id"],
-          "onDelete": "cascade",
-          "onUpdate": "no action"
-        },
         "knowledge_base_import_knowledge_base_id_knowledge_base_id_fk": {
           "name": "knowledge_base_import_knowledge_base_id_knowledge_base_id_fk",
           "tableFrom": "knowledge_base_import",

packages/db/migrations/meta/_journal.json

@@ -3050,7 +3050,7 @@
     {
       "idx": 436,
       "version": "7",
-      "when": 1792720602032,
+      "when": 1792721320645,
       "tag": "0436_knowledge_base_import",
       "breakpoints": true
     }

packages/db/schema.ts

@@ -3865,9 +3865,11 @@ export const knowledgeBaseImport = pgTable(
     workspaceId: text('workspace_id')
       .notNull()
       .references(() => workspace.id, { onDelete: 'cascade' }),
-    userId: text('user_id')
-      .notNull()
-      .references(() => user.id, { onDelete: 'cascade' }),
+    /**
+     * Attribution only, with no foreign key: the row is the janitor's handle on
+     * the bundle and the base, so it must outlive its importer's account.
+     */
+    userId: text('user_id').notNull(),
     /** The uploaded archive, deleted once the import settles. */
     sourceKey: text('source_key').notNull(),
     knowledgeBaseId: text('knowledge_base_id').references(() => knowledgeBase.id, {