Commit 84e7aad
improvement(slack): request the approved mention/assistant/DM scopes, advertised on v2 only (#5898)
Slack app review has since approved `app_mentions:read`, `assistant:write`, and
`im:history` — they are live in the prod app manifest's `oauth_config.scopes.bot`
— but the repo still had them commented out behind a stale "re-add once approved"
TODO. Sim was therefore requesting a narrower grant than the app is entitled to,
so newly connected accounts got tokens missing exactly the scopes backing three
`simSubscribed` events on the native Sim app trigger: `app_mention`
(app_mentions:read), assistant threads (assistant:write), and DMs (im:history).
The requested scope set now matches the manifest's 20 approved bot scopes exactly.
Scopes are per-credential, not per-block (one Slack app -> one `slack` provider ->
one shared token, requested server-side via getCanonicalScopesForProvider), so the
grant itself cannot be scoped to v2. What is per-block is what each picker
advertises and treats as missing, so:
- slack_v2 + the slack_oauth trigger advertise the full set (they host the native
Sim app trigger that needs it).
- The legacy v1 block stays pinned to the pre-expansion 17 scopes. It has no
feature needing the new three, and advertising them there would flag every
existing Slack credential as missing scopes and prompt a needless reconnect.
Claude-Session: https://claude.ai/code/session_018asmKsWQ5Vi7T7wD9uHofz
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent bc237a0 commit 84e7aad
2 files changed
Lines changed: 26 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
10 | 29 | | |
11 | 30 | | |
12 | 31 | | |
| |||
107 | 126 | | |
108 | 127 | | |
109 | 128 | | |
110 | | - | |
| 129 | + | |
111 | 130 | | |
112 | 131 | | |
113 | 132 | | |
| |||
2642 | 2661 | | |
2643 | 2662 | | |
2644 | 2663 | | |
| 2664 | + | |
| 2665 | + | |
| 2666 | + | |
2645 | 2667 | | |
2646 | 2668 | | |
2647 | 2669 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
782 | 782 | | |
783 | 783 | | |
784 | 784 | | |
785 | | - | |
786 | | - | |
787 | | - | |
788 | | - | |
789 | | - | |
790 | | - | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
791 | 788 | | |
792 | 789 | | |
793 | 790 | | |
| |||
0 commit comments