fix(memories): get memory tool, mem0 integration update

Author: icecrasher321

apps/sim/app/api/memory/[id]/route.ts

@@ -1,7 +1,7 @@
 import { db } from '@sim/db'
 import { memory } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
-import { and, eq } from 'drizzle-orm'
+import { and, eq, isNull } from 'drizzle-orm'
 import { type NextRequest, NextResponse } from 'next/server'
 import {
   agentMemoryDataSchemaContract,
@@ -75,7 +75,13 @@ export const GET = withRouteHandler(async (request: NextRequest, context: Memory
     const memories = await db
       .select()
       .from(memory)
-      .where(and(eq(memory.key, id), eq(memory.workspaceId, validatedWorkspaceId)))
+      .where(
+        and(
+          eq(memory.key, id),
+          eq(memory.workspaceId, validatedWorkspaceId),
+          isNull(memory.deletedAt)
+        )
+      )
       .orderBy(memory.createdAt)
       .limit(1)
 

apps/sim/blocks/blocks/mem0.test.ts

@@ -0,0 +1,35 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import { Mem0Block } from '@/blocks/blocks/mem0'
+
+describe('Mem0Block', () => {
+  const buildParams = Mem0Block.tools.config.params!
+
+  it('parses JSON string messages for add operations', () => {
+    const params = buildParams({
+      operation: 'add',
+      apiKey: 'test-key',
+      userId: 'alice',
+      messages: JSON.stringify([{ role: 'user', content: 'I like Sim.' }]),
+    })
+
+    expect(params).toEqual({
+      apiKey: 'test-key',
+      userId: 'alice',
+      messages: [{ role: 'user', content: 'I like Sim.' }],
+    })
+  })
+
+  it('rejects unsupported message roles before execution', () => {
+    expect(() =>
+      buildParams({
+        operation: 'add',
+        apiKey: 'test-key',
+        userId: 'alice',
+        messages: JSON.stringify([{ role: 'system', content: 'Remember this.' }]),
+      })
+    ).toThrow('Each message must have role user or assistant and non-empty content')
+  })
+})

apps/sim/blocks/blocks/mem0.ts

@@ -1,6 +1,46 @@
+import { toError } from '@sim/utils/errors'
 import { Mem0Icon } from '@/components/icons'
 import { AuthMode, type BlockConfig, IntegrationType } from '@/blocks/types'
-import type { Mem0Response } from '@/tools/mem0/types'
+import type { Mem0Message, Mem0Response } from '@/tools/mem0/types'
+
+function isMem0Message(value: unknown): value is Mem0Message {
+  return (
+    Boolean(value) &&
+    typeof value === 'object' &&
+    'role' in value &&
+    'content' in value &&
+    (value.role === 'user' || value.role === 'assistant') &&
+    typeof value.content === 'string' &&
+    value.content.length > 0
+  )
+}
+
+function parseMem0Messages(value: unknown): Mem0Message[] {
+  if (!value) {
+    throw new Error('Messages are required for add operation')
+  }
+
+  let messages: unknown
+  try {
+    messages = typeof value === 'string' ? JSON.parse(value) : value
+  } catch (error) {
+    throw new Error(`Messages must be valid JSON: ${toError(error).message}`)
+  }
+
+  if (!Array.isArray(messages) || messages.length === 0) {
+    throw new Error('Messages must be a non-empty array')
+  }
+
+  const validMessages: Mem0Message[] = []
+  for (const message of messages) {
+    if (!isMem0Message(message)) {
+      throw new Error('Each message must have role user or assistant and non-empty content')
+    }
+    validMessages.push(message)
+  }
+
+  return validMessages
+}
 
 export const Mem0Block: BlockConfig<Mem0Response> = {
   type: 'mem0',
@@ -32,7 +72,6 @@ export const Mem0Block: BlockConfig<Mem0Response> = {
       title: 'User ID',
       type: 'short-input',
       placeholder: 'Enter user identifier',
-      value: () => 'userid', // Default to the working user ID from curl example
       required: true,
     },
     {
@@ -77,6 +116,7 @@ export const Mem0Block: BlockConfig<Mem0Response> = {
         field: 'operation',
         value: 'get',
       },
+      mode: 'advanced',
       wandConfig: {
         enabled: true,
         prompt: `Generate a date in YYYY-MM-DD format based on the user's description.
@@ -100,6 +140,7 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
         field: 'operation',
         value: 'get',
       },
+      mode: 'advanced',
       wandConfig: {
         enabled: true,
         prompt: `Generate a date in YYYY-MM-DD format based on the user's description.
@@ -134,6 +175,7 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
         field: 'operation',
         value: ['search', 'get'],
       },
+      mode: 'advanced',
     },
   ],
   tools: {
@@ -153,16 +195,14 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
         }
       },
       params: (params: Record<string, any>) => {
-        // Create detailed error information for any missing required fields
         const errors: string[] = []
+        const operation = params.operation || 'add'
 
-        // Validate required API key for all operations
         if (!params.apiKey) {
           errors.push('API Key is required')
         }
 
-        // For search operation, validate required fields
-        if (params.operation === 'search') {
+        if (operation === 'search') {
           if (!params.query || params.query.trim() === '') {
             errors.push('Search Query is required')
           }
@@ -172,27 +212,12 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
           }
         }
 
-        // For add operation, validate required fields
-        if (params.operation === 'add') {
-          if (!params.messages) {
-            errors.push('Messages are required for add operation')
-          } else if (!Array.isArray(params.messages) || params.messages.length === 0) {
-            errors.push('Messages must be a non-empty array')
-          } else {
-            for (const msg of params.messages) {
-              if (!msg.role || !msg.content) {
-                errors.push("Each message must have 'role' and 'content' properties")
-                break
-              }
-            }
-          }
-
+        if (operation === 'add') {
           if (!params.userId) {
             errors.push('User ID is required')
           }
         }
 
-        // Throw error if any required fields are missing
         if (errors.length > 0) {
           throw new Error(`Mem0 Block Error: ${errors.join(', ')}`)
         }
@@ -201,63 +226,22 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
           apiKey: params.apiKey,
         }
 
-        // Add any identifiers that are present
         if (params.userId) result.userId = params.userId
 
-        // Add version if specified
-        if (params.version) result.version = params.version
-
         if (params.limit) result.limit = params.limit
 
-        const operation = params.operation || 'add'
-
-        // Process operation-specific parameters
         switch (operation) {
           case 'add':
-            if (params.messages) {
-              try {
-                // Ensure messages are properly formatted
-                const messagesArray =
-                  typeof params.messages === 'string'
-                    ? JSON.parse(params.messages)
-                    : params.messages
-
-                // Validate message structure
-                if (Array.isArray(messagesArray) && messagesArray.length > 0) {
-                  let validMessages = true
-                  for (const msg of messagesArray) {
-                    if (!msg.role || !msg.content) {
-                      validMessages = false
-                      break
-                    }
-                  }
-                  if (validMessages) {
-                    result.messages = messagesArray
-                  } else {
-                    // Consistent with other error handling - collect in errors array
-                    errors.push('Invalid message format - each message must have role and content')
-                    throw new Error(
-                      'Mem0 Block Error: Invalid message format - each message must have role and content'
-                    )
-                  }
-                } else {
-                  // Consistent with other error handling
-                  errors.push('Messages must be a non-empty array')
-                  throw new Error('Mem0 Block Error: Messages must be a non-empty array')
-                }
-              } catch (e: any) {
-                if (!errors.includes('Messages must be valid JSON')) {
-                  errors.push('Messages must be valid JSON')
-                }
-                throw new Error(`Mem0 Block Error: ${e.message || 'Messages must be valid JSON'}`)
-              }
+            try {
+              result.messages = parseMem0Messages(params.messages)
+            } catch (error) {
+              throw new Error(`Mem0 Block Error: ${toError(error).message}`)
             }
             break
           case 'search':
             if (params.query) {
               result.query = params.query
 
-              // Check if we have at least one identifier for search
               if (!params.userId) {
                 errors.push('Search requires a User ID')
                 throw new Error('Mem0 Block Error: Search requires a User ID')
@@ -267,7 +251,6 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
               throw new Error('Mem0 Block Error: Search requires a query parameter')
             }
 
-            // Include limit if specified
             if (params.limit) {
               result.limit = Number(params.limit)
             }
@@ -277,7 +260,6 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
               result.memoryId = params.memoryId
             }
 
-            // Add date range filtering for v2 get memories
             if (params.startDate) {
               result.startDate = params.startDate
             }
@@ -296,7 +278,6 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
     operation: { type: 'string', description: 'Operation to perform' },
     apiKey: { type: 'string', description: 'Mem0 API key' },
     userId: { type: 'string', description: 'User identifier' },
-    version: { type: 'string', description: 'API version' },
     messages: { type: 'json', description: 'Message data array' },
     query: { type: 'string', description: 'Search query' },
     memoryId: { type: 'string', description: 'Memory identifier' },
@@ -305,8 +286,14 @@ Return ONLY the date string in YYYY-MM-DD format - no explanations, no quotes, n
     limit: { type: 'number', description: 'Result limit' },
   },
   outputs: {
-    ids: { type: 'json', description: 'Memory identifiers' },
-    memories: { type: 'json', description: 'Memory data' },
-    searchResults: { type: 'json', description: 'Search results' },
+    ids: { type: 'json', description: 'Memory identifiers returned by search or get operations' },
+    memories: { type: 'json', description: 'Memory records returned by get operations' },
+    searchResults: { type: 'json', description: 'Ranked memory records returned by search' },
+    message: { type: 'string', description: 'Add operation status message' },
+    status: { type: 'string', description: 'Add operation processing status' },
+    event_id: { type: 'string', description: 'Add operation event ID for status polling' },
+    count: { type: 'number', description: 'Total memory count for get operations' },
+    next: { type: 'string', description: 'Next page URL for get operations' },
+    previous: { type: 'string', description: 'Previous page URL for get operations' },
   },
 }

apps/sim/tools/mem0/add_memories.test.ts

@@ -0,0 +1,63 @@
+/**
+ * @vitest-environment node
+ */
+import { describe, expect, it } from 'vitest'
+import { mem0AddMemoriesTool } from '@/tools/mem0/add_memories'
+import type { Mem0AddMemoriesParams } from '@/tools/mem0/types'
+
+describe('mem0AddMemoriesTool', () => {
+  const buildBody = mem0AddMemoriesTool.request.body!
+  const transformResponse = mem0AddMemoriesTool.transformResponse!
+
+  it('uses the v3 add memories endpoint', () => {
+    expect(mem0AddMemoriesTool.request.url).toBe('https://api.mem0.ai/v3/memories/add/')
+    expect(mem0AddMemoriesTool.request.method).toBe('POST')
+  })
+
+  it('builds the documented add memories request body', () => {
+    const body = buildBody({
+      apiKey: 'test-key',
+      userId: ' alice ',
+      messages: [{ role: 'user', content: 'I like Sim.' }],
+    })
+
+    expect(body).toEqual({
+      messages: [{ role: 'user', content: 'I like Sim.' }],
+      user_id: 'alice',
+    })
+  })
+
+  it('accepts JSON string messages from the block code input', () => {
+    const params: Mem0AddMemoriesParams = {
+      apiKey: 'test-key',
+      userId: 'alice',
+      messages: JSON.stringify([{ role: 'assistant', content: 'I will remember that.' }]),
+    }
+
+    expect(buildBody(params)).toEqual({
+      messages: [{ role: 'assistant', content: 'I will remember that.' }],
+      user_id: 'alice',
+    })
+  })
+
+  it('extracts queued processing fields from v3 responses', async () => {
+    const result = await transformResponse(
+      new Response(
+        JSON.stringify({
+          message: 'Memory processing has been queued for background execution',
+          status: 'PENDING',
+          event_id: 'evt-123',
+        })
+      )
+    )
+
+    expect(result).toEqual({
+      success: true,
+      output: {
+        message: 'Memory processing has been queued for background execution',
+        status: 'PENDING',
+        event_id: 'evt-123',
+      },
+    })
+  })
+})