expose pointer field publicly to avoid the property

Author: popcron

core/MemoryAddress.cs

@@ -18,17 +18,15 @@ public unsafe struct MemoryAddress : IDisposable, IEquatable<MemoryAddress>
         /// </summary>
         public static readonly int size = IntPtr.Size;
 
-        private byte* pointer;
-
         /// <summary>
-        /// Native address of this memory.
+        /// Native pointer to the memory.
         /// </summary>
-        public readonly nint Address => (nint)pointer;
+        public byte* pointer;
 
         /// <summary>
-        /// Native pointer of this memory.
+        /// Native address of this memory.
         /// </summary>
-        public readonly byte* Pointer => pointer;
+        public readonly nint Address => (nint)pointer;
 
         /// <summary>
         /// Gets or sets a byte at the given index.
@@ -40,7 +38,7 @@ public readonly ref byte this[int index]
                 ThrowIfDefault(pointer);
                 MemoryTracker.ThrowIfOutOfBounds(pointer, index);
 
-                return ref pointer[index];
+                return ref pointer[(uint)index];
             }
         }
 

core/Objects/ByteReader.cs

@@ -82,7 +82,7 @@ public ByteReader(Stream stream, int bytePosition = 0)
         {
             int byteLength = (int)stream.Length;
             MemoryAddress streamData = MemoryAddress.Allocate(byteLength);
-            Span<byte> span = new(streamData.Pointer, byteLength);
+            Span<byte> span = new(streamData.pointer, byteLength);
             byteLength = stream.Read(span);
             reader = MemoryAddress.AllocatePointer<ByteReaderPointer>();
             reader->isOriginal = true;
@@ -155,7 +155,7 @@ public readonly Span<byte> GetBytes()
         {
             MemoryAddress.ThrowIfDefault(reader);
 
-            return new(reader->data.Pointer, reader->byteLength);
+            return new(reader->data.pointer, reader->byteLength);
         }
 
         /// <summary>
@@ -182,7 +182,7 @@ public readonly Span<byte> GetRemainingBytes()
         {
             MemoryAddress.ThrowIfDefault(reader);
 
-            return new(reader->data.Pointer + reader->bytePosition, reader->byteLength - reader->bytePosition);
+            return new(reader->data.pointer + reader->bytePosition, reader->byteLength - reader->bytePosition);
         }
 
         [Conditional("DEBUG")]
@@ -315,7 +315,7 @@ public readonly Span<T> PeekSpan<T>(int bytePosition, int length) where T : unma
             int byteLength = sizeof(T) * length;
             ThrowIfReadingPastLength(bytePosition + byteLength);
 
-            void* pointer = reader->data.Pointer + bytePosition;
+            void* pointer = reader->data.pointer + bytePosition;
             return new(pointer, length);
         }
 

core/Objects/ByteWriter.cs

@@ -433,7 +433,7 @@ public readonly Span<byte> AsSpan()
         {
             MemoryAddress.ThrowIfDefault(writer);
 
-            return new(writer->data.Pointer, writer->bytePosition);
+            return new(writer->data.pointer, writer->bytePosition);
         }
 
         /// <inheritdoc/>

core/Objects/Text.cs

@@ -108,7 +108,7 @@ public Text(int length, char defaultCharacter = ' ')
             text = MemoryAddress.AllocatePointer<TextPointer>();
             text->length = length;
             text->buffer = MemoryAddress.Allocate(length * sizeof(char));
-            new Span<char>(text->buffer.Pointer, length).Fill(defaultCharacter);
+            new Span<char>(text->buffer.pointer, length).Fill(defaultCharacter);
         }
 
         /// <summary>
@@ -192,7 +192,7 @@ public readonly Span<char> AsSpan()
         {
             MemoryAddress.ThrowIfDefault(text);
 
-            return new Span<char>(text->buffer.Pointer, text->length);
+            return new Span<char>(text->buffer.pointer, text->length);
         }
 
         /// <summary>
@@ -212,7 +212,7 @@ public readonly void CopyTo(Span<char> destination)
         {
             MemoryAddress.ThrowIfDefault(text);
 
-            new Span<char>(text->buffer.Pointer, text->length).CopyTo(destination);
+            new Span<char>(text->buffer.pointer, text->length).CopyTo(destination);
         }
 
         /// <summary>
@@ -228,7 +228,7 @@ public readonly void CopyFrom(ReadOnlySpan<char> source)
                 MemoryAddress.Resize(ref text->buffer, source.Length * sizeof(char));
             }
 
-            source.CopyTo(new Span<char>(text->buffer.Pointer, source.Length));
+            source.CopyTo(new Span<char>(text->buffer.pointer, source.Length));
         }
 
         /// <summary>
@@ -244,7 +244,7 @@ public readonly void CopyFrom(string source)
                 MemoryAddress.Resize(ref text->buffer, source.Length * sizeof(char));
             }
 
-            source.AsSpan().CopyTo(new Span<char>(text->buffer.Pointer, source.Length));
+            source.AsSpan().CopyTo(new Span<char>(text->buffer.pointer, source.Length));
         }
 
         /// <summary>
@@ -260,7 +260,7 @@ public readonly void CopyFrom(ASCIIText256 source)
                 MemoryAddress.Resize(ref text->buffer, source.Length * sizeof(char));
             }
 
-            source.CopyTo(new Span<char>(text->buffer.Pointer, source.Length));
+            source.CopyTo(new Span<char>(text->buffer.pointer, source.Length));
         }
 
         /// <summary>
@@ -340,7 +340,7 @@ public readonly Span<char> Slice(int start)
         {
             MemoryAddress.ThrowIfDefault(text);
 
-            return new Span<char>(text->buffer.Pointer + start * sizeof(char), text->length - start);
+            return new Span<char>(text->buffer.pointer + start * sizeof(char), text->length - start);
         }
 
         /// <summary>
@@ -350,7 +350,7 @@ public readonly Span<char> Slice(int start, int length)
         {
             MemoryAddress.ThrowIfDefault(text);
 
-            return new Span<char>(text->buffer.Pointer + start * sizeof(char), length);
+            return new Span<char>(text->buffer.pointer + start * sizeof(char), length);
         }
 
         /// <summary>
@@ -898,7 +898,7 @@ public readonly long GetLongHashCode()
             unchecked
             {
                 long hash = 3074457345618258791;
-                Span<char> text = new(this.text->buffer.Pointer, this.text->length);
+                Span<char> text = new(this.text->buffer.pointer, this.text->length);
                 for (int i = 0; i < text.Length; i++)
                 {
                     hash += text[i];