[sim_controllers] Switch return type of sim_controller_t::set_data<T>(...).

renanthera · renanthera · commit 24764eaed90c · 2025-10-21T05:16:11.000-06:00
diff --git a/engine/sim/sim.hpp b/engine/sim/sim.hpp
@@ -107,7 +107,7 @@ struct sim_controller_t
   template <typename T>
   data_wrapper_t<T> get_data();
   template <typename T>
-  bool set_data( T&& data );
+  void set_data( T&& data );
 };
 
 struct sim_progress_t
@@ -942,10 +942,9 @@ data_wrapper_t<T> sim_controller_t::get_data()
 }
 
 template <typename T>
-bool sim_controller_t::set_data( T&& data )
+void sim_controller_t::set_data( T&& data )
 {
   auto& scd = parent->sim_controller_data;
   assert( scd.find( name() ) != scd.end() );
   scd[ name() ].data = std::make_shared<T>( data );
-  return true; // TODO: this RV is stupid
 }

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ struct sim_controller_t`
`107`	`107`	`template <typename T>`
`108`	`108`	`data_wrapper_t<T> get_data();`
`109`	`109`	`template <typename T>`
`110`		`- bool set_data( T&& data );`
	`110`	`+ void set_data( T&& data );`
`111`	`111`	`};`
`112`	`112`
`113`	`113`	`struct sim_progress_t`
`@@ -942,10 +942,9 @@ data_wrapper_t<T> sim_controller_t::get_data()`
`942`	`942`	`}`
`943`	`943`
`944`	`944`	`template <typename T>`
`945`		`-bool sim_controller_t::set_data( T&& data )`
	`945`	`+void sim_controller_t::set_data( T&& data )`
`946`	`946`	`{`
`947`	`947`	`auto& scd = parent->sim_controller_data;`
`948`	`948`	`assert( scd.find( name() ) != scd.end() );`
`949`	`949`	`scd[ name() ].data = std::make_shared<T>( data );`
`950`		`- return true; // TODO: this RV is stupid`
`951`	`950`	`}`