A couple of bug fixes including threading issues

Author: kzscisoft

simvue/api/objects/metrics.py

@@ -34,9 +34,9 @@ class Metrics(SimvueObject):
 
     _label: str = "metric"
 
-    @override
     def __init__(
         self,
+        identifier: str | None = None,
         *,
         server_url: str | None = None,
         server_token: pydantic.SecretStr | None = None,
@@ -56,7 +56,10 @@ def __init__(
             any additional arguments to be passed to the object initialiser
         """
         super().__init__(
-            identifier=None, server_url=server_url, server_token=server_token, **kwargs
+            identifier=identifier,
+            server_url=server_url,
+            server_token=server_token,
+            **kwargs,
         )
         self._run_id = self._staging.get("run")
         self._is_set = True

simvue/client.py

@@ -675,18 +675,19 @@ def get_artifacts_as_files(
         with ThreadPoolExecutor(
             CONCURRENT_DOWNLOADS, thread_name_prefix=f"get_artifacts_run_{run_id}"
         ) as executor:
-            futures = [
-                executor.submit(_download_artifact_to_file, artifact, output_dir)
+            future_artifact_mapping = {
+                executor.submit(
+                    _download_artifact_to_file, artifact, output_dir
+                ): artifact
                 for _, artifact in _artifacts
-            ]
-            for future, (_, artifact) in zip(
-                as_completed(futures), _artifacts, strict=True
-            ):
+            }
+            for future in as_completed(future_artifact_mapping):
+                _artifact = future_artifact_mapping[future]
                 try:
                     future.result()
                 except Exception as e:
                     raise RuntimeError(
-                        f"Download of file {artifact.storage_url} "
+                        f"Download of file {_artifact.storage_url} "
                         f"failed with exception: {e}"
                     ) from e