cleanup: batch review updates for pr thesofproject#10583

Apply changes from review.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Liam Girdwood <lgirdwood@gmail.com>

Author: lgirdwood

app/src/main.c

@@ -59,16 +59,17 @@ static int sof_app_main(void)
 
 #if CONFIG_SOF_BOOT_TEST && defined(QEMU_BOOT_TESTS)
 /* cleanly exit qemu so CI can continue and check test results */
-static inline void qemu_xtensa_exit(int status) {
-    register int syscall_id __asm__ ("a2") = 1;      /* SYS_exit is 1 */
-    register int exit_status __asm__ ("a3") = status;
+static inline void qemu_xtensa_exit(int status)
+{
+	register int syscall_id __asm__ ("a2") = 1;      /* SYS_exit is 1 */
+	register int exit_status __asm__ ("a3") = status;
 
-    __asm__ __volatile__ (
-        "simcall\n"
-        :
-        : "r" (syscall_id), "r" (exit_status)
-        : "memory"
-    );
+	__asm__ __volatile__ (
+		"simcall\n"
+		:
+		: "r" (syscall_id), "r" (exit_status)
+		: "memory"
+	);
 }
 #endif
 

scripts/sof-crash-decode.py

@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2024 Intel Corporation. All rights reserved.
+# Copyright(c) 2026 Intel Corporation. All rights reserved.
 """
 decode_crash.py - Zephyr Xtensa Crash Dump Decoder
 
@@ -14,16 +14,16 @@
 
 Usage Examples:
     # 1. Provide the ELF and read crash from stdin
-    cat crash.txt | ./decode_crash.py --elf zephyr.elf
+    cat crash.txt | ./sof-crash-decode.py --elf zephyr.elf
 
     # 2. Automatically locate ELF/objdump from a Zephyr build directory, read crash from file
-    ./decode_crash.py --build-dir build-qemu_xtensa/ --dump crash.txt
+    ./sof-crash-decode.py --build-dir build-qemu_xtensa/ --dump crash.txt
 
     # 3. Read directly from the system clipboard
-    ./decode_crash.py --build-dir build-qemu_xtensa/ --clipboard
+    ./sof-crash-decode.py --build-dir build-qemu_xtensa/ --clipboard
 
     # 4. Pipe a live trace to the decoder
-    tail -f log.txt | ./decode_crash.py --build-dir build_dir/
+    tail -f log.txt | ./sof-crash-decode.py --build-dir build_dir/
 
 """
 

scripts/sof-qemu-run.py

@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 # SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2024 Intel Corporation. All rights reserved.
+# Copyright(c) 2026 Intel Corporation. All rights reserved.
 """
 sof-qemu-run.py - Automated QEMU test runner and crash analyzer
 
@@ -16,7 +16,7 @@
 import subprocess
 import argparse
 import os
-import sys
+
 import re
 
 # ANSI Color Codes
@@ -95,7 +95,6 @@ def main():
 
     # We will accumulate output to check for crashes
     full_output = ""
-    last_output = ""
 
     with open(args.log_file, "w") as log_file:
         try:

scripts/sof-qemu-run.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 # SPDX-License-Identifier: BSD-3-Clause
-# Copyright(c) 2024 Intel Corporation. All rights reserved.
+# Copyright(c) 2026 Intel Corporation. All rights reserved.
 
 # Define the build directory from the first argument (or default)
 BUILD_DIR="${1:-build}"
@@ -13,15 +13,9 @@ BUILD_DIR="${1:-build}"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 SOF_WORKSPACE="$(dirname "$(dirname "$SCRIPT_DIR")")"
 
-# check if Zephyr environment is set up
-if [ ! -z "$SOF_WORKSPACE" ]; then
-    VENV_DIR="$SOF_WORKSPACE/.venv"
-    echo "Using SOF environment at $SOF_WORKSPACE"
-else
-    # default to the local workspace
-    VENV_DIR="${SOF_WORKSPACE}/.venv"
-    echo "Using default SOF environment at $VENV_DIR"
-fi
+# Use the SOF workspace to locate the virtual environment
+VENV_DIR="$SOF_WORKSPACE/.venv"
+echo "Using SOF environment at $SOF_WORKSPACE"
 
 # start the virtual environment
 source ${VENV_DIR}/bin/activate