Skip to content

Look into dependency management code #4

@alikindsys

Description

@alikindsys

That code looks convoluted with probably un-needed recursion and a loop that only executes one value.

if (!innerDep.Any()) return SisbaseResult.FromSucess();
return await CheckDependencies(sys, newStack);

It also doesn't check for the intersection of already unloaded systems, although I don't believe thats much of an issue, since its likely pre-emptive optimization.

Anyways, I do believe a cleaner solution can be made.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions