Skip to content

Commit fd3c8b0

Browse files
committed
quote aliases in select list
1 parent 28f53f4 commit fd3c8b0

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/Data/ObjectDriver/SQL.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ sub as_sql {
6565
$sql .= 'DISTINCT ' if $stmt->distinct;
6666
$sql .= join(', ', map {
6767
my $alias = $stmt->select_map->{$_};
68-
$alias && /(?:^|\.)\Q$alias\E$/ ? $_ : "$_ $alias";
68+
$alias && /(?:^|\.)\Q$alias\E$/ ? $_ : qq!$_ "$alias"!;
6969
} @{ $stmt->select }) . "\n";
7070
}
7171
$sql .= 'FROM ';

t/11-sql.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ $stmt = ns();
288288
$stmt->add_select('f.foo' => 'foo');
289289
$stmt->add_select('COUNT(*)' => 'count');
290290
$stmt->from([ qw( baz ) ]);
291-
is($stmt->as_sql, "SELECT f.foo, COUNT(*) count\nFROM baz\n");
291+
is($stmt->as_sql, qq!SELECT f.foo, COUNT(*) "count"\nFROM baz\n!);
292292
my $map = $stmt->select_map;
293293
is(scalar(keys %$map), 2);
294294
is($map->{'f.foo'}, 'foo');
@@ -306,7 +306,7 @@ $stmt->limit(2);
306306
$stmt->add_having(count => 2);
307307

308308
is($stmt->as_sql, <<SQL);
309-
SELECT foo, COUNT(*) count
309+
SELECT foo, COUNT(*) "count"
310310
FROM baz
311311
WHERE (foo = ?)
312312
GROUP BY baz

0 commit comments

Comments
 (0)