feat(style): add style.Separator for non ASCII em-dash (#430)

Co-authored-by: Michael Brooks <mbrooks@slack-corp.com>

Author: srtaalej

internal/iostreams/forms.go

@@ -92,7 +92,7 @@ func buildSelectForm(io *IOStreams, msg string, options []string, cfg SelectProm
 		key := opt
 		if cfg.Description != nil {
 			if desc := style.RemoveEmoji(cfg.Description(opt, len(opts))); desc != "" {
-				key = style.Bright(opt) + " — " + style.Secondary(desc)
+				key = style.Bright(opt) + style.Separator() + style.Secondary(desc)
 			}
 		}
 		opts = append(opts, huh.NewOption(key, opt))

internal/iostreams/forms_test.go

@@ -195,7 +195,7 @@ func TestSelectForm(t *testing.T) {
 		assert.Contains(t, view, "First letter")
 	})
 
-	t.Run("descriptions use em-dash separator with lipgloss enabled", func(t *testing.T) {
+	t.Run("descriptions use hyphen separator with lipgloss enabled", func(t *testing.T) {
 		style.ToggleLipgloss(true)
 		style.ToggleStyles(true)
 		t.Cleanup(func() {
@@ -225,10 +225,10 @@ func TestSelectForm(t *testing.T) {
 		f.Update(f.Init())
 
 		view := ansi.Strip(f.View())
-		assert.Contains(t, view, " — First letter")
+		assert.Contains(t, view, " - First letter")
 	})
 
-	t.Run("descriptions use em-dash separator without lipgloss", func(t *testing.T) {
+	t.Run("descriptions use hyphen separator without lipgloss", func(t *testing.T) {
 		var selected string
 		options := []string{"Alpha", "Beta"}
 		selectCfg := SelectPromptConfig{
@@ -243,7 +243,7 @@ func TestSelectForm(t *testing.T) {
 		f.Update(f.Init())
 
 		view := ansi.Strip(f.View())
-		assert.Contains(t, view, "Alpha — First letter")
+		assert.Contains(t, view, "Alpha - First letter")
 	})
 
 	t.Run("page size sets field height", func(t *testing.T) {

internal/style/style.go

@@ -273,6 +273,10 @@ func Underline(text string) string {
 	return render(lipgloss.NewStyle().Underline(true), text)
 }
 
+func Separator() string {
+	return " - "
+}
+
 /*
 Lexical
 */

internal/style/style_test.go

@@ -58,6 +58,10 @@ func TestRemoveANSI(t *testing.T) {
 	}
 }
 
+func TestSeparator(t *testing.T) {
+	assert.Equal(t, " - ", Separator())
+}
+
 func TestRemoveEmoji(t *testing.T) {
 	tests := map[string]struct {
 		input    string