Skip to content

Commit fc9808c

Browse files
committed
Improve error reporting in github actions
1 parent 0953d6c commit fc9808c

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

Fun.Build/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## [Unreleased]
44

5+
## [1.1.11] - 2024-10-21
6+
7+
- Improve error reporting in github actions
8+
59
## [1.1.10] - 2024-10-21
610

711
- Improve error reporting in github actions

Fun.Build/PipelineContextExtensions.fs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ module PipelineContextExtensionsInternal =
5959
}
6060

6161

62-
member this.GetErrorPrefix() = if this.EnvVars.ContainsKey("GITHUB_ENV") then "::error" else "Error:"
62+
member this.GetErrorPrefix() = if this.EnvVars.ContainsKey("GITHUB_ENV") then "::error::" else "Error: "
6363

6464

6565
member this.RunStages(stages: StageContext seq, cancelToken: Threading.CancellationToken, ?failfast: bool) =
@@ -158,7 +158,7 @@ module PipelineContextExtensionsInternal =
158158
if pipelineExns.Count > 0 then
159159
for exn in pipelineExns do
160160
let innerMessage = if exn.InnerException <> null then exn.InnerException.Message else ""
161-
AnsiConsole.MarkupLineInterpolated $"[red]{this.GetErrorPrefix()} {exn.Message} {innerMessage}[/]"
161+
AnsiConsole.MarkupLineInterpolated $"[red]{this.GetErrorPrefix()}{exn.Message} {innerMessage}[/]"
162162
AnsiConsole.WriteLine()
163163
raise (PipelineFailedException("Pipeline is failed because of exception", pipelineExns[0]))
164164
else if hasError then

Fun.Build/StageContextExtensions.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ module StageContextExtensionsInternal =
6464

6565
member ctx.GetErrorPrefix() =
6666
match ctx.TryGetEnvVar("GITHUB_ENV") with
67-
| ValueSome _ -> "::error"
68-
| _ -> "Error:"
67+
| ValueSome _ -> "::error::"
68+
| _ -> "Error: "
6969

7070

7171
member ctx.GetNoPrefixForStep() =
@@ -253,9 +253,9 @@ module StageContextExtensionsInternal =
253253
| Error e ->
254254
if String.IsNullOrEmpty e |> not then
255255
if not isParallel && stage.GetNoPrefixForStep() then
256-
AnsiConsole.MarkupLineInterpolated $"""[red]{stage.GetErrorPrefix()} {e}[/]"""
256+
AnsiConsole.MarkupLineInterpolated $"""[red]{stage.GetErrorPrefix()}{e}[/]"""
257257
else
258-
AnsiConsole.MarkupLineInterpolated $"""[red]{stage.GetErrorPrefix()} {prefix} {e}[/]"""
258+
AnsiConsole.MarkupLineInterpolated $"""[red]{stage.GetErrorPrefix()}{prefix} {e}[/]"""
259259
return false
260260
| Ok _ -> return true
261261
}

0 commit comments

Comments
 (0)