Fix invisible effect for outfits

Author: slavidodo

OpenTibia/Assets/Scripts/Core/Appearances/AppearanceStorage.cs

@@ -133,16 +133,17 @@ public MissileInstance CreateMissileInstance(uint id, UnityEngine.Vector3Int fro
             return null;
         }
 
+        public EffectInstance CreateInvisibleEffect() {
+            return new EffectInstance(_invisibleOutfitType.Id, _invisibleOutfitType);
+        }
+
         public OutfitInstance CreateOutfitInstance(uint id, int head, int body, int legs, int feet, int addons) {
             if (_outfitTypes == null)
                 throw new System.Exception("AppearanceStorage.CreateOutfitInstance: proto appearances not loaded.");
 
-            if (id == OutfitInstance.InvisibleOutfitId) {
-                return new OutfitInstance(id, _invisibleOutfitType, head, body, legs, feet, addons);
-            } else if (id >= _minimumOutfitId && id <= _maximumOutfitId) {
+            if (id >= _minimumOutfitId && id <= _maximumOutfitId) {
                 return new OutfitInstance(id, FindAppearanceType(_outfitTypes, id), head, body, legs, feet, addons);
             }
-                
             return null;
         }
 

OpenTibia/Assets/Scripts/Core/Communication/Game/Utility.cs

@@ -38,8 +38,11 @@ private AppearanceInstance ReadCreatureOutfit(Internal.CommunicationStream messa
             if (!!objectInstance && objectInstance.Id == objectId)
                 return objectInstance;
 
-            if (objectId == 0)
-                return AppearanceStorage.CreateOutfitInstance(OutfitInstance.InvisibleOutfitId, 0, 0, 0, 0, 0);
+            if (objectId == OutfitInstance.InvisibleOutfitId) {
+                var effect = AppearanceStorage.CreateInvisibleEffect();
+                effect.SetEndless();
+                return effect;
+            }
 
             return AppearanceStorage.CreateObjectInstance(objectId, 0);
         }