Merge pull request #21 from smartboxgroup/feature/sf-3

Allow Symfony 3.X applications

Author: andreymor

.travis.yml

@@ -1,32 +1,58 @@
+# See: https://symfony.com/doc/current/bundles/best_practices.html#continuous-integration
 language: php
+sudo: false
+cache:
+  directories:
+    - $HOME/.composer/cache/files
+    - $HOME/symfony-bridge/.phpunit
 
-php:
-  - 7.0
-  - 7.1
-  - 7.2
-  - 7.3
+env:
+  global:
+    - PHPUNIT_FLAGS="-v"
+    - SYMFONY_PHPUNIT_DIR="$HOME/symfony-bridge/.phpunit"
 
 matrix:
-  allow_failures:
-    - php: 7.3
+  fast_finish: true
+  include:
+      # Test the latest stable release
+    - php: 7.0
+    - php: 7.1
+    - php: 7.2
+      env: COVERAGE=true PHPUNIT_FLAGS="-v --coverage-text"
+
+      # Test LTS versions. This makes sure we do not use Symfony packages with version greater
+      # than 2 or 3 respectively. Read more at https://github.com/symfony/lts
+    - php: 7.2
+      env: DEPENDENCIES="symfony/lts:^3"
+
+      # Latest commit to master
+    - php: 7.2
+      env: STABILITY="dev"
 
-env:
-  - SYMFONY_VERSION=2.8.*
-  - SYMFONY_VERSION=3.4.*
+  allow_failures:
+    # Dev-master is allowed to fail.
+    - env: STABILITY="dev"
 
 before_install:
-  - phpenv config-add travis/z_php.ini
+  - if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi
+  - if ! [ -z "$STABILITY" ]; then composer config minimum-stability ${STABILITY}; fi;
+  - if ! [ -v "$DEPENDENCIES" ]; then composer require --no-update ${DEPENDENCIES}; fi;
 
-before_script:
-  - composer install --prefer-dist --no-interaction
+install:
+  # To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355
+  - if [[ "$COMPOSER_FLAGS" == *"--prefer-lowest"* ]]; then composer update --prefer-dist --no-interaction --prefer-stable --quiet; fi
+  - composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction
+  - ./vendor/bin/simple-phpunit install
 
 script:
-  - SYMFONY_PHPUNIT_VERSION=6.5 SYMFONY_DEPRECATIONS_HELPER=weak_vendors bin/simple-phpunit --coverage-text
+  - composer validate --strict --no-check-lock
+  # simple-phpunit is the PHPUnit wrapper provided by the PHPUnit Bridge component and
+  # it helps with testing legacy code and deprecations (composer require symfony/phpunit-bridge)
+  - SYMFONY_DEPRECATIONS_HELPER="weak_vendors" ./vendor/bin/simple-phpunit $PHPUNIT_FLAGS
 
 notifications:
   email:
     recipients:
       - si-integration@smartandco.com
     on_success: change
     on_failure: always
-

DependencyInjection/SerializationCacheCompilerPass.php

@@ -51,24 +51,21 @@ public function process(ContainerBuilder $container)
                     throw new \Exception("The class '$class' configured in smartbox_core.serialization_cache.cached_visitors does not have the data property and can not be cached.");
                 }
             }
+            $public = $container->getParameter('kernel.debug');
 
             // Serialization cache subscriber
-            $serializationCacheSubscriber = $container->setDefinition(
-                'smartcore.serializer.subscriber.cache',
-                new Definition(CacheEventsSubscriber::class, [
-                    $vistorClasses,
-                ])
-            );
+            $serializationCacheSubscriber = $container->register('smartcore.serializer.subscriber.cache', CacheEventsSubscriber::class);
+            $serializationCacheSubscriber->setArguments([$vistorClasses]);
             $serializationCacheSubscriber->addMethodCall('setCacheService', [$cacheDriverServiceDef]);
             $serializationCacheSubscriber->addTag('jms_serializer.event_subscriber');
+            $serializationCacheSubscriber->setPublic($public);
+
 
             // Serialization cache handler
-            $serializationCacheHandler = $container->setDefinition(
-                'smartcore.serializer.handler.cache',
-                new Definition(CachedObjectHandler::class)
-            );
+            $serializationCacheHandler = $container->register('smartcore.serializer.handler.cache',CachedObjectHandler::class);
             $serializationCacheHandler->addMethodCall('setCacheService', [$cacheDriverServiceDef]);
             $serializationCacheHandler->addTag('jms_serializer.subscribing_handler');
+            $serializationCacheHandler->setPublic($public);
         }
     }
 }

Resources/config/services.yml

@@ -103,6 +103,7 @@ services:
     smartcore.generator.random_fixture:
         class: '%smartcore.generator.random_fixture.class%'
         arguments: ['@jms_serializer.metadata_factory', '@smartcore.helper.entity_namespace_resolver']
+        public: '%kernel.debug%'
 
     ## SMOKE TESTS ##
     # COMMAND

Tests/Command/Fixtures/GenerateRandomFixtureCommandTest.php

@@ -13,7 +13,7 @@
 use Symfony\Component\DependencyInjection\ContainerInterface;
 
 /**
- * Class GenerateRandomFixtureCommandTest.
+ * @group legacy
  *
  * @coversDefaultClass \Smartbox\CoreBundle\Command\Fixtures\GenerateRandomFixtureCommand
  */
@@ -62,8 +62,6 @@ public function dataProviderForEntityGeneration()
      */
     public function testExecute($group, $version)
     {
-        $this->application->add($this->container->get('smartbox_core.command_fixtures.generate_random_fixture_command'));
-
         $command = $this->application->find('smartbox:core:generate:random-fixture');
         $commandTester = new CommandTester($command);