Skip to content

Expose graceful stop timeout #3

@macournoyer

Description

@macournoyer

A timeout is used here: https://github.com/socketry/async-container/blob/6805b6b0469aa2b4e81256f324445c767407220e/lib/async/container/group.rb#L124-L145. But, it is not configurable anywhere.

This means gracefully stopping a server will wait only 1 second before killing workers.

Also, I think the default of 1 second should be bumped. Perhaps 10 seconds?

For reference, by default:

  • Unicorn will wait 60 seconds before sending SIGKILL
  • Puma will wait forever

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions