Skip to content

Commit aa10f0a

Browse files
antoinelochetkalvdans
authored andcommitted
Fixed compilation when ML-DSA is not supported
mldsaAlgNameFromParameterSet is a constant Co-authored-by: kalvdans <github@kalvdans.no-ip.org>
1 parent 2885d93 commit aa10f0a

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/lib/SoftHSM.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6352,6 +6352,7 @@ CK_RV SoftHSM::C_GenerateKeyPair
63526352
ispublicKeyToken, ispublicKeyPrivate, isprivateKeyToken, isprivateKeyPrivate);
63536353
}
63546354

6355+
#ifdef WITH_ML_DSA
63556356
if (pMechanism->mechanism == CKM_ML_DSA_KEY_PAIR_GEN)
63566357
{
63576358
return this->generateMLDSA(hSession,
@@ -6360,7 +6361,7 @@ CK_RV SoftHSM::C_GenerateKeyPair
63606361
phPublicKey, phPrivateKey,
63616362
ispublicKeyToken, ispublicKeyPrivate, isprivateKeyToken, isprivateKeyPrivate);
63626363
}
6363-
6364+
#endif
63646365
return CKR_GENERAL_ERROR;
63656366
}
63666367

@@ -10070,6 +10071,7 @@ CK_RV SoftHSM::generateED
1007010071
return rv;
1007110072
}
1007210073

10074+
#ifdef WITH_ML_DSA
1007310075
// Generate an MLDSA key pair
1007410076
CK_RV SoftHSM::generateMLDSA
1007510077
(CK_SESSION_HANDLE hSession,
@@ -10328,6 +10330,7 @@ CK_RV SoftHSM::generateMLDSA
1032810330

1032910331
return rv;
1033010332
}
10333+
#endif
1033110334

1033210335
// Generate a DH key pair
1033310336
CK_RV SoftHSM::generateDH

src/lib/crypto/OSSLUtil.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
#include <openssl/err.h>
4242

4343
#ifdef WITH_ML_DSA
44-
static std::map<unsigned long, const char*> mldsaAlgNameFromParameterSet {
44+
static const std::map<unsigned long, const char*> mldsaAlgNameFromParameterSet {
4545
{MLDSAParameters::ML_DSA_44_PARAMETER_SET, "ML-DSA-44"},
4646
{MLDSAParameters::ML_DSA_65_PARAMETER_SET, "ML-DSA-65"},
4747
{MLDSAParameters::ML_DSA_87_PARAMETER_SET, "ML-DSA-87"}
@@ -223,7 +223,7 @@ int OSSL::byteString2oid(const ByteString& byteString)
223223
#ifdef WITH_ML_DSA
224224
const char* OSSL::mldsaParameterSet2Name(unsigned long parameterSet) {
225225

226-
std::map<unsigned long, const char*>::iterator it = mldsaAlgNameFromParameterSet.find(parameterSet);
226+
std::map<unsigned long, const char*>::const_iterator it = mldsaAlgNameFromParameterSet.find(parameterSet);
227227

228228
if (it != mldsaAlgNameFromParameterSet.end()) {
229229
return it->second;

0 commit comments

Comments
 (0)