Skip to content

Commit 20e674a

Browse files
committed
Fix object mask usage in Ticket and ImageTemplate
1 parent 04a627e commit 20e674a

2 files changed

Lines changed: 6 additions & 11 deletions

File tree

lib/softlayer/ImageTemplate.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -334,11 +334,8 @@ def self.template_with_id(id, options_hash = {})
334334
raise "#{__method__} requires a client but none was given and Client::default_client is not set" if !softlayer_client
335335

336336
service = softlayer_client[:Virtual_Guest_Block_Device_Template_Group].object_with_id(id)
337-
service.object_mask(default_object_mask)
338-
339-
if options_hash.has_key? :object_mask
340-
service = service.object_mask(options_hash[:object_mask])
341-
end
337+
service = service.object_mask(default_object_mask)
338+
service = service.object_mask(options_hash[:object_mask]) if options_hash[:object_mask]
342339

343340
template_data = service.getObject
344341
ImageTemplate.new(softlayer_client, template_data)

lib/softlayer/Ticket.rb

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,11 @@ def self.ticket_with_id(ticket_id, options = {})
127127
softlayer_client = options[:client] || Client.default_client
128128
raise "#{__method__} requires a client but none was given and Client::default_client is not set" if !softlayer_client
129129

130-
if options.has_key?(:object_mask)
131-
object_mask = options[:object_mask]
132-
else
133-
object_mask = default_object_mask.to_sl_object_mask
134-
end
130+
ticket_service = softlayer_client[:Ticket].object_with_id(ticket_id)
131+
ticket_service = ticket_service.object_mask(default_object_mask.to_sl_object_mask)
132+
ticket_service = ticket_service.object_mask(options[:object_mask]) if options[:object_mask]
135133

136-
ticket_data = softlayer_client[:Ticket].object_with_id(ticket_id).object_mask(object_mask).getObject()
134+
ticket_data = ticket_service.getObject()
137135

138136
return Ticket.new(softlayer_client, ticket_data)
139137
end

0 commit comments

Comments
 (0)