Fix image template issues found while looking into #128

Author: Renier Morales

CHANGELOG.textile

@@ -1,5 +1,9 @@
+*3.2.2*
+* Fix NoMethodError when getting the datacenters out of an ImageTemplate and the value was nil.
+* Fix NoMethodError when getting public and private images with a result limit of 1.
+
 *3.2.1*
-Fix a crashing issue where a Bare Metal server order tried to retrieve the hardware ordered before it has been provisioned.
+* Fix a crashing issue where a Bare Metal server order tried to retrieve the hardware ordered before it has been provisioned.
 
 *3.2*
 * Add password-based authentication with `SoftLayer::Client.with_password(username: '...', password: '...', ...)`.

lib/softlayer/ImageTemplate.rb

@@ -78,7 +78,9 @@ def tags=(tags_array)
     ##
     # Returns the an array containing the datacenters where this image is available.
     def datacenters
-      self['datacenters'].collect{ |datacenter_data| SoftLayer::Datacenter.datacenter_named(datacenter_data['name'])}
+      Array(self['datacenters']).collect do |datacenter_data|
+        SoftLayer::Datacenter.datacenter_named(datacenter_data['name'])
+      end
     end
 
     ##
@@ -253,7 +255,7 @@ def self.find_private_templates(options_hash = {})
         account_service = account_service.result_limit(options_hash[:result_limit][:offset], options_hash[:result_limit][:limit])
       end
 
-      templates_data = account_service.getPrivateBlockDeviceTemplateGroups
+      templates_data = Array(account_service.getPrivateBlockDeviceTemplateGroups)
       templates_data.collect { |template_data| ImageTemplate.new(softlayer_client, template_data) }
     end
 
@@ -312,7 +314,9 @@ def self.find_public_templates(options_hash = {})
         template_service = template_service.result_limit(options_hash[:result_limit][:offset], options_hash[:result_limit][:limit])
       end
 
-      templates_data = template_service.getPublicImages
+      # Ensure this is an array with Array(). SL won't return array if the result set is of just one
+      # (like when the user specifies a limit of 1)
+      templates_data = Array(template_service.getPublicImages)
       templates_data.collect { |template_data| ImageTemplate.new(softlayer_client, template_data) }
     end
 

lib/softlayer/base.rb

@@ -12,7 +12,7 @@
 module SoftLayer
   # The version number (including major, minor, and bugfix numbers)
   # This should change in accordance with the concept of Semantic Versioning
-  VERSION = "3.2.1"  # version history in the CHANGELOG.textile file at the root of the source
+  VERSION = "3.2.2"  # version history in the CHANGELOG.textile file at the root of the source
 
   # The base URL of the SoftLayer API available to the public internet.
   API_PUBLIC_ENDPOINT = 'https://api.softlayer.com/xmlrpc/v3/'