Add _at to date/time attributes to distinguish them as datetime as opposed to boolean and cleanup fqdn naming to shorten it

ju2wheels · ju2wheels · commit 7a5259674f0d · 2015-05-01T17:41:58.000-04:00
v4-cleanup-required
diff --git a/lib/softlayer/NetworkMessageDelivery.rb b/lib/softlayer/NetworkMessageDelivery.rb
@@ -16,14 +16,28 @@ module SoftLayer
   class NetworkMessageDelivery < ModelBase
     include ::SoftLayer::DynamicAttribute
 
+    ##
+    # :attr_reader: created_at
+    # The date this username/password pair was created.
+    sl_attr :created_at,  'createDate'
+
     ##
     # :attr_reader: created
     # The date this username/password pair was created.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of created_at
+    # and will be removed in the next major release.
     sl_attr :created,  'createDate'
 
+    ##
+    # :attr_reader: modified_at
+    # The date of the last modification to this username/password pair.
+    sl_attr :modified_at, 'modifyDate'
+
     ##
     # :attr_reader: modified
     # The date of the last modification to this username/password pair.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of modified_at
+    # and will be removed in the next major release.
     sl_attr :modified, 'modifyDate'
 
     ##
diff --git a/lib/softlayer/NetworkStorage.rb b/lib/softlayer/NetworkStorage.rb
@@ -20,9 +20,16 @@ class NetworkStorage < ModelBase
     # A Storage account's capacity, measured in gigabytes.
     sl_attr :capacity,   'capacityGb'
 
+    ##
+    # :attr_reader: created_at
+    # The date a network storage volume was created.
+    sl_attr :created_at, 'createDate'
+
     ##
     # :attr_reader: created
     # The date a network storage volume was created.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of created_at
+    # and will be removed in the next major release.
     sl_attr :created,    'createDate'
 
     ##
diff --git a/lib/softlayer/NetworkStorageCredential.rb b/lib/softlayer/NetworkStorageCredential.rb
@@ -16,14 +16,28 @@ module SoftLayer
   class NetworkStorageCredential < ModelBase
     include ::SoftLayer::DynamicAttribute
 
+    ##
+    # :attr_reader: created_at
+    # This is the data that the record was created in the table.
+    sl_attr :created_at,  'createDate'
+
     ##
     # :attr_reader: created
     # This is the data that the record was created in the table.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of created_at
+    # and will be removed in the next major release.
     sl_attr :created,  'createDate'
 
+    ##
+    # :attr_reader: modified_at
+    # This is the date that the record was last updated in the table.
+    sl_attr :modified_at, 'modifyDate'
+
     ##
     # :attr_reader: modified
     # This is the date that the record was last updated in the table.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of modified_at
+    # and will be removed in the next major release.
     sl_attr :modified, 'modifyDate'
 
     ##
diff --git a/lib/softlayer/NetworkStorageGroup.rb b/lib/softlayer/NetworkStorageGroup.rb
@@ -14,14 +14,28 @@ class NetworkStorageGroup < ModelBase
     # The friendly name of this group
     sl_attr :alias
 
+    ##
+    # :attr_reader: created_at
+    # The date this group was created.
+    sl_attr :created_at, 'createDate'
+
     ##
     # :attr_reader: created
     # The date this group was created.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of created_at
+    # and will be removed in the next major release.
     sl_attr :created, 'createDate'
 
+    ##
+    # :attr_reader: modified_at
+    # The date this group was modified.
+    sl_attr :modified_at, 'modifyDate'
+
     ##
     # :attr_reader: modified
     # The date this group was modified.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of modified_at
+    # and will be removed in the next major release.
     sl_attr :modified, 'modifyDate'
 
     ##
diff --git a/lib/softlayer/Server.rb b/lib/softlayer/Server.rb
@@ -29,15 +29,15 @@ class Server  < SoftLayer::ModelBase
     sl_attr :domain
 
     ##
-    # :attr_reader: fully_qualified_domain_name
+    # :attr_reader: fqdn
     # A convenience attribute that combines the hostname and domain name
-    sl_attr :fully_qualified_domain_name, 'fullyQualifiedDomainName'
+    sl_attr :fqdn, 'fullyQualifiedDomainName'
 
     ##
     # :attr_reader:
     # A convenience attribute that combines the hostname and domain name
     #
-    # DEPRECATION WARNING: This attribute is deprecated in favor of fully_qualified_domain_name
+    # DEPRECATION WARNING: This attribute is deprecated in favor of fqdn
     # and will be removed in the next major release.
     sl_attr :fullyQualifiedDomainName
 
diff --git a/lib/softlayer/ServerFirewall.rb b/lib/softlayer/ServerFirewall.rb
@@ -15,7 +15,7 @@ module SoftLayer
   # Instances of this class roughly correspond to instances of the
   # SoftLayer_Network_Component_Firewall service entity.
   #
-	class ServerFirewall < SoftLayer::ModelBase
+  class ServerFirewall < SoftLayer::ModelBase
     include ::SoftLayer::DynamicAttribute
 
     ##
diff --git a/lib/softlayer/SoftwarePassword.rb b/lib/softlayer/SoftwarePassword.rb
@@ -14,15 +14,29 @@ module SoftLayer
   #
   class SoftwarePassword < ModelBase
     include ::SoftLayer::DynamicAttribute
+
+    ##
+    # :attr_reader: created_at
+    # The date this username/password pair was created.
+    sl_attr :created_at, 'createDate'
     
     ##
     # :attr_reader: created
     # The date this username/password pair was created.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of created_at
+    # and will be removed in the next major release.
     sl_attr :created, 'createDate'
 
+    ##
+    # :attr_reader: modified_at
+    # The date of the last modification to this username/password pair.
+    sl_attr :modified_at, 'modifyDate'
+
     ##
     # :attr_reader: modified
     # The date of the last modification to this username/password pair.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of modified_at
+    # and will be removed in the next major release.
     sl_attr :modified, 'modifyDate'
 
     ##
diff --git a/lib/softlayer/Ticket.rb b/lib/softlayer/Ticket.rb
@@ -18,15 +18,15 @@ class Ticket < SoftLayer::ModelBase
     sl_attr :subject
 
     ##
-    # :attr_reader: last_edited
+    # :attr_reader: last_edited_at
     # The date the ticket was last updated.
-    sl_attr :last_edited, 'lastEditDate'
+    sl_attr :last_edited_at, 'lastEditDate'
 
     ##
     # :attr_reader:
     # The date the ticket was last updated.
     #
-    # DEPRECATION WARNING: This attribute is deprecated in favor of last_edited
+    # DEPRECATION WARNING: This attribute is deprecated in favor of last_edited_at
     # and will be removed in the next major release.
     sl_attr :lastEditDate
 
diff --git a/lib/softlayer/UserCustomer.rb b/lib/softlayer/UserCustomer.rb
@@ -20,9 +20,16 @@ class UserCustomer < ModelBase
     # A portal user's secondary phone number.
     sl_attr :alternate_phone,  'alternatePhone'
 
+    ##
+    # :attr_reader: created_at
+    # The date a portal user's record was created.
+    sl_attr :created_at,          'createDate'
+
     ##
     # :attr_reader: created
     # The date a portal user's record was created.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of created_at
+    # and will be removed in the next major release.
     sl_attr :created,          'createDate'
 
     ##
@@ -45,9 +52,16 @@ class UserCustomer < ModelBase
     # A portal user's last name.
     sl_attr :last_name,        'lastName'
 
+    ##
+    # :attr_reader: modified_at
+    # The date a portal user's record was last modified.
+    sl_attr :modified_at,         'modifyDate'
+
     ##
     # :attr_reader: modified
     # The date a portal user's record was last modified.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of modified_at
+    # and will be removed in the next major release.
     sl_attr :modified,         'modifyDate'
 
     ##
diff --git a/lib/softlayer/UserCustomerExternalBinding.rb b/lib/softlayer/UserCustomerExternalBinding.rb
@@ -21,9 +21,16 @@ class UserCustomerExternalBinding < ModelBase
     # used for authentication or not.
     sl_attr :active
 
+    ##
+    # :attr_reader: created_at
+    # The date that the external authentication binding was created.
+    sl_attr :created_at, 'createDate'
+
     ##
     # :attr_reader: created
     # The date that the external authentication binding was created.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of created_at
+    # and will be removed in the next major release.
     sl_attr :created, 'createDate'
 
     ##
diff --git a/lib/softlayer/VLANFirewall.rb b/lib/softlayer/VLANFirewall.rb
@@ -79,7 +79,7 @@ def primaryRouter
     ##
     # The fully qualified domain name of the physical device the
     # firewall is implemented by.
-    def fully_qualified_domain_name
+    def fqdn
       if self.has_sl_property?('networkVlanFirewall')
         return self['networkVlanFirewall']['fullyQualifiedDomainName']
       else
@@ -91,7 +91,7 @@ def fully_qualified_domain_name
     # The fully qualified domain name of the physical device the
     # firewall is implemented by.
     #
-    # DEPRECATION WARNING: This method is deprecated in favor of fully_qualified_domain_name
+    # DEPRECATION WARNING: This method is deprecated in favor of fqdn
     # and will be removed in the next major release.
     def fullyQualifiedDomainName
       if self.has_sl_property?('networkVlanFirewall')
diff --git a/lib/softlayer/VirtualDiskImage.rb b/lib/softlayer/VirtualDiskImage.rb
@@ -25,19 +25,33 @@ class VirtualDiskImage < ModelBase
     # A disk image's unique md5 checksum.
     sl_attr :checksum
 
+    ##
+    # :attr_reader: created_at
+    # The date a disk image was created.
+    sl_attr :created_at,    'createDate'
+
     ##
     # :attr_reader: created
     # The date a disk image was created.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of created_at
+    # and will be removed in the next major release.
     sl_attr :created,    'createDate'
 
     ##
     # :attr_reader:
     # A brief description of a virtual disk image.
     sl_attr :description
 
+    ##
+    # :attr_reader: modified_at
+    # The date a disk image was last modified.
+    sl_attr :modified_at,   'modifyDate'
+
     ##
     # :attr_reader: modified
     # The date a disk image was last modified.
+    # DEPRECATION WARNING: This attribute is deprecated in favor of modified_at
+    # and will be removed in the next major release.
     sl_attr :modified,   'modifyDate'
 
     ##
diff --git a/lib/softlayer/VirtualServer.rb b/lib/softlayer/VirtualServer.rb
@@ -22,12 +22,12 @@ class VirtualServer < Server
     sl_attr :cores, 'maxCpu'
 
     ##
-    # :attr_reader: provision_date
+    # :attr_reader: provisioned_at
     # The date the Virtual Server was provisioned.  This attribute can be
     # nil if the SoftLayer system has not yet finished provisioning the
     # server (consequently this attribute is used by the #wait_until_ready
     # method to determine when a server has been provisioned)
-    sl_attr :provision_date, 'provisionDate'
+    sl_attr :provisioned_at, 'provisionDate'
 
     ##
     # :attr_reader:
@@ -36,7 +36,7 @@ class VirtualServer < Server
     # server (consequently this attribute is used by the #wait_until_ready
     # method to determine when a server has been provisioned)
     #
-    # DEPRECATION WARNING: This attribute is deprecated in favor of provision_date
+    # DEPRECATION WARNING: This attribute is deprecated in favor of provisioned_at
     # and will be removed in the next major release.
     sl_attr :provisionDate
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ module SoftLayer`
`15`	`15`	`# Instances of this class roughly correspond to instances of the`
`16`	`16`	`# SoftLayer_Network_Component_Firewall service entity.`
`17`	`17`	`#`
`18`		`- class ServerFirewall < SoftLayer::ModelBase`
	`18`	`+ class ServerFirewall < SoftLayer::ModelBase`
`19`	`19`	`include ::SoftLayer::DynamicAttribute`
`20`	`20`
`21`	`21`	`##`