Fix rdoc in Server for Network Monitor attributes and move the query result status descriptions into its respective class

Author: ju2wheels

lib/softlayer/NetworkMonitor.rb

@@ -20,6 +20,17 @@ def initialize(monitor_levels_data)
   # This struct represents a network monitor query result that shows the last
   # state of the network monitor
   class NetworkMonitorQueryResult < Struct.new(:finished_at, :responded_in, :response_status)
+    ##
+    # This constant is a mapping of network monitor query result statuses to descriptions
+    QUERY_RESULT_STATUS_DESCRIPTIONS    = {
+      0 => "Down/Critical: Server is down and/or has passed the critical response threshold (extremely long ping response, abnormal behavior, etc.).",
+      1 => "Warning - Server may be recovering from a previous down state, or may have taken too long to respond.",
+      2 => "Up",
+      3 => "Not used",
+      4 => "Unknown - An unknown error has occurred. If the problem persists, contact support.",
+      5 => "Unknown - An unknown error has occurred. If the problem persists, contact support."
+    }
+
     def initialize(query_result_data)
       self.finished_at     = query_result_data['finishTime']
       self.responded_in    = query_result_data['responseTime']
@@ -60,15 +71,6 @@ def initialize(response_type_data)
   class NetworkMonitor < ModelBase
     include ::SoftLayer::DynamicAttribute
 
-    QUERY_RESULT_DESCRIPTIONS    = {
-      0 => "Down/Critical: Server is down and/or has passed the critical response threshold (extremely long ping response, abnormal behavior, etc.).",
-      1 => "Warning - Server may be recovering from a previous down state, or may have taken too long to respond.",
-      2 => "Up",
-      3 => "Not used",
-      4 => "Unknown - An unknown error has occurred. If the problem persists, contact support.",
-      5 => "Unknown - An unknown error has occurred. If the problem persists, contact support."
-    }
-
     @@available_query_types    = nil
     @@available_response_types = nil
 

lib/softlayer/Server.rb

@@ -55,7 +55,8 @@ class Server  < SoftLayer::ModelBase
 
     ##
     # The maximum network monitor query/response levels currently supported by the server
-    #
+    # :call-seq:
+    #   network_monitor_levels(force_update=false)
     sl_dynamic_attr :network_monitor_levels do |resource|
       resource.should_update? do
         @network_monitor_levels == nil
@@ -68,7 +69,8 @@ class Server  < SoftLayer::ModelBase
 
     ##
     # A lsst of configured network monitors.
-    #
+    # :call-seq:
+    #   network_monitors(force_update=false)
     sl_dynamic_attr :network_monitors do |resource|
       resource.should_update? do
         @network_monitors == nil
@@ -88,6 +90,8 @@ class Server  < SoftLayer::ModelBase
     ##
     # :attr_reader:
     # The list of user customers notified on monitoring failures
+    # :call-seq:
+    #   notified_network_monitor_users(force_update=false)
     sl_dynamic_attr :notified_network_monitor_users do |resource|
       resource.should_update? do
         #only retrieved once per instance