Skip to content

Merge catch blocks in the host function definitions #964

@NorbertKlockiewicz

Description

@NorbertKlockiewicz

https://github.com/facebook/react-native/blob/v0.81.5/packages/react-native/ReactCommon/yoga/cmake/project-defaults.cmake

E.g. these lines:

} catch (const std::runtime_error &e) {
// This catch should be merged with the next one
// (std::runtime_error inherits from std::exception) HOWEVER react
// native has broken RTTI which breaks proper exception type
// checking. Remove when the following change is present in our
// version:
// https://github.com/facebook/react-native/commit/3132cc88dd46f95898a756456bebeeb6c248f20e
throw jsi::JSError(runtime, e.what());
} catch (const std::exception &e) {
throw jsi::JSError(runtime, e.what());
} catch (...) {
throw jsi::JSError(runtime, "Unknown error while unloading a model");

Metadata

Metadata

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions