fix instance running check when app offline

githubname1024 · githubname1024 · commit 484820fc2ef1 · 2022-12-28T17:41:17.000+08:00
diff --git a/cachecloud-web/src/main/java/com/sohu/cache/inspect/impl/InstanceRunInspector.java b/cachecloud-web/src/main/java/com/sohu/cache/inspect/impl/InstanceRunInspector.java
@@ -154,12 +154,17 @@ private BooleanEnum updateInstanceByRun(boolean isRun, InstanceInfo info) {
                     return BooleanEnum.TRUE;
                 }
             } else {
-                if (info.getStatus() != InstanceStatusEnum.ERROR_STATUS.getStatus()) {
+                if (info.getStatus() != InstanceStatusEnum.ERROR_STATUS.getStatus()
+                        && info.getStatus() != InstanceStatusEnum.OFFLINE_STATUS.getStatus()) {
                     info.setStatus(InstanceStatusEnum.ERROR_STATUS.getStatus());
                     instanceDao.update(info);
                     logger.error("instance:{} instance failed", info);
                     saveFault(info, isRun);
                     return BooleanEnum.FALSE;
+                }else if(info.getStatus() == InstanceStatusEnum.OFFLINE_STATUS.getStatus()){
+                    logger.error("instance:{} instance is offline", info);
+                    saveFault(info, isRun);
+                    return BooleanEnum.OTHER;
                 }
             }
         } catch (Exception e) {

Original file line number	Diff line number	Diff line change
`@@ -154,12 +154,17 @@ private BooleanEnum updateInstanceByRun(boolean isRun, InstanceInfo info) {`
`154`	`154`	`return BooleanEnum.TRUE;`
`155`	`155`	`}`
`156`	`156`	`} else {`
`157`		`- if (info.getStatus() != InstanceStatusEnum.ERROR_STATUS.getStatus()) {`
	`157`	`+ if (info.getStatus() != InstanceStatusEnum.ERROR_STATUS.getStatus()`
	`158`	`+ && info.getStatus() != InstanceStatusEnum.OFFLINE_STATUS.getStatus()) {`
`158`	`159`	`info.setStatus(InstanceStatusEnum.ERROR_STATUS.getStatus());`
`159`	`160`	`instanceDao.update(info);`
`160`	`161`	`logger.error("instance:{} instance failed", info);`
`161`	`162`	`saveFault(info, isRun);`
`162`	`163`	`return BooleanEnum.FALSE;`
	`164`	`+ }else if(info.getStatus() == InstanceStatusEnum.OFFLINE_STATUS.getStatus()){`
	`165`	`+ logger.error("instance:{} instance is offline", info);`
	`166`	`+ saveFault(info, isRun);`
	`167`	`+ return BooleanEnum.OTHER;`
`163`	`168`	`}`
`164`	`169`	`}`
`165`	`170`	`} catch (Exception e) {`