Skip to content

Commit 313e67e

Browse files
authored
feat: require clientSecret in getAccessToken (#2)
BREAKING CHANGE: now requires to set client secret as there is no support for PKCE with only client ID.
1 parent c7f2101 commit 313e67e

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@ pnpm add @soliantconsulting/bitbucket-cloud-cli-auth
2020
```typescript
2121
import { getAccessToken } from "@soliantconsulting/bitbucket-cloud-cli-auth";
2222

23-
const accessToken = await getAccessToken(clientId, port);
23+
const accessToken = await getAccessToken(clientId, clientSecret, port);
2424
```

src/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const generateCodeVerifier = (): string => randomBytes(32).toString("base64url")
1010
const generateCodeChallenge = (codeVerifier: string): string =>
1111
createHash("sha256").update(codeVerifier).digest("base64url");
1212

13-
export const getAccessToken = async (clientId: string, port: number): Promise<string> => {
13+
export const getAccessToken = async (clientId: string, clientSecret: string, port: number): Promise<string> => {
1414
const codeVerifier = generateCodeVerifier();
1515
const codeChallenge = generateCodeChallenge(codeVerifier);
1616
const redirectUri = `http://localhost:${port}/`;
@@ -38,6 +38,7 @@ export const getAccessToken = async (clientId: string, port: number): Promise<st
3838
grant_type: "authorization_code",
3939
code,
4040
client_id: clientId,
41+
client_secret: clientSecret,
4142
code_verifier: codeVerifier,
4243
redirect_uri: redirectUri,
4344
}),

0 commit comments

Comments
 (0)