Skip to content

Commit 07cb653

Browse files
sukangpunchclaude
andcommitted
refactor: @Email 검증으로 보장된 중복 atIndex 검사 제거
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 7d475c6 commit 07cb653

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

src/main/java/com/example/solidconnection/siteuser/service/SchoolEmailService.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
package com.example.solidconnection.siteuser.service;
22

33
import static com.example.solidconnection.common.exception.ErrorCode.SCHOOL_EMAIL_ALREADY_VERIFIED;
4-
import static com.example.solidconnection.common.exception.ErrorCode.SCHOOL_EMAIL_VERIFICATION_INFO_CORRUPTED;
5-
import static com.example.solidconnection.common.exception.ErrorCode.SCHOOL_EMAIL_VERIFICATION_INFO_SAVE_FAILED;
64
import static com.example.solidconnection.common.exception.ErrorCode.SCHOOL_EMAIL_CONFIRM_CODE_DIFFERENT;
75
import static com.example.solidconnection.common.exception.ErrorCode.SCHOOL_EMAIL_CONFIRM_REQUEST_NOT_FOUND;
86
import static com.example.solidconnection.common.exception.ErrorCode.SCHOOL_EMAIL_DOMAIN_NOT_SUPPORTED;
7+
import static com.example.solidconnection.common.exception.ErrorCode.SCHOOL_EMAIL_VERIFICATION_INFO_CORRUPTED;
8+
import static com.example.solidconnection.common.exception.ErrorCode.SCHOOL_EMAIL_VERIFICATION_INFO_SAVE_FAILED;
99
import static com.example.solidconnection.common.exception.ErrorCode.USER_NOT_FOUND;
1010

1111
import com.example.solidconnection.common.exception.CustomException;
@@ -20,7 +20,6 @@
2020
import java.util.concurrent.ThreadLocalRandom;
2121
import java.util.concurrent.TimeUnit;
2222
import lombok.RequiredArgsConstructor;
23-
import org.springframework.beans.factory.annotation.Qualifier;
2423
import org.springframework.data.redis.core.RedisTemplate;
2524
import org.springframework.stereotype.Service;
2625
import org.springframework.transaction.annotation.Transactional;
@@ -38,6 +37,7 @@ public class SchoolEmailService {
3837
private final RedisTemplate<String, String> redisTemplate;
3938
private final ObjectMapper objectMapper;
4039

40+
@Transactional
4141
public void requestSchoolEmailVerification(long siteUserId, String schoolEmail) {
4242
SiteUser siteUser = siteUserRepository.findById(siteUserId)
4343
.orElseThrow(() -> new CustomException(USER_NOT_FOUND));
@@ -103,11 +103,7 @@ private SchoolVerificationInfo getVerificationInfo(long siteUserId) {
103103
}
104104

105105
private String extractEmailDomain(String email) {
106-
int atIndex = email.indexOf('@');
107-
if (atIndex == -1) {
108-
throw new CustomException(SCHOOL_EMAIL_DOMAIN_NOT_SUPPORTED);
109-
}
110-
return email.substring(atIndex + 1).toLowerCase();
106+
return email.substring(email.indexOf('@') + 1).toLowerCase();
111107
}
112108

113109
private String generateVerificationCode() {

0 commit comments

Comments
 (0)