Skip to content

Commit e79c748

Browse files
author
Christoph Halbartschlager
committed
ignore about:blank in decide-policy because those requests appear to
never finish
1 parent bba4a8f commit e79c748

1 file changed

Lines changed: 16 additions & 10 deletions

File tree

lib/WWW/WebKit2.pm

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -355,23 +355,29 @@ sub init_webkit {
355355

356356
$self->view->signal_connect('decide-policy' => sub {
357357
my ($view, $decision, $type) = @_;
358+
358359
if ($type eq 'navigation-action') {
360+
359361
my $action = $decision->get_navigation_action;
362+
my $action_uri = $action->get_request->get_uri;
360363

361-
if ($self->concurrent_active_navigation_warning
362-
and $self->active_navigation_action and not $action->is_redirect) {
364+
unless ($action_uri eq 'about:blank') {
363365

364-
warn "Already running a navigation action to " .
365-
$self->active_navigation_action
366-
. " when requested "
367-
. $action->get_navigation_type . ' ' . $action->get_request->get_uri;
368-
}
366+
if ($self->concurrent_active_navigation_warning
367+
and $self->active_navigation_action and not $action->is_redirect) {
369368

370-
$self->active_navigation_action($action->get_request->get_uri)
371-
if ($self->view->get_uri =~ s/#.*//r) ne ($action->get_request->get_uri =~ s/#.*//r)
372-
and not $action->is_redirect;
369+
warn "Already running a navigation action to " .
370+
$self->active_navigation_action
371+
. " when requested "
372+
. $action->get_navigation_type . ' ' . $action->get_request->get_uri;
373+
}
373374

375+
$self->active_navigation_action($action->get_request->get_uri)
376+
if ($self->view->get_uri =~ s/#.*//r) ne ($action->get_request->get_uri =~ s/#.*//r)
377+
and not $action->is_redirect;
378+
}
374379
}
380+
375381
$decision->use;
376382
return 0;
377383
});

0 commit comments

Comments
 (0)