Merge pull request #79 from sorryforthecommit/decide_policy_ignore_about_blanks

Decide policy ignore about:blank

Author: jscarty

Changes

@@ -32,3 +32,6 @@ Change to how page loading is checked in fire events.
 
 0.125 Mon Oct 5 13:15 CET 2020
 - allow multiple concurrent navigations (can be caused by iframes) and turn die into opt-in warn
+
+0.126 Tue Oct 6 11:00 CET 2020
+- navigation requests to about:blank never properly finish and cause WebKit to hang

lib/WWW/WebKit2.pm

@@ -53,9 +53,9 @@ use X11::Xlib;
 use Carp qw(carp croak);
 use XSLoader;
 use English '-no_match_vars';
-use POSIX qw<F_SETFD F_GETFD FD_CLOEXEC>;
+use POSIX qw(F_SETFD F_GETFD FD_CLOEXEC);
 
-our $VERSION = '0.125';
+our $VERSION = '0.126';
 
 use constant DOM_TYPE_ELEMENT => 1;
 use constant ORDERED_NODE_SNAPSHOT_TYPE => 7;
@@ -355,23 +355,29 @@ sub init_webkit {
 
     $self->view->signal_connect('decide-policy' => sub {
         my ($view, $decision, $type) = @_;
+
         if ($type eq 'navigation-action') {
+
             my $action = $decision->get_navigation_action;
+            my $action_uri = $action->get_request->get_uri;
 
-            if ($self->concurrent_active_navigation_warning
-                and $self->active_navigation_action and not $action->is_redirect) {
+            unless ($action_uri eq 'about:blank') {
 
-                warn "Already running a navigation action to " .
-                    $self->active_navigation_action
-                    . " when requested "
-                    . $action->get_navigation_type . ' ' . $action->get_request->get_uri;
-            }
+                if ($self->concurrent_active_navigation_warning
+                    and $self->active_navigation_action and not $action->is_redirect) {
 
-            $self->active_navigation_action($action->get_request->get_uri)
-                if ($self->view->get_uri =~ s/#.*//r) ne ($action->get_request->get_uri =~ s/#.*//r)
-                    and not $action->is_redirect;
+                    warn "Already running a navigation action to " .
+                        $self->active_navigation_action
+                        . " when requested "
+                        . $action->get_navigation_type . ' ' . $action->get_request->get_uri;
+                }
 
+                $self->active_navigation_action($action->get_request->get_uri)
+                    if ($self->view->get_uri =~ s/#.*//r) ne ($action->get_request->get_uri =~ s/#.*//r)
+                        and not $action->is_redirect;
+            }
         }
+
         $decision->use;
         return 0;
     });