Skip to content

Commit b7719c9

Browse files
committed
Remove MANIFEST.in; Migrate to pyproject.toml
With the use of setuptools_scm, all files that are tracked with the version control system will be included in the distribution anyway -- so there's no need to declared "graft/include" in the MANIFEST.in. The side effect of completely remove MANIFEST.in is the egg-info will be included. As setuptools can't be configured to prune src/spdx_tools.egg-info via pyproject.toml config. But the inclusion of egg-info is actually a standard practice (setuptools itself also include this information). The additional size of sdist when include the egg-info is 5.6 kbytes (704,357 vs 698,744 bytes). If needed, we can also include a minimal MANIFEST.in with one line: prune src/spdx_tools.egg-info to exclude the egg-info from sdist Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
1 parent cef432a commit b7719c9

3 files changed

Lines changed: 23 additions & 36 deletions

File tree

.gitignore

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,44 @@
1-
__pycache__/
2-
*.py[cod]
3-
*.out
1+
# Build outputs
42
/build/
53
/dist*/
6-
/tmp/
4+
*.egg-info/
5+
/.eggs/
76
src/spdx_tools/spdx/parser/tagvalue/parsetab.py
8-
/.cache/
97

8+
# Python cache
9+
__pycache__/
10+
*.py[cod]
11+
*.out
12+
13+
# Virtual environments
1014
.tox
1115
venv*
12-
13-
# virtualenv
1416
/bin
17+
/include
18+
/Include
1519
/lib
1620
/Lib
1721
/local
1822
/local/
19-
/.eggs/
20-
*.egg-info/
21-
/Include
22-
/include
23-
/pip-selfcheck.json
24-
.Python
2523
/share/
2624

2725
# IDEs
26+
.idea
2827
.project
2928
.pydevproject
30-
.idea
31-
org.eclipse.core.resources.prefs
3229
.vscode
33-
.pytest_cache
34-
35-
# Installer logs
36-
pip-log.txt
30+
org.eclipse.core.resources.prefs
3731

38-
# Unit test / coverage reports
32+
# Testing and type checking
3933
.cache
4034
.coverage
4135
.coverage.*
42-
nosetests.xml
36+
.mypy_cache
37+
.pytest_cache
4338
htmlcov
39+
40+
# OS temporary files
41+
*.*~
42+
._*
43+
.DS_Store
44+
/tmp/

.python-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
tools-python

MANIFEST.in

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1 @@
1-
graft examples
2-
graft src
3-
graft tests
4-
51
prune src/spdx_tools.egg-info
6-
7-
include .gitignore
8-
include README.md
9-
include CHANGELOG.md
10-
include CONTRIBUTING.md
11-
include DOCUMENTATION.md
12-
include LICENSE
13-
include setup.py
14-
include pyproject.toml
15-
16-
global-exclude *.py[co] __pycache__ *.*~ .DS_Store .pytest_cache .mypy_cache

0 commit comments

Comments
 (0)