To avoid too many array allocations now client uses array pool in TCP read method

Author: Ahmad Noman Musleh

src/OpenAPI.Net/OpenAPI.Net.csproj

@@ -9,7 +9,7 @@
     <PackageTags>cTrader, Open API, Spotware</PackageTags>
     <Description>A .NET RX library for Spotware Open API</Description>
     <PackageId>Spotware.OpenAPI.Net</PackageId>
-    <Version>1.3.9</Version>
+    <Version>1.4.0-rc0</Version>
     <Platforms>AnyCPU</Platforms>
     <Company>Spotware</Company>
     <Authors>Spotware</Authors>

src/OpenAPI.Net/OpenClient.cs

@@ -13,6 +13,7 @@
 using Websocket.Client;
 using System.Net.WebSockets;
 using System.Threading.Channels;
+using System.Buffers;
 
 namespace OpenAPI.Net
 {
@@ -376,11 +377,12 @@ private async Task StartSendingMessages(CancellationToken cancellationToken)
         /// <returns>Task</returns>
         private async void ReadTcp(CancellationToken cancellationToken)
         {
+            var lengthArray = new byte[sizeof(int)];
+
             try
             {
                 while (!IsDisposed)
                 {
-                    var lengthArray = new byte[sizeof(int)];
 
                     var readBytes = 0;
 
@@ -400,7 +402,7 @@ private async void ReadTcp(CancellationToken cancellationToken)
 
                     if (length <= 0) continue;
 
-                    var data = new byte[length];
+                    var data = ArrayPool<byte>.Shared.Rent(length);
 
                     readBytes = 0;
 
@@ -414,7 +416,9 @@ private async void ReadTcp(CancellationToken cancellationToken)
                     }
                     while (readBytes < length);
 
-                    var message = ProtoMessage.Parser.ParseFrom(data);
+                    var message = ProtoMessage.Parser.ParseFrom(data, 0, length);
+
+                    ArrayPool<byte>.Shared.Return(data);
 
                     OnNext(message);
                 }