Improve spring-artifactory-gradle-release.yml

* Add `check-if-no-opened-issues` & `check-last-snapshot-build`
before starting to build release
* Separate post-release actions to `post-release` job.
This way the tag and GH release won't be affected if update to spring.io page
or announce in chat fails

Author: artembilan

.github/workflows/spring-artifactory-gradle-release.yml

@@ -82,8 +82,39 @@ jobs:
   releaseVersion:
     uses: ./.github/workflows/spring-find-release-version.yml
 
-  staging:
+  check-if-no-opened-issues:
     needs: releaseVersion
+    name: Check is no opened issues for ${{ needs.releaseVersion.outputs.releaseVersion }}
+    runs-on: ${{ inputs.runner }}
+    steps:
+      - uses: spring-io/spring-release-actions/count-open-issues@0.0.3
+        id: count-open-issues
+        with:
+          milestone: ${{ needs.releaseVersion.outputs.releaseVersion }}
+      - name: Check if no opened issues
+        run: |
+          if [[ ${{ steps.count-open-issues.outputs.count }} -gt 0 ]]
+          then
+            gh run cancel ${{ github.run_id }}
+            echo "::warning title=Cannot release::The milestone ${{ steps.find-milestone.outputs.currentVersion }} has opened issues"
+          fi
+
+  check-last-snapshot-build:
+    needs: check-if-no-opened-issues
+    name: Check the last SNAPSHOT build for ${{ needs.releaseVersion.outputs.releaseVersion }}
+    runs-on: ${{ inputs.runner }}
+    steps:
+      - name: Check the last SNAPSHOT build is green
+        run: |
+          LAST_SNAPSHOT_BUILD_STATUS=$(gh run list -R ${{ github.repository }} -b ${{ github.ref_name }} -L 1 -w ci-snapshot.yml --json conclusion --jq .[0].conclusion)
+          if [[ $LAST_SNAPSHOT_BUILD_STATUS != 'success' ]]
+          then
+            gh run cancel ${{ github.run_id }}
+            echo "::warning title=Cannot release::The last SNAPSHOT build for milestone ${{ steps.find-milestone.outputs.currentVersion }} has not passed"
+          fi
+
+  staging:
+    needs: check-last-snapshot-build
     name: Stage ${{ needs.releaseVersion.outputs.releaseVersion }}
     uses: ./.github/workflows/spring-artifactory-gradle-build.yml
     with:
@@ -159,8 +190,37 @@ jobs:
   finalize:
     if: ${{ !(failure() || cancelled()) }}
     needs: [ releaseVersion, deploy-to-central, spring-release-bundle ]
-    name: Finalize ${{ needs.releaseVersion.outputs.releaseVersion }}
+    name: Finalize ${{ needs.releaseVersion.outputs.releaseVersion }} release
     uses: ./.github/workflows/spring-finalize-release.yml
     with:
       milestone: ${{ needs.releaseVersion.outputs.releaseVersion }}
     secrets: inherit
+
+  post-release:
+    if: ${{ !(failure() || cancelled()) }}
+    needs: [ releaseVersion, finalize ]
+    name: Post-procedure for ${{ needs.releaseVersion.outputs.releaseVersion }} release
+    runs-on: ${{ inputs.runner }}
+    steps:
+      - name: Checkout Common Repo
+        uses: actions/checkout@v6
+        with:
+          repository: spring-io/spring-github-workflows
+          path: .github/spring-github-workflows
+          show-progress: false
+          ref: ${{ env.WORKFLOWS_REF }}
+
+      - name: Update Spring IO website for new version
+        uses: ./.github/spring-github-workflows/.github/actions/spring-website-project-version-update
+        with:
+          newVersion: ${{ needs.releaseVersion.outputs.releaseVersion }}
+          token: ${{ secrets.GH_ACTIONS_REPO_TOKEN }}
+
+      - name: Announce Release in Chat
+        if: env.CHAT_WEBHOOK_URL
+        uses: spring-io/spring-release-actions/announce-on-gchat@0.0.3
+        with:
+          gchat-webhook-url: ${{ env.CHAT_WEBHOOK_URL }}
+          version: ${{ needs.releaseVersion.outputs.releaseVersion }}
+        env:
+          CHAT_WEBHOOK_URL: ${{ secrets.SPRING_RELEASE_CHAT_WEBHOOK_URL }}

.github/workflows/spring-finalize-release.yml

@@ -102,39 +102,4 @@ jobs:
       - name: Close Milestone
         uses: spring-io/spring-release-actions/close-milestone@0.0.3
         with:
-          version: ${{ inputs.milestone }}
-
-      - name: Checkout Common Repo
-        uses: actions/checkout@v6
-        with:
-          repository: spring-io/spring-github-workflows
-          path: .github/spring-github-workflows
-          show-progress: false
-          ref: ${{ env.WORKFLOWS_REF }}
-
-      - name: Update Spring IO website for new version
-        uses: ./.github/spring-github-workflows/.github/actions/spring-website-project-version-update
-        with:
-          newVersion: ${{ inputs.milestone }}
-          token: ${{ secrets.GH_ACTIONS_REPO_TOKEN }}
-
-      - name: Announce Release in Chat
-        if: env.CHAT_WEBHOOK_URL
-        uses: spring-io/spring-release-actions/announce-on-gchat@0.0.3
-        with:
-          gchat-webhook-url: ${{ env.CHAT_WEBHOOK_URL }}
-          version: ${{ inputs.milestone }}
-        env:
-          CHAT_WEBHOOK_URL: ${{ secrets.SPRING_RELEASE_CHAT_WEBHOOK_URL }}
-
-#      - name: Announce Release on Slack
-#        uses: slackapi/slack-github-action@v1.26.0
-#        if: env.SLACK_WEBHOOK_URL
-#        env:
-#          SLACK_WEBHOOK_URL: ${{ secrets.SPRING_RELEASE_SLACK_WEBHOOK_URL }}
-#          SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
-#        with:
-#          payload: |
-#            {
-#              "text": "${{ github.event.repository.name }}-announcing `${{ inputs.milestone }}`"
-#            }
+          version: ${{ inputs.milestone }}