fix: prevent started process starting again (#160)

<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->

## Related Issue Or Context
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Otherwise, describe context and motivation for change herre -->

Closes: #<issue>

## How Has This Been Tested? Testing details.
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentation

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have ensured that all acceptance criteria (or expected behavior)
from issue are met
- [ ] I have updated the documentation locally and in docs.
- [ ] I have added tests to cover my changes.
- [ ] I have ensured that all the checks are passing and green, I've
signed the CLA bot

Author: mpetrun5

tss/coordinator.go

@@ -16,6 +16,7 @@ import (
 	"github.com/sourcegraph/conc/pool"
 	"github.com/sprintertech/sprinter-signing/comm"
 	"github.com/sprintertech/sprinter-signing/comm/elector"
+	"github.com/sprintertech/sprinter-signing/tss/ecdsa/common"
 	"github.com/sprintertech/sprinter-signing/tss/message"
 	"golang.org/x/exp/slices"
 )
@@ -236,13 +237,7 @@ func (c *Coordinator) initiate(
 
 				_ = c.communication.Broadcast(c.host.Peerstore().Peers(), startMsgBytes, comm.TssStartMsg, tssProcess.SessionID())
 				ticker.Stop()
-				go func() {
-					err := tssProcess.Run(ctx, true, resultChn, startParams)
-					select {
-					case errChn <- err:
-					default:
-					}
-				}()
+				go c.startProcess(ctx, tssProcess, true, startParams, resultChn, errChn)
 			}
 		case <-ticker.C:
 			{
@@ -305,13 +300,7 @@ func (c *Coordinator) waitForStart(
 					return err
 				}
 
-				go func() {
-					err := tssProcess.Run(ctx, false, resultChn, msg.Params)
-					select {
-					case errChn <- err:
-					default:
-					}
-				}()
+				go c.startProcess(ctx, tssProcess, false, msg.Params, resultChn, errChn)
 			}
 		case <-ctx.Done():
 			{
@@ -320,3 +309,21 @@ func (c *Coordinator) waitForStart(
 		}
 	}
 }
+
+func (c *Coordinator) startProcess(
+	ctx context.Context,
+	tssProcess TssProcess,
+	coordinator bool,
+	startParams []byte,
+	resultChn chan interface{},
+	errChn chan error) {
+	err := tssProcess.Run(ctx, coordinator, resultChn, startParams)
+	if errors.Is(err, common.ErrProcessStarted) {
+		return
+	}
+
+	select {
+	case errChn <- err:
+	default:
+	}
+}

tss/ecdsa/common/base.go

@@ -5,9 +5,11 @@ package common
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"math/big"
 	"runtime/debug"
+	"sync"
 	"time"
 
 	"github.com/binance-chain/tss-lib/tss"
@@ -24,13 +26,17 @@ type Party interface {
 	WaitingFor() []*tss.PartyID
 }
 
+var ErrProcessStarted = errors.New("process already started")
+
 // BaseTss contains common variables and methods to
 // all tss processes.
 type BaseTss struct {
 	Host          host.Host
 	SID           string
 	Party         Party
 	PartyStore    map[string]*tss.PartyID
+	Started       bool
+	Mux           *sync.Mutex
 	Communication comm.Communication
 	Peers         []peer.ID
 	Log           zerolog.Logger

tss/ecdsa/keygen/keygen.go

@@ -7,6 +7,7 @@ import (
 	"context"
 	"errors"
 	"math/big"
+	"sync"
 	"time"
 
 	"github.com/binance-chain/tss-lib/ecdsa/keygen"
@@ -51,6 +52,8 @@ func NewKeygen(
 			Peers:         host.Peerstore().Peers(),
 			SID:           sessionID,
 			Log:           log.With().Str("SessionID", sessionID).Str("Process", "keygen").Logger(),
+			Started:       false,
+			Mux:           &sync.Mutex{},
 			Cancel:        func() {},
 			TssTimeout:    time.Minute * 10,
 		},
@@ -68,6 +71,14 @@ func (k *Keygen) Run(
 	resultChn chan interface{},
 	params []byte,
 ) error {
+	k.Mux.Lock()
+	if k.Started {
+		k.Mux.Unlock()
+		k.Log.Warn().Msgf("Keygen already started")
+		return common.ErrProcessStarted
+	}
+	k.Started = true
+	k.Mux.Unlock()
 	ctx, k.Cancel = context.WithCancel(ctx)
 
 	k.storer.LockKeyshare()

tss/ecdsa/resharing/resharing.go

@@ -8,6 +8,7 @@ import (
 	"encoding/json"
 	"errors"
 	"math/big"
+	"sync"
 	"time"
 
 	"github.com/binance-chain/tss-lib/ecdsa/keygen"
@@ -68,6 +69,8 @@ func NewResharing(
 			Peers:         host.Peerstore().Peers(),
 			SID:           sessionID,
 			Log:           log.With().Str("SessionID", sessionID).Str("Process", "resharing").Logger(),
+			Started:       false,
+			Mux:           &sync.Mutex{},
 			Cancel:        func() {},
 			TssTimeout:    time.Minute * 10,
 		},
@@ -85,6 +88,15 @@ func (r *Resharing) Run(
 	resultChn chan interface{},
 	params []byte,
 ) error {
+	r.Mux.Lock()
+	if r.Started {
+		r.Mux.Unlock()
+		r.Log.Warn().Msgf("Resharing already started")
+		return common.ErrProcessStarted
+	}
+	r.Started = true
+	r.Mux.Unlock()
+
 	ctx, r.Cancel = context.WithCancel(ctx)
 
 	startParams, err := r.unmarshallStartParams(params)

tss/ecdsa/signing/signing.go

@@ -9,6 +9,7 @@ import (
 	"fmt"
 	"math/big"
 	"reflect"
+	"sync"
 	"time"
 
 	tssCommon "github.com/binance-chain/tss-lib/common"
@@ -72,9 +73,11 @@ func NewSigning(
 			Communication: comm,
 			Peers:         key.Peers,
 			SID:           sessionID,
+			Started:       false,
+			Mux:           &sync.Mutex{},
 			Log:           log.With().Str("SessionID", sessionID).Str("messageID", messageID).Str("Process", "signing").Logger(),
 			Cancel:        func() {},
-			TssTimeout:    time.Second * 30,
+			TssTimeout:    time.Second * 8,
 		},
 		key: key,
 		msg: msg,
@@ -89,6 +92,15 @@ func (s *Signing) Run(
 	resultChn chan interface{},
 	params []byte,
 ) error {
+	s.Mux.Lock()
+	if s.Started {
+		s.Mux.Unlock()
+		s.Log.Warn().Msgf("Signing already started")
+		return common.ErrProcessStarted
+	}
+	s.Started = true
+	s.Mux.Unlock()
+
 	s.coordinator = coordinator
 	s.resultChn = resultChn
 	ctx, s.Cancel = context.WithCancel(ctx)