Added check for MSOLAP driver.

Added heuristic to create a valid ODC file.

Author: marcosqlbi

AnalyzeInExcel/AnalyzeInExcelAutoUpdater.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <item>
-	<version>1.0.2.0</version>
-	<url>https://cdn.sqlbi.com/updates/AnalyzeInExcel-1.0.2.msi</url>
+	<version>1.0.4.0</version>
+	<url>https://cdn.sqlbi.com/updates/AnalyzeInExcel-1.0.4.msi</url>
 	<changelog>https://github.com/sql-bi/AnalyzeInExcel/releases/</changelog>
 	<mandatory>false</mandatory>
 </item>

AnalyzeInExcel/App.xaml.cs

@@ -15,6 +15,7 @@ namespace AnalyzeInExcel
     public partial class App : Application
     {
         public Options AppOptions;
+        const string MSOLAP_DRIVER_URL = @"https://go.microsoft.com/fwlink/?LinkId=746283";
 
         public void CheckUpdates(bool synchronous = true)
         {
@@ -45,6 +46,10 @@ public MessageBoxResult ShowMessage( string message )
         {
             return MessageBox.Show(message, "Analyze in Excel for Power BI Desktop");
         }
+        public MessageBoxResult ShowMessageQuestion(string message)
+        {
+            return MessageBox.Show(message, "Analyze in Excel for Power BI Desktop",MessageBoxButton.YesNo, MessageBoxImage.Question, MessageBoxResult.Yes);
+        }
 
         protected override void OnStartup(StartupEventArgs e)
         {
@@ -63,7 +68,27 @@ protected override void OnStartup(StartupEventArgs e)
             {
                 string serverName = ((App)Application.Current).AppOptions?.Server;
                 string databaseName = ((App)Application.Current).AppOptions?.Database;
-                string cubeName = ModelHelper.GetModelName(serverName, databaseName, th);
+                bool goodMsOlapDriver = ModelHelper.HasMsOlapDriver();
+                if (!goodMsOlapDriver)
+                {
+                    th.TrackEvent("MSOLAP driver not found");
+                    if (ShowMessageQuestion($"Excel needs a component called MSOLAP driver to connect to Power BI. The MSOLAP driver might be missing or not updated on this device. Therefore, Excel might not connect to Power BI. You can install the updated Microsoft MSOLAP driver from this link: {MSOLAP_DRIVER_URL} \n\nClick YES if you want to download the updated MSOLAP driver and install it.\nClick NO to continue without any update.") == MessageBoxResult.Yes)
+                    {
+                        try
+                        {
+                            th.TrackEvent("Requested MSOLAP driver setup");
+                            UpdateMsOlapDriver();
+                        }
+                        catch (Exception ex)
+                        {
+                            // Send any exception to Telemetry
+                            th.TrackException(ex);
+                            ShowMessage($"Error running MSOLAP update: {ex.Message}");
+                        }
+                    }
+                }
+                // We use the default "Model" string if the MSOLAP driver is not available - if this happens, the previous warning helps understanding possible issues
+                string cubeName = goodMsOlapDriver ? ModelHelper.GetModelName(serverName, databaseName, th) : "Model"; 
                 if (serverName != null && databaseName != null)
                 {
                     try
@@ -121,6 +146,17 @@ protected override void OnStartup(StartupEventArgs e)
                 throw;
             }
 
+            void UpdateMsOlapDriver()
+            {
+                var p = new Process
+                {
+                    StartInfo = new ProcessStartInfo(MSOLAP_DRIVER_URL)
+                    {
+                        UseShellExecute = true
+                    }
+                };
+                p.Start();
+            }
         }
         private void OpenDiagnosticWindow(string serverName, string databaseName)
         {
@@ -141,8 +177,7 @@ Check that the file
         private void RunExcelProcess(string serverName, string databaseName, string cubeName)
         {
             // Create ODC file
-            OdcHelper.CreateOdcFile(serverName, databaseName, cubeName);
-            var fileName = OdcHelper.OdcFilePath();
+            var fileName = OdcHelper.CreateOdcFile(serverName, databaseName, cubeName);
 
             // Open ODC file
             var p = new Process

AnalyzeInExcel/ModelHelper.cs

@@ -9,6 +9,8 @@ namespace AnalyzeInExcel
 {
     public class ModelHelper
     {
+        const string MSOLAP_DRIVER_NAME = "MSOLAP"; // We get the latest available. We currently don't enforce MSOLAP.8
+
         internal enum AsInstanceType
         {
             Other,
@@ -43,6 +45,26 @@ internal static AsInstanceType GetAsInstanceType(string dataSourceUri)
             return AsInstanceType.Other;
         }
 
+        /// <summary>
+        /// Check whether the machine has the MSOLAP driver installed
+        /// The driver could be available in 32-bit and not in 64-bit
+        /// This would work in Excel, but it is better to try get the driver in that case
+        /// </summary>
+        /// <returns></returns>
+        public static bool HasMsOlapDriver()
+        {
+            const string SOURCES_NAME = "SOURCES_NAME";
+
+            var oleEnum = new OleDbEnumerator();
+            var elems = oleEnum.GetElements();
+            if (elems != null && elems.Rows != null)
+                foreach (System.Data.DataRow row in elems.Rows)
+                    if (!row.IsNull(SOURCES_NAME) && row[SOURCES_NAME] is string)
+                        if (row[SOURCES_NAME].ToString() == MSOLAP_DRIVER_NAME )
+                            return true;
+            return false;
+        }
+
         /// <summary>
         /// Returns the OLE DB connection string based on serverName and databaseName
         /// </summary>
@@ -56,16 +78,16 @@ public static string GetOleDbConnectionString( string serverName, string databas
             switch (GetAsInstanceType(serverName))
             {
                 case AsInstanceType.PbiDataset: // Integrated Security=ClaimsToken;
-                    connectionString = $"Provider=MSOLAP;Persist Security Info=True;Initial Catalog=sobe_wowvirtualserver-{databaseName};Data Source={serverName};MDX Compatibility=1;Safety Options=2;MDX Missing Member Mode=Error;Identity Provider=https://login.microsoftonline.com/common, https://analysis.windows.net/powerbi/api, 929d0ec0-7a41-4b1e-bc7c-b754a28bddcc;Update Isolation Level=2";
+                    connectionString = $"Provider={MSOLAP_DRIVER_NAME};Persist Security Info=True;Initial Catalog=sobe_wowvirtualserver-{databaseName};Data Source={serverName};MDX Compatibility=1;Safety Options=2;MDX Missing Member Mode=Error;Identity Provider=https://login.microsoftonline.com/common, https://analysis.windows.net/powerbi/api, 929d0ec0-7a41-4b1e-bc7c-b754a28bddcc;Update Isolation Level=2";
                     break;
                 case AsInstanceType.PbiDedicated:
                 case AsInstanceType.PbiPremium:
                 case AsInstanceType.AsAzure:
-                    connectionString = $"Provider=MSOLAP;Persist Security Info=True;Data Source={serverName};Update Isolation Level=2;Initial Catalog={databaseName}";
+                    connectionString = $"Provider={MSOLAP_DRIVER_NAME};Persist Security Info=True;Data Source={serverName};Update Isolation Level=2;Initial Catalog={databaseName}";
                     break;
                 case AsInstanceType.Other:
                 default:
-                    connectionString = $"Provider=MSOLAP;Integrated Security=SSPI;Persist Security Info=True;Data Source={serverName};Update Isolation Level=2;Initial Catalog={databaseName}";
+                    connectionString = $"Provider={MSOLAP_DRIVER_NAME};Integrated Security=SSPI;Persist Security Info=True;Data Source={serverName};Update Isolation Level=2;Initial Catalog={databaseName}";
                     break;
             }
             return connectionString;

AnalyzeInExcel/OdcHelper.cs

@@ -1,11 +1,12 @@
 using System;
 using System.IO;
+using System.Windows;
 
 namespace AnalyzeInExcel
 {
     public static class OdcHelper
     {
-        public static void CreateOdcFile(string datasource, string database, string cube)
+        public static string CreateOdcFile(string datasource, string database, string cube)
         {
             string oledbConnectionString = ModelHelper.GetOleDbConnectionString(datasource, database);
             string odcHeader = @"
@@ -120,18 +121,44 @@ function init() {
 
 ";
 
-            var odcPath = OdcFilePath();
+            var odcPath = GetOdcFilePath();
             File.WriteAllText(odcPath, odcHeader + string.Format(odcBody, oledbConnectionString, cube) + odcFooter);
-
+            return odcPath;
         }
 
-        public static string OdcFilePath()
+        private static string GetOdcFilePath()
         {
-            var myDocs = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments, Environment.SpecialFolderOption.Create);
-            var dsPath = Path.Combine(myDocs, "My Data Sources", "AnalyzeInExcel.odc");
+            const string ODC_FILENAME = "AnalyzeInExcel.odc";
+            const string MY_DATA_SOURCES = "My Data Sources"; // This is not localized - TODO find the localized version of this name
 
-            // ensure that the folder exists
-            Directory.CreateDirectory(Path.GetDirectoryName(dsPath));
+            var myDocs = Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments, Environment.SpecialFolderOption.Create);
+            var dsPath = Path.Combine(myDocs, MY_DATA_SOURCES, ODC_FILENAME);
+
+            try
+            {
+                // ensure that the folder exists
+                Directory.CreateDirectory(Path.GetDirectoryName(dsPath));
+            }
+            catch (Exception)
+            {
+                // If the folder is not available or accessible, try the file in MyDocuments
+                dsPath = Path.Combine(
+                    Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
+                    ODC_FILENAME);
+            }
+
+            try
+            {
+                using (StreamWriter w = File.AppendText(dsPath))
+                {
+                    // If the file can be opened this way, it should be writable
+                }
+            }
+            catch ( Exception )
+            {
+                // If the previous attempt fails, the last resort is creating the file in the TEMP directory
+                dsPath = Path.GetTempFileName().Replace(".tmp", "AnalyzeInExcel.odc");
+            }
             return dsPath;
         }
     }

AnalyzeInExcel/Properties/AssemblyInfo.cs

@@ -51,5 +51,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.3.0")]
-[assembly: AssemblyFileVersion("1.0.3.0")]
+[assembly: AssemblyVersion("1.0.4.0")]
+[assembly: AssemblyFileVersion("1.0.4.0")]

ExternalToolsInstaller/ExternalToolConfiguration.cs

@@ -6,6 +6,7 @@
 
 namespace ExternalToolsInstaller
 {
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE1006:Naming Styles", Justification = "Use names of external configuration")]
     public class ExternalToolConfiguration
     {
         public string version { get; set; }

ExternalToolsInstaller/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.3.0")]
-[assembly: AssemblyFileVersion("1.0.3.0")]
+[assembly: AssemblyVersion("1.0.4.0")]
+[assembly: AssemblyFileVersion("1.0.4.0")]

SetupAnalyzeInExcel/SetupAnalyzeInExcel.vdproj

@@ -1629,7 +1629,7 @@
             "SharedLegacy" = "11:FALSE"
             "PackageAs" = "3:1"
             "Register" = "3:1"
-            "Exclude" = "11:FALSE"
+            "Exclude" = "11:TRUE"
             "IsDependency" = "11:TRUE"
             "IsolateTo" = "8:"
             }
@@ -3420,15 +3420,15 @@
         {
         "Name" = "8:Microsoft Visual Studio"
         "ProductName" = "8:Analyze in Excel for Power BI Desktop"
-        "ProductCode" = "8:{46AF827B-0E49-4907-92FC-C60096C08105}"
-        "PackageCode" = "8:{588D46CE-2E9A-45E4-BDBA-03AA560416EF}"
+        "ProductCode" = "8:{2862FE53-3704-4B41-80B0-693BFFC187F0}"
+        "PackageCode" = "8:{CEF1CAA5-4465-474B-A077-E2A7C7D6414C}"
         "UpgradeCode" = "8:{FC2F9C00-CAD5-455E-BD9D-B1C607F4ABDA}"
         "AspNetVersion" = "8:4.0.30319.0"
         "RestartWWWService" = "11:FALSE"
         "RemovePreviousVersions" = "11:TRUE"
         "DetectNewerInstalledVersion" = "11:TRUE"
         "InstallAllUsers" = "11:TRUE"
-        "ProductVersion" = "8:1.0.3"
+        "ProductVersion" = "8:1.0.4"
         "Manufacturer" = "8:Sqlbi"
         "ARPHELPTELEPHONE" = "8:"
         "ARPHELPLINK" = "8:"
@@ -4116,7 +4116,7 @@
         {
             "{5259A561-127C-4D43-A0A1-72F10C7B3BF8}:_B8059F38185844FF9E7100633B552E00"
             {
-            "SourcePath" = "8:..\\AnalyzeInExcel\\obj\\Debug\\AnalyzeInExcel.exe"
+            "SourcePath" = "8:..\\AnalyzeInExcel\\obj\\Release\\AnalyzeInExcel.exe"
             "TargetName" = "8:"
             "Tag" = "8:"
             "Folder" = "8:_3C819D033B8E4ED29DA3C4B4E2E7B98C"
@@ -4144,7 +4144,7 @@
             }
             "{5259A561-127C-4D43-A0A1-72F10C7B3BF8}:_BE740B1BEB9D410F82DDE5AF811E1E7C"
             {
-            "SourcePath" = "8:..\\ExternalToolsInstaller\\obj\\Debug\\ExternalToolsInstaller.dll"
+            "SourcePath" = "8:..\\ExternalToolsInstaller\\obj\\Release\\ExternalToolsInstaller.dll"
             "TargetName" = "8:"
             "Tag" = "8:"
             "Folder" = "8:_3C819D033B8E4ED29DA3C4B4E2E7B98C"