Skip to content

Commit 84d741d

Browse files
committed
Fixed bug in telemetry option
1 parent b3042f3 commit 84d741d

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

ExternalToolsInstaller/ExternalToolsInstaller.cs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,15 @@ private void ExternalToolsInstaller_AfterInstall(object sender, InstallEventArgs
134134
string externalToolsExe = System.IO.Path.Combine(externalToolsDirectory, EXTERNALTOOLS_EXENAME);
135135
externalToolConfiguration.path = externalToolsExe;
136136

137-
// Fix telemetry argument
137+
// Remove existing telemetry option
138+
string telemetryOption = $" {TELEMETRY_ARGUMENT}";
139+
externalToolConfiguration.arguments = externalToolConfiguration.arguments.Replace(telemetryOption, "");
140+
externalToolConfiguration.arguments = externalToolConfiguration.arguments.Replace(telemetryOption.Trim(), "");
141+
142+
// Add telemetry argument if telemetry is enabled during setup
138143
if (telemetryEnabled)
139144
{
140-
externalToolConfiguration.arguments += $" {TELEMETRY_ARGUMENT}";
145+
externalToolConfiguration.arguments += telemetryOption;
141146
Context.LogMessage($"Telemetry enabled");
142147
}
143148

0 commit comments

Comments
 (0)