Skip to content

Commit 3b1cd24

Browse files
committed
Now ignore presentation role on elements that have no semantic meaning. Reference issue #274.
1 parent 783c78f commit 3b1cd24

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_3/1_3_1.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,12 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_3_1_3_1 = {
103103
*/
104104
testSemanticPresentationRole: function(element)
105105
{
106+
var permitted = ['div', 'span', 'b', 'i'];
106107
if (HTMLCS.util.isAriaHidden(element) === false
107108
&& element.hasAttribute('role')
108-
&& element.getAttribute('role') === 'presentation'
109+
&& element.getAttribute('role') === 'presentation'
110+
&& permitted.indexOf(element.nodeName.toLowerCase()) === -1
109111
) {
110-
var permitted = ['div', 'span', 'b', 'i'];
111112
var children = element.querySelectorAll('*:not('+permitted.join('):not(')+')');
112113
children = [].filter.call(children, function(child) {
113114
return child.hasAttribute('role') === false;

Tests/WCAG2/1_3_1_Presentation_Roles.html

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@
66
Name: SC 1.3.1 Presentation Roles
77
Standard: WCAG2AAA
88
Assert: No Error *.H37 on #deliberateFail1
9-
Assert: Error *.F92.ARIA4 on #ignoredRole
9+
Assert: No Error *.F92.ARIA4 on #ignoredRole
1010
Assert: No Error *.H37 on #deliberateFail2
1111
Assert: No Error *.F92.ARIA4 on #ariaHidden
1212
Assert: Error *.F92.ARIA4 on #incorrectUsageTable
13-
Assert: No Error *.F92.ARIA4 on #correctUsage
14-
Assert: No Error *.F92.ARIA4 on #correctUsage
1513
Assert: No Error *.F92.ARIA4 on #correctUsageWithRoles
1614
Assert: No Error *.F92.ARIA4 on #incorrectUsageTable2
1715
Assert: No Error *.F92.ARIA4 on #incorrectUsageTable3
@@ -34,9 +32,6 @@
3432
<th>Row 1 Col 2</th>
3533
</tr>
3634
</table>
37-
<div id="correctUsage" role="presentation">
38-
<span></span>
39-
</div>
4035
<ul role="tree">
4136
<li id="correctUsageWithRoles" role="presentation">
4237
<a role="treeitem" aria-expanded="true">An expanded tree node</a>

0 commit comments

Comments
 (0)