Removed most unused variables, and some kept in comments

paazmaya · paazmaya · commit 9c4924eea940 · 2018-11-15T16:02:26.000+02:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,7 +1,7 @@
 {
     "env": {
         "browser": true,
-        "node": true
+        "node": false
     },
     "extends": "eslint:recommended",
     "rules": {
@@ -17,7 +17,13 @@
             "error",
             "always"
         ],
+        "no-console": 0,
         "no-undef": 0,
+        "no-unused-vars": [
+            "error", {
+                "args": "none"
+            }
+        ],
         "no-redeclare": 0
     }
-}
+}
diff --git a/Contrib/PhantomJS/runner.js b/Contrib/PhantomJS/runner.js
@@ -1,3 +1,4 @@
+/* exported HTMLCS_RUNNER */
 var HTMLCS_RUNNER = _global.HTMLCS_RUNNER = new function() {
     this.run = function(standard, callback) {
         var self = this;
@@ -60,4 +61,4 @@ var HTMLCS_RUNNER = _global.HTMLCS_RUNNER = new function() {
         console.log('[HTMLCS] ' + typeName + '|' + msg.code + '|' + nodeName + '|' + elementId + '|' + msg.msg + '|' + html);
     };
 
-};
+};
diff --git a/Contrib/PhantomJS/test.js b/Contrib/PhantomJS/test.js
@@ -1,4 +1,4 @@
-let data = '';
+var data = '';
 
 process.stdin.resume();
 process.stdin.setEncoding('utf8');
@@ -15,8 +15,8 @@ function toHTML(obj) {
 }
 
 process.stdin.on('end', function() {
-    let issues = JSON.parse(data);
-    let html = `<table>
+    var issues = JSON.parse(data);
+    var html = `<table>
         <thead>
             <tr>
                 <th>Code</th>
diff --git a/Standards/Section508/Sniffs/A.js b/Standards/Section508/Sniffs/A.js
@@ -241,7 +241,6 @@ _global.HTMLCS_Section508_Sniffs_A = {
 
         for (var el = 0; el < elements.length; el++) {
             var element  = elements[el];
-            var nodeName = element.nodeName.toLowerCase();
 
             var childObject = element.querySelector('object');
 
diff --git a/Standards/Section508/Sniffs/B.js b/Standards/Section508/Sniffs/B.js
@@ -39,7 +39,6 @@ _global.HTMLCS_Section508_Sniffs_B = {
      */
     process: function(element, top)
     {
-        var nodeName = element.nodeName.toLowerCase();
         HTMLCS.addMessage(HTMLCS.NOTICE, element, 'For multimedia containing video, ensure a synchronised audio description or text alternative for the video portion is provided.', 'Video');
         HTMLCS.addMessage(HTMLCS.NOTICE, element, 'For multimedia containing synchronised audio and video, ensure synchronised captions are provided for the audio portion.', 'Captions');
 
diff --git a/Standards/Section508/Sniffs/L.js b/Standards/Section508/Sniffs/L.js
@@ -71,16 +71,17 @@ _global.HTMLCS_Section508_Sniffs_L = {
 
         for (var el = 0; el < elements.length; el++) {
             var element = elements[el];
-
-            var nameFound = false;
             var hrefFound = false;
             var content   = HTMLCS.util.getElementTextContent(element);
 
+            /*
+            var nameFound = false;
             if ((element.hasAttribute('title') === true) && (/^\s*$/.test(element.getAttribute('title')) === false)) {
                 nameFound = true;
             } else if (/^\s*$/.test(content) === false) {
                 nameFound = true;
             }
+            */
 
             if ((element.hasAttribute('href') === true) && (/^\s*$/.test(element.getAttribute('href')) === false)) {
                 hrefFound = true;
diff --git a/Standards/Section508/Sniffs/O.js b/Standards/Section508/Sniffs/O.js
@@ -68,6 +68,7 @@ _global.HTMLCS_Section508_Sniffs_O = {
                             }
                         }
                     } catch (ex) {
+                        // Ignore error
                     }//end try
                 }//end if
             }
diff --git a/Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_1/1_1_1.js b/Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_1/1_1_1.js
@@ -384,7 +384,6 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_1_1_1_1 = {
 
         for (var el = 0; el < elements.length; el++) {
             var element  = elements[el];
-            var nodeName = element.nodeName.toLowerCase();
 
             var childObject = element.querySelector('object');
 
diff --git a/Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_3/1_3_1.js b/Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_3/1_3_1.js
@@ -219,7 +219,6 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_3_1_3_1 = {
 
         // Firstly, work out whether it needs a label.
         var needsLabel = false;
-        var labelPos   = 'left';
         var inputType  = inputType.toLowerCase();
         if ((inputType === 'select' || inputType === 'textarea')) {
             needsLabel = true;
@@ -755,11 +754,11 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_3_1_3_1 = {
             }
 
             for (var i = 0; i < items.length; i++) {
-                if (/^[\-*]\s+/.test(items[0]) === true) {
+                if (/^[-*]\s+/.test(items[0]) === true) {
                     // Test for "- " or "* " cases.
                     HTMLCS.addMessage(HTMLCS.WARNING, element,  _global.HTMLCS.getTranslation("1_3_1_H48.1"), 'H48.1');
                     break;
-                } if (/^\d+[:\/\-.]?\s+/.test(items[0]) === true) {
+                } if (/^\d+[:/\-.]?\s+/.test(items[0]) === true) {
                     // Test for "1 " cases (or "1. ", "1: ", "1- ").
                     HTMLCS.addMessage(HTMLCS.WARNING, element, _global.HTMLCS.getTranslation("1_3_1_H48.2"), 'H48.2');
                     break;
@@ -775,7 +774,6 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_3_1_3_1 = {
         for (var i = 0; i < headings.length; i++) {
             var headingNum = parseInt(headings[i].nodeName.substr(1, 1));
             if (headingNum - lastHeading > 1) {
-                var exampleMsg = 'should be an h' + (lastHeading + 1) + ' to be properly nested';
                 if (lastHeading === 0) {
                     // If last heading is empty, we are at document top and we are
                     // expecting a H1, generally speaking.
@@ -813,7 +811,6 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_3_1_3_1 = {
 	 */
     testUnstructuredNavLinks: function(element)
     {
-        var nodeName    = element.nodeName.toLowerCase();
         var linksLength = 0;
 
         var childNodes  = element.childNodes;
diff --git a/Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3.js b/Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3.js
@@ -45,7 +45,6 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_4_1_4_3 = {
                 var required  = failures[i].required;
                 var recommend = failures[i].recommendation;
                 var hasBgImg  = failures[i].hasBgImage || false;
-                var bgColour   = failures[i].bgColour || false;
                 var isAbsolute = failures[i].isAbsolute || false;
                 var hasAlpha   = failures[i].hasAlpha || false;
 
diff --git a/Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js b/Standards/WCAG2AAA/Sniffs/Principle1/Guideline1_4/1_4_3_Contrast.js
@@ -14,9 +14,6 @@
 _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_4_1_4_3_Contrast = {
     testContrastRatio: function (top, minContrast, minLargeContrast)
     {
-        var startDate = new Date();
-        var count     = 0;
-        var xcount    = 0;
         var failures  = [];
 
         if (!top.ownerDocument) {
@@ -54,7 +51,6 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_4_1_4_3_Contrast = {
                     if (style) {
                         var bgColour   = style.backgroundColor;
                         var foreColour = style.color;
-                        var bgElement  = node;
                         var hasBgImg   = false;
                         var isAbsolute = false;
 
@@ -91,7 +87,6 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_4_1_4_3_Contrast = {
 
                             var parentStyle = HTMLCS.util.style(parent);
                             var bgColour    = parentStyle.backgroundColor;
-                            var bgElement   = parent;
                             if (parentStyle.backgroundImage !== 'none') {
                                 hasBgImg = true;
                             }
@@ -227,7 +222,7 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_4_1_4_3_Contrast = {
             }
 
             var hsv     = HTMLCS.util.sRGBtoHSV(newCol);
-            var chroma  = hsv.saturation * hsv.value;
+            // var chroma  = hsv.saturation * hsv.value;
             var newFore = fore;
             var newBack = back;
             var changed = false;
@@ -268,7 +263,7 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle1_Guideline1_4_1_4_3_Contrast = {
                         }
 
                         hsv     = HTMLCS.util.sRGBtoHSV(hsv);
-                        chroma  = hsv.saturation * hsv.value;
+                        // chroma  = hsv.saturation * hsv.value;
                         changed = true;
                     }
                 }
diff --git a/Standards/WCAG2AAA/Sniffs/Principle2/Guideline2_4/2_4_1.js b/Standards/WCAG2AAA/Sniffs/Principle2/Guideline2_4/2_4_1.js
@@ -145,6 +145,7 @@ _global.HTMLCS_WCAG2AAA_Sniffs_Principle2_Guideline2_4_2_4_1 = {
                         }
                     }
                 } catch (ex) {
+                    // Ignore error
                 }//end try
             }//end if
         }
diff --git a/Standards/WCAG2AAA/ruleset.js b/Standards/WCAG2AAA/ruleset.js
@@ -437,6 +437,7 @@ _global.HTMLCS_WCAG2AAA = {
         }
 
         var successCritStr = ['<a href="http://www.w3.org/TR/WCAG20/#' + successCritList[successCrit].landmark, '" target="_blank">', successCrit, ': ', successCritList[successCrit].name, '</a>'].join('');
+        /* eslint-disable-next-line no-unused-vars */
         var principleStr   = ['<a href="', principles[principle].link, '" target="_blank">', principles[principle].name, '</a>'].join('');
         var retval = [
             [_global.HTMLCS.getTranslation("auditor_success_criterion"), successCritStr],

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ _global.HTMLCS_Section508_Sniffs_B = {`
`39`	`39`	`*/`
`40`	`40`	`process: function(element, top)`
`41`	`41`	`{`
`42`		`- var nodeName = element.nodeName.toLowerCase();`
`43`	`42`	`HTMLCS.addMessage(HTMLCS.NOTICE, element, 'For multimedia containing video, ensure a synchronised audio description or text alternative for the video portion is provided.', 'Video');`
`44`	`43`	`HTMLCS.addMessage(HTMLCS.NOTICE, element, 'For multimedia containing synchronised audio and video, ensure synchronised captions are provided for the audio portion.', 'Captions');`
`45`	`44`
Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ _global.HTMLCS_Section508_Sniffs_O = {`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`	`} catch (ex) {`
	`71`	`+ // Ignore error`
`71`	`72`	`}//end try`
`72`	`73`	`}//end if`
`73`	`74`	`}`