feat: enhance coding agents and workflows

ssdeanx · ssdeanx · commit 23cea0c2b27f · 2025-12-06T04:52:10.000-05:00
- Added new workflows: researchSynthesisWorkflow, financialReportWorkflow, specGenerationWorkflow, repoIngestionWorkflow, and learningExtractionWorkflow to the Coding A2A Coordinator and Coding Team Network for improved orchestration of multi-topic tasks.
- Updated the model used in Coding A2A Coordinator and Coding Team Network to googleAIFlashLite for better performance.
- Integrated GitHub MCP client in codingAgents for enhanced tool capabilities.
- Improved findReferencesTool to utilize PythonParser for more accurate reference finding in Python files.
- Refactored multi-string edit tool for better readability and efficiency.
- Added find_references function in semantic-utils for improved symbol reference tracking.
diff --git a/src/mastra/a2a/codingA2ACoordinator.ts b/src/mastra/a2a/codingA2ACoordinator.ts
@@ -2,12 +2,17 @@ import { Agent } from '@mastra/core/agent'
 import { InternalSpans } from '@mastra/core/ai-tracing'
 import { createAnswerRelevancyScorer, createToxicityScorer } from '@mastra/evals/scorers/llm'
 
-import { googleAI, googleAIFlashLite } from '../config/google'
+import { googleAIFlashLite } from '../config/google'
 import { pgMemory } from '../config/pg-storage'
 import { log } from '../config/logger'
 import { taskCompletionScorer } from '../scorers/custom-scorers'
 
 import { codeArchitectAgent, codeReviewerAgent, testEngineerAgent, refactoringAgent } from '../agents/codingAgents'
+import { researchSynthesisWorkflow } from '../workflows/research-synthesis-workflow'
+import { financialReportWorkflow } from '../workflows/financial-report-workflow'
+import { specGenerationWorkflow } from '../workflows/spec-generation-workflow'
+import { repoIngestionWorkflow } from '../workflows/repo-ingestion-workflow'
+import { learningExtractionWorkflow } from '../workflows/learning-extraction-workflow'
 
 log.info('Initializing Coding A2A Coordinator...')
 
@@ -130,19 +135,26 @@ For each orchestration:
   - refactoringAgent: Generate improvement plan based on Phase 1
   - testEngineerAgent: Generate tests for proposed changes
 
-CRITICAL: Prefer parallel execution for independent tasks. Only use sequential when results depend on previous agent outputs.`,
+CRITICAL: Prefer parallel execution for independent tasks. Only use sequential when results depend on previous agent outputs.
+
+This coordinator also exposes higher-level workflows (researchSynthesisWorkflow, specGenerationWorkflow, repoIngestionWorkflow, learningExtractionWorkflow, financialReportWorkflow) that handle multi-topic research, spec generation, repo ingestion (RAG ingestion), learning extraction, and financial reports. When a user's request requires prolonged, structured work across multiple subtasks, prefer invoking these workflows and orchestrating agents around them.`,
       providerOptions: {
         google: {
           thinkingConfig: {
-            thinkingLevel: 'high',
             includeThoughts: true,
             thinkingBudget: -1,
-          }
+          },
+          mediaResolution: 'MEDIA_RESOLUTION_MEDIUM',
+          responseModalities: ['TEXT', 'IMAGE'],
+          maxOutputTokens: 64000,
+          temperature: 0.2,
+          topP: 0.95,
+          topK: 40,
         }
       }
     }
   },
-  model: googleAI,
+  model: googleAIFlashLite,
   memory: pgMemory,
   options: { tracingPolicy: { internal: InternalSpans.AGENT } },
   agents: {
@@ -151,7 +163,13 @@ CRITICAL: Prefer parallel execution for independent tasks. Only use sequential w
     testEngineerAgent,
     refactoringAgent,
   },
-  workflows: {},
+  workflows: {
+    researchSynthesisWorkflow,
+    financialReportWorkflow,
+    specGenerationWorkflow,
+    repoIngestionWorkflow,
+    learningExtractionWorkflow,
+  },
   tools: {},
   maxRetries: 5,
   scorers: {
@@ -165,7 +183,7 @@ CRITICAL: Prefer parallel execution for independent tasks. Only use sequential w
     },
     taskCompletion: {
       scorer: taskCompletionScorer,
-      sampling: { type: 'ratio', rate: 0.4 },
+      sampling: { type: 'ratio', rate: 0.8 },
     },
   },
 })
diff --git a/src/mastra/agents/codingAgents.ts b/src/mastra/agents/codingAgents.ts
@@ -25,6 +25,7 @@ import {
   searchCode,
   getFileContent
 } from '../tools/github'
+import { githubMCP } from '../mcp/mcp-client'
 
 export type UserTier = 'free' | 'pro' | 'enterprise'
 export type CodingRuntimeContext = {
@@ -84,13 +85,17 @@ Always consider maintainability, scalability, and testability in your recommenda
         google: {
           structuredOutput: true,
           thinkingConfig: {
-            thinkingLevel: userTier === 'enterprise' ? 'high' : 'medium',
+            thinkingLevel: userTier === 'enterprise' ? 'high' : 'low',
             includeThoughts: true,
             thinkingBudget: -1,
           },
-          responseModalities: ['TEXT'],
-          maxOutputTokens: 32000,
-          temperature: 0.3,
+          mediaResolution: 'MEDIA_RESOLUTION_LOW',
+          responseModalities: ['TEXT', 'IMAGE'],
+          maxOutputTokens: 64000,
+          temperature: 0.2,
+          topP: 0.95,
+          topK: 40,
+          
         }
       }
     }
@@ -110,6 +115,7 @@ Always consider maintainability, scalability, and testability in your recommenda
     getRepositoryInfo,
     searchCode,
     getFileContent,
+    ...githubMCP.getTools(),
   },
   memory: pgMemory,
   options: { tracingPolicy: { internal: InternalSpans.AGENT } },
@@ -332,6 +338,7 @@ Always use Vitest syntax: describe, it, expect, vi.mock, vi.fn.`,
     testGeneratorTool,
     codeSearchTool,
     execaTool,
+    ...githubMCP.getTools(),
   },
   memory: pgMemory,
   options: { tracingPolicy: { internal: InternalSpans.AGENT } },
diff --git a/src/mastra/mcp/mcp-client.ts b/src/mastra/mcp/mcp-client.ts
@@ -9,7 +9,7 @@ const NEO4J_DATABASE = process.env.NEO4J_DATABASE ?? "neo4j"
 
 const Klavis = process.env.KLAVIS_INSTANCE_ID;
 const strata = process.env.KLAVIS_STRATA;
-
+const github = process.env.GITHUB_API_KEY;
 export const mcpTools = new MCPClient({
   id: "mcp-client",
   servers: {
@@ -66,6 +66,30 @@ export const mcpTools = new MCPClient({
     },
   }
 });
+/*
+ * MCPClient with GitHub MCP Server using HTTP transport & Authorization
+ * https://github.com/microsoft/mcp/blob/main/docs/servers/github.md
+ * Requires GitHub API key with appropriate permissions.
+ * Set GITHUB_API_KEY env variable to use.
+ * See https://github.com/settings/tokens for more information.
+ * 
+ * Example:
+ * 
+ * githubMCP
+ */
+export const githubMCP = new MCPClient({
+  id: "mcp-client",
+  servers: {
+    github: {
+        url: new URL("https://api.githubcopilot.com/mcp/"),
+        requestInit: {
+          headers: {
+            Authorization: `Bearer ${github}`,
+          },
+        },
+      },
+  }
+});
 
 // MCPClient with Ampersand MCP Server using stdio transport
 //export const mcp = new MCPClient({
diff --git a/src/mastra/networks/codingTeamNetwork.ts b/src/mastra/networks/codingTeamNetwork.ts
@@ -1,11 +1,16 @@
 import { Agent } from '@mastra/core/agent'
 import { InternalSpans } from '@mastra/core/ai-tracing'
 
-import { googleAI } from '../config/google'
+import { googleAI, googleAIFlashLite } from '../config/google'
 import { pgMemory } from '../config/pg-storage'
 import { log } from '../config/logger'
 
 import { codeArchitectAgent, codeReviewerAgent, testEngineerAgent, refactoringAgent } from '../agents/codingAgents'
+import { researchSynthesisWorkflow } from '../workflows/research-synthesis-workflow'
+import { financialReportWorkflow } from '../workflows/financial-report-workflow'
+import { specGenerationWorkflow } from '../workflows/spec-generation-workflow'
+import { repoIngestionWorkflow } from '../workflows/repo-ingestion-workflow'
+import { learningExtractionWorkflow } from '../workflows/learning-extraction-workflow'
 
 log.info('Initializing Coding Team Network...')
 
@@ -64,7 +69,11 @@ export const codingTeamNetwork = new Agent({
    - Architecture → Implementation: codeArchitectAgent → refactoringAgent
    - Review → Fix: codeReviewerAgent → refactoringAgent
    - Code → Test: refactoringAgent → testEngineerAgent
-   - Full Cycle: codeArchitectAgent → refactoringAgent → codeReviewerAgent → testEngineerAgent
+  - Full Cycle: codeArchitectAgent → refactoringAgent → codeReviewerAgent → testEngineerAgent
+
+  This network also exposes higher-level workflows for common orchestration patterns: researchSynthesisWorkflow (multi-topic research & synthesis), specGenerationWorkflow (design/spec creation), repoIngestionWorkflow (ingest repository content into RAG pipelines), learningExtractionWorkflow (extract learnings with human-in-the-loop), and financialReportWorkflow (financial reports). Prefer invoking these workflows when a single network call should trigger a longer-running, structured process.
+
+  Provider options: networks should not generally require top-level provider overrides; prefer configuring providerOptions at the agent level (inside an agent's instructions) or passing runtime orchestration constraints. Use network-level provider constraints only for shared execution limits or budgets when coordinating agents across a federated workflow.
 
 ## Examples
 
@@ -88,8 +97,9 @@ export const codingTeamNetwork = new Agent({
 - Always explain which agent you're delegating to and why
 - For ambiguous requests, ask for clarification
 - Chain agents when the task requires multiple steps
-- Preserve context when passing between agents`,
-  model: googleAI,
+- Preserve context when passing between agents
+`,
+  model: googleAIFlashLite,
   memory: pgMemory,
   options: {
     tracingPolicy: { internal: InternalSpans.ALL },
@@ -101,7 +111,13 @@ export const codingTeamNetwork = new Agent({
     refactoringAgent,
   },
   tools: {},
-  workflows: {},
+  workflows: {
+    researchSynthesisWorkflow,
+    specGenerationWorkflow,
+    repoIngestionWorkflow,
+    learningExtractionWorkflow,
+    financialReportWorkflow,
+  },
   scorers: {},
 })
 
diff --git a/src/mastra/tools/find-references.tool.ts b/src/mastra/tools/find-references.tool.ts
@@ -141,21 +141,17 @@ export const findReferencesTool = createTool({
         for (const pyFile of pythonFiles) {
           try {
             const content = await readFile(pyFile, 'utf-8');
-            const lines = content.split('\n');
+            const references = await PythonParser.findReferences(content, symbolName);
             
-            // Text-based search for Python (fallback)
-            lines.forEach((lineContent, index) => {
-              if (lineContent.includes(symbolName)) {
-                const column = lineContent.indexOf(symbolName);
-                allReferences.push({
-                  filePath: pyFile,
-                  line: index + 1,
-                  column: column + 1,
-                  text: lineContent.trim().substring(0, 100),
-                  isDefinition: /^(def|class)\s/.test(lineContent.trim())
-                });
-              }
-            });
+            for (const ref of references) {
+              allReferences.push({
+                filePath: pyFile,
+                line: ref.line,
+                column: ref.column + 1, // Convert 0-indexed column to 1-indexed
+                text: ref.text.substring(0, 100),
+                isDefinition: ref.isDefinition
+              });
+            }
           } catch (error) {
             log.warn(`Error parsing Python file ${pyFile}`, { error });
           }
diff --git a/src/mastra/tools/find-symbol.tool.ts b/src/mastra/tools/find-symbol.tool.ts
@@ -197,16 +197,14 @@ function extractSymbolInfo(
   }
 
   // Variables
-  if (symbolType === 'all' || symbolType === 'variable') {
-    if (Node.isVariableDeclaration(node)) {
-      const name = node.getName();
-      const initializer = node.getInitializer();
-      if (name && name.includes(symbolName) && 
-           !Node.isArrowFunction(initializer) && 
-           !Node.isFunctionExpression(initializer)) {
-        return { name, kind: 'variable' };
-      }
-    }
+  if ((symbolType === 'all' || symbolType === 'variable') && Node.isVariableDeclaration(node)) {
+        const name = node.getName();
+        const initializer = node.getInitializer();
+        if (name && name.includes(symbolName) && 
+             !Node.isArrowFunction(initializer) && 
+             !Node.isFunctionExpression(initializer)) {
+          return { name, kind: 'variable' };
+        }
   }
 
   return null;
diff --git a/src/mastra/tools/multi-string-edit.tool.ts b/src/mastra/tools/multi-string-edit.tool.ts
@@ -126,32 +126,31 @@ Use for batch refactoring, multi-file updates, and coordinated code changes.`,
         let matchFound = false
 
         if (edit.useRegex) {
-          const flags = edit.replaceAll ? 'g' : ''
-          const regex = new RegExp(edit.oldString, flags)
-          if (regex.test(content)) {
-            newContent = content.replace(regex, edit.newString)
-            matchFound = true
-          }
-        } else {
-          if (content.includes(edit.oldString)) {
-            if (edit.replaceAll) {
-              newContent = content.split(edit.oldString).join(edit.newString)
-              matchFound = true
-            } else {
-              const occurrences = content.split(edit.oldString).length - 1
-              if (occurrences > 1) {
-                results.push({
-                  filePath,
-                  status: 'skipped',
-                  reason: `Multiple occurrences found (${occurrences}). Use replaceAll: true to replace all.`,
-                })
-                continue
-              }
-              newContent = content.replace(edit.oldString, edit.newString)
-              matchFound = true
-            }
-          }
-        }
+                  const flags = edit.replaceAll ? 'g' : ''
+                  const regex = new RegExp(edit.oldString, flags)
+                  if (regex.test(content)) {
+                    newContent = content.replace(regex, edit.newString)
+                    matchFound = true
+                  }
+                }
+        else if (content.includes(edit.oldString)) {
+                    if (edit.replaceAll) {
+                      newContent = content.split(edit.oldString).join(edit.newString)
+                      matchFound = true
+                    } else {
+                      const occurrences = content.split(edit.oldString).length - 1
+                      if (occurrences > 1) {
+                        results.push({
+                          filePath,
+                          status: 'skipped',
+                          reason: `Multiple occurrences found (${occurrences}). Use replaceAll: true to replace all.`,
+                        })
+                        continue
+                      }
+                      newContent = content.replace(edit.oldString, edit.newString)
+                      matchFound = true
+                    }
+                  }
 
         if (!matchFound) {
           results.push({
diff --git a/src/mastra/tools/semantic-utils.ts b/src/mastra/tools/semantic-utils.ts
