From 8b9951555b2244a12a2b6e2695456b2e0546a9b8 Mon Sep 17 00:00:00 2001 From: Joshua Temple Date: Sat, 13 Jun 2026 14:03:06 -0400 Subject: [PATCH] test: update stale e2e scenario assertions to match current generator output Signed-off-by: Joshua Temple --- e2e/scenarios/10-inline-job-attributes.yaml | 2 +- e2e/scenarios/12-inline-run-callback.yaml | 2 +- e2e/scenarios/orchestrate/env-gates.yaml | 10 +++++++++- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/e2e/scenarios/10-inline-job-attributes.yaml b/e2e/scenarios/10-inline-job-attributes.yaml index 068443e..257b5b6 100644 --- a/e2e/scenarios/10-inline-job-attributes.yaml +++ b/e2e/scenarios/10-inline-job-attributes.yaml @@ -53,4 +53,4 @@ steps: - "group: sign-${{ github.ref }}" - "cancel-in-progress: true" - "build-app:" - - "uses: ./build.yaml" + - "uses: ./.github/workflows/build.yaml" diff --git a/e2e/scenarios/12-inline-run-callback.yaml b/e2e/scenarios/12-inline-run-callback.yaml index bf8393f..7596a74 100644 --- a/e2e/scenarios/12-inline-run-callback.yaml +++ b/e2e/scenarios/12-inline-run-callback.yaml @@ -36,7 +36,7 @@ steps: - path: ".github/workflows/orchestrate.yaml" contains: - "build-app:" - - "uses: ./build.yaml" + - "uses: ./.github/workflows/build.yaml" - "build-smoke:" - "shell: bash" - 'echo "smoke check"' diff --git a/e2e/scenarios/orchestrate/env-gates.yaml b/e2e/scenarios/orchestrate/env-gates.yaml index e1c38e9..a900f75 100644 --- a/e2e/scenarios/orchestrate/env-gates.yaml +++ b/e2e/scenarios/orchestrate/env-gates.yaml @@ -4,6 +4,12 @@ description: | the generated orchestrate.yaml deploy job carries a job-level environment: key pointing at the configured GitHub Environment name (#11). + The job-level environment: key is only valid on a cascade-owned steps job, so + the gated deploy here is an inline run: deploy. A reusable-workflow (uses:) + deploy correctly omits the job-level key, since GitHub Actions forbids it on a + uses: caller job (#137/#138); the environment name is threaded as a with: + input instead in that case. + This is a generator-output verification scenario. The GitHub Environment's actual protection rules (required reviewers, wait timers, branch policy, scoped secrets) live in the repository's GitHub settings and are not @@ -18,7 +24,9 @@ config: triggers: ["src/**"] deploys: - name: cdk - workflow: deploy.yaml + run: | + echo "deploying cdk" + shell: bash triggers: ["cdk/**"] environment_config: prod: