From 4beb8c39b2034731f74f03c37e3a07d02ada61be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lukas=20Weberru=C3=9F?= Date: Wed, 21 Oct 2026 12:12:48 +0000 Subject: [PATCH] fix(ci): refresh native input coverage for Dev releases Review all 30 native inputs including project-qualified bucket naming, run external-source coverage without Go test caching, and allow 45 minutes for Dev staging and cold/warm Runner verification. Preserve individual step deadlines and release qualification gates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/configurator-release.yml | 4 ++-- .github/workflows/validate-configurator.yml | 2 +- .../deploy/cloud-foundry/README.de.md | 7 +++++++ landing-zone-configurator/deploy/cloud-foundry/README.md | 6 ++++++ .../tools/hcl-adapter/variables_test.go | 6 +++++- 5 files changed, 21 insertions(+), 4 deletions(-) diff --git a/.github/workflows/configurator-release.yml b/.github/workflows/configurator-release.yml index 565cbf6e..55fb9471 100644 --- a/.github/workflows/configurator-release.yml +++ b/.github/workflows/configurator-release.yml @@ -92,7 +92,7 @@ jobs: - name: Verify source templates match the release catalogue working-directory: landing-zone-configurator/tools/hcl-adapter run: | - go test ./... + go test -count=1 ./... go run . -check go run . -variables-source ../../../src/variables.tf -output ../../docs/accelerator-inputs.json -check go run . -variables-source ../../../src/variables.tf -output ../../app/packages/domain/src/accelerator-inputs.json -check @@ -198,7 +198,7 @@ jobs: actions: read contents: read runs-on: ubuntu-latest - timeout-minutes: 30 + timeout-minutes: 45 environment: name: lzc-dev-release url: https://lzc-dev-configurator.apps.01.cf.eu01.stackit.cloud diff --git a/.github/workflows/validate-configurator.yml b/.github/workflows/validate-configurator.yml index dbbcb1da..cbe96cc8 100644 --- a/.github/workflows/validate-configurator.yml +++ b/.github/workflows/validate-configurator.yml @@ -57,7 +57,7 @@ jobs: npm run build:packages - name: Test HCL importer and exporter and verify catalogue freshness run: | - go test ./... + go test -count=1 ./... go run . -check go run . -variables-source ../../../src/variables.tf -output ../../docs/accelerator-inputs.json -check go run . -variables-source ../../../src/variables.tf -output ../../app/packages/domain/src/accelerator-inputs.json -check diff --git a/landing-zone-configurator/deploy/cloud-foundry/README.de.md b/landing-zone-configurator/deploy/cloud-foundry/README.de.md index a2365dc8..60352709 100644 --- a/landing-zone-configurator/deploy/cloud-foundry/README.de.md +++ b/landing-zone-configurator/deploy/cloud-foundry/README.de.md @@ -307,6 +307,13 @@ Task-Status, bereinigte Diagnosen und öffentliche Health Checks liefern Release +Der Dev-Deployment-Job hat insgesamt 45 Minuten für Runner-Staging, +Datenbankmigrationen, App-Staging und die Prüfung kalter und vorgehaltener Runner. +Die Fristen einzelner Schritte gelten weiterhin. Die native Eingabeabdeckung +läuft bei PR-Prüfungen und Release-Builds mit `go test -count=1 ./...`, damit sie +den aktuellen Accelerator-Quellstand prüft und kein zwischengespeichertes +Testergebnis übernimmt. + ### Dev-Release ohne Live-Qualifikation des Assistant Bei Model-Serving-Ausfällen unter diff --git a/landing-zone-configurator/deploy/cloud-foundry/README.md b/landing-zone-configurator/deploy/cloud-foundry/README.md index 25044b30..64676ed1 100644 --- a/landing-zone-configurator/deploy/cloud-foundry/README.md +++ b/landing-zone-configurator/deploy/cloud-foundry/README.md @@ -294,6 +294,12 @@ separate explicit operations, not part of application release validation. Raw CF logs are not exported to CI, since router URLs may contain OAuth codes. Task status, sanitized diagnostics and public health checks provide release evidence. +The Dev deployment job has a 45-minute total budget for Runner staging, database +migrations, application staging and the cold/warm Runner checks. Individual step +deadlines still apply. Native input coverage runs with `go test -count=1 ./...` +in both PR validation and release builds so it checks the current Accelerator +source rather than accepting a cached test result. + ### Dev release without live Assistant qualification During Model Serving outages, select diff --git a/landing-zone-configurator/tools/hcl-adapter/variables_test.go b/landing-zone-configurator/tools/hcl-adapter/variables_test.go index fcf8bf83..c37fc241 100644 --- a/landing-zone-configurator/tools/hcl-adapter/variables_test.go +++ b/landing-zone-configurator/tools/hcl-adapter/variables_test.go @@ -19,13 +19,17 @@ func TestCompleteRootVariableInventory(t *testing.T) { if err := json.Unmarshal(raw, &result); err != nil { t.Fatal(err) } - if len(result.Variables) != 29 { + if len(result.Variables) != 30 { t.Fatalf("review Accelerator feature coverage: %d inputs", len(result.Variables)) } variables := map[string]variableDefinition{} for _, variable := range result.Variables { variables[variable.Name] = variable } + bucketNaming, exists := variables["bucket_naming"] + if !exists || string(bucketNaming.Type) != `"string"` || string(bucketNaming.Default) != `"project-id"` || bucketNaming.Required || bucketNaming.Sensitive || len(bucketNaming.Validations) == 0 { + t.Fatal("project-qualified bucket naming metadata lost") + } namespace, exists := variables["platform_contract_namespace"] if !exists || string(namespace.Type) != `"string"` || namespace.Sensitive || len(namespace.Validations) == 0 { t.Fatal("platform contract namespace metadata lost")