Core: skipLibCheck avoidance adjustments in TS build (prebid#14599)

* Core: skipLibCheck avoidance adjustments in TS build

* linting

* fixing order

* package-lock

* change googletag to any

* allowJs: false

* clean up

* clean up

Author: mkomorski

modules/consentManagementTcf.ts

@@ -45,7 +45,7 @@ export type TCFConsentData = {
   /**
    * The response from the CMP.
    */
-  vendorData: Record<string, unknown>;
+  vendorData: Record<string, string>;
   /**
    * Additional consent string, if provided by the CMP.
    * @see https://support.google.com/admanager/answer/9681920?hl=en

modules/michaoBidAdapter.ts

@@ -1,5 +1,6 @@
 import { ortbConverter } from '../libraries/ortbConverter/converter.js';
 import { type BidderSpec, registerBidder } from '../src/adapters/bidderFactory.js';
+import { Bid } from '../src/bidfactory.js';
 import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
 import { Renderer } from '../src/Renderer.js';
 import {
@@ -274,7 +275,7 @@ const converter = ortbConverter<typeof ENV.BIDDER_CODE>({
         id: bidRequest.bidId,
         adUnitCode: bidRequest.adUnitCode,
       });
-      renderer.setRender((bid) => {
+      renderer.setRender((bid: Bid) => {
         bid.renderer.push(() => {
           const inRenderer = new (window as any).InVideoRenderer();
           inRenderer.render(bid.adUnitCode, bid);

modules/pubstackBidAdapter.ts

@@ -8,7 +8,7 @@ import { BidRequest, ClientBidderRequest } from '../src/adapterManager.js';
 import { ORTBRequest } from '../src/prebid.public.js';
 import { config } from '../src/config.js';
 import { SyncType } from '../src/userSync.js';
-import { ConsentData, CONSENT_GDPR, CONSENT_USP, CONSENT_GPP } from '../src/consentHandler.js';
+import { ConsentDataForKey, CONSENT_GDPR, CONSENT_USP, CONSENT_GPP } from '../src/consentHandler.js';
 import { getGlobal } from '../src/prebidGlobal.js';
 
 const BIDDER_CODE = 'pubstack';
@@ -32,9 +32,9 @@ type GetUserSyncFn = (
     pixelEnabled: boolean;
   },
   responses: ServerResponse[],
-  gdprConsent: null | ConsentData[typeof CONSENT_GDPR],
-  uspConsent: null | ConsentData[typeof CONSENT_USP],
-  gppConsent: null | ConsentData[typeof CONSENT_GPP]) => ({ type: SyncType, url: string })[]
+  gdprConsent: null | ConsentDataForKey<typeof CONSENT_GDPR>,
+  uspConsent: null | ConsentDataForKey<typeof CONSENT_USP>,
+  gppConsent: null | ConsentDataForKey<typeof CONSENT_GPP>) => ({ type: SyncType, url: string })[]
 
 const siteIds: Set<string> = new Set();
 let cntRequest = 0;

src/adapterManager.ts

@@ -86,7 +86,7 @@ const _bidderRegistry = {};
 const _aliasRegistry: { [aliasCode: BidderCode]: BidderCode } = {};
 const _analyticsRegistry: { [P in AnalyticsProvider]?: { adapter: AnalyticsAdapter<P>, gvlid?: number } } = {};
 
-let _s2sConfigs = [];
+let _s2sConfigs : any[] | any = [];
 config.getConfig('s2sConfig', config => {
   if (config && config.s2sConfig) {
     _s2sConfigs = isArray(config.s2sConfig) ? config.s2sConfig : [config.s2sConfig];
@@ -927,6 +927,7 @@ const adapterManager = {
     config: AnalyticsConfig<keyof AnalyticsProviderConfig>
             | AnalyticsConfig<AnalyticsProvider>
             | AnalyticsConfig<AnalyticsProvider>[]
+            | any
   ) {
     if (!isArray(config)) {
       config = [config];

src/adapters/bidderFactory.ts

@@ -41,7 +41,7 @@ import type { BidderCode, StorageDisclosure } from "../types/common.d.ts";
 import type { Ajax, AjaxOptions, XHR } from "../ajax.ts";
 import type { AddBidResponse } from "../auction.ts";
 import type { MediaType } from "../mediaTypes.ts";
-import { CONSENT_GDPR, CONSENT_GPP, CONSENT_USP, type ConsentData } from "../consentHandler.ts";
+import { CONSENT_GDPR, CONSENT_GPP, CONSENT_USP, type ConsentDataForKey } from "../consentHandler.ts";
 
 /**
  * This file aims to support Adapters during the Prebid 0.x -> 1.x transition.
@@ -153,9 +153,9 @@ export interface BidderSpec<BIDDER extends BidderCode> extends StorageDisclosure
       pixelEnabled: boolean;
     },
     responses: ServerResponse[],
-    gdprConsent: null | ConsentData[typeof CONSENT_GDPR],
-    uspConsent: null | ConsentData[typeof CONSENT_USP],
-    gppConsent: null | ConsentData[typeof CONSENT_GPP]
+    gdprConsent: null | ConsentDataForKey<typeof CONSENT_GDPR>,
+    uspConsent: null | ConsentDataForKey<typeof CONSENT_USP>,
+    gppConsent: null | ConsentDataForKey<typeof CONSENT_GPP>
   ) => ({ type: SyncType, url: string })[];
   alwaysHasCapacity?: boolean;
 }

src/bidfactory.ts

@@ -167,6 +167,7 @@ export interface NativeBidProperties {
 
 export interface VideoBidProperties {
   mediaType: 'video' | 'audio';
+  videoCacheKey?: string;
 }
 
 type BidFrom<RESP, PROPS> = BaseBid & Omit<RESP, keyof BaseBid | keyof PROPS> & PROPS;

src/consentHandler.ts

@@ -22,6 +22,9 @@ export interface ConsentData {
   [CONSENT_COPPA]: boolean;
 }
 
+/** Resolves to ConsentData[K] when module has augmented that key, else unknown (core-only build). */
+export type ConsentDataForKey<K extends ConsentType> = K extends keyof ConsentData ? ConsentData[K] : unknown;
+
 type ConsentDataFor<T extends ConsentType> = T extends keyof ConsentData ? ConsentData[T] : null;
 
 // eslint-disable-next-line @typescript-eslint/no-empty-object-type

src/events.ts

@@ -24,7 +24,12 @@ export interface Events extends AllEvents {
 }
 
 export type EventIDs = {
-  [K in Event]: K extends keyof typeof EVENT_ID_PATHS ? Events[K][0][(typeof EVENT_ID_PATHS)[K]] : undefined;
+  [K in Event]:
+  K extends keyof typeof EVENT_ID_PATHS
+    ? Events[K][0] extends { [P in (typeof EVENT_ID_PATHS)[K]]: infer V }
+      ? V
+      : unknown
+    : undefined;
 };
 
 export type Event = keyof Events;

src/targeting.ts

@@ -134,7 +134,7 @@ export function sortByDealAndPriceBucketOrCpm(useCpm = false) {
  * @param adUnitCodes
  * @param getSlots
  */
-export function getGPTSlotsForAdUnits(adUnitCodes: AdUnitCode[], getSlots = () => window.googletag.pubads().getSlots()): ByAdUnit<googletag.Slot[]> {
+export function getGPTSlotsForAdUnits(adUnitCodes: AdUnitCode[], getSlots = () => (window as any).googletag.pubads().getSlots()): ByAdUnit<any[]> {
   return getSlots().reduce((auToSlots, slot) => {
     Object.keys(auToSlots).filter(isAdUnitCodeMatchingSlot(slot))
       .forEach(au => auToSlots[au].push(slot));
@@ -177,7 +177,7 @@ type TargetingValueLists = TargetingMap<string[]>;
 type TargetingArray = ByAdUnit<TargetingValueLists[]>[];
 
 type AdUnitPredicate = (adUnitCode: AdUnitCode) => boolean;
-export type SlotMatchingFn = (slot: googletag.Slot) => AdUnitPredicate;
+export type SlotMatchingFn = (slot: any) => AdUnitPredicate;
 
 declare module './events' {
   interface Events {

tsconfig.json

@@ -8,7 +8,7 @@
     "rootDir": "./",
     "outDir": "./dist/src/",
     "noImplicitAny": false,
-    "allowJs": true,
+    "allowJs": false,
     "checkJs": false,
     "types": [],
     "lib": ["es2019", "DOM"],